New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Perl-5.005.02: glitch in h2ph #792
Comments
From syl@alcor.concordia.caI think I may have found a bug in h2ph included in Perl-5.005. I I'm working on a Solaris-2.7 system (uname -a: SunOS monty 5.7 The script uses Sys::Syslog for logging, and it's that "use" statement The lines in the .../feature_tests.ph file (again, I apologize for long 17 if(defined( &_LP64)) { The original /usr/include/sys/feature_tests.h file from which that was 87 #if defined(_LP64) Note the #error messages are already surrounded by quotation marks. The 199 } elsif(/^error\s+(.*)/) { I propose the following patch (created against 5.005.01, but it should Inline Patch--- utils/h2ph.PL.original Fri Jul 24 00:02:28 1998
+++ utils/h2ph.PL Wed Oct 27 16:04:17 1999
@@ -230,10 +230,10 @@
print OUT $t,"}\n";
} elsif(/^undef\s+(\w+)/) {
print OUT $t, "undef(&$1) if defined(&$1);\n";
- } elsif(/^error\s+(.*)/) {
- print OUT $t, "die(\"$1\");\n";
- } elsif(/^warning\s+(.*)/) {
- print OUT $t, "warn(\"$1\");\n";
+ } elsif(/^error\s+("?)(.*)\1/) {
+ print OUT $t, "die(\"$2\");\n";
+ } elsif(/^warning\s+("?)(.*)\1/) {
+ print OUT $t, "warn(\"$2\");\n";
} elsif(/^ident\s+(.*)/) {
print OUT $t, "# $1\n";
}
I hope you'll consider incorporating this patch in a future release of -- Sylvain Robitaille syl@alcor.concordia.ca Systems analyst Concordia University : monty[syl] ~; perl -cwT /local/bin/newsyslog-2.1/newsyslog |
From [Unknown Contact. See original ticket]On Wed, Oct 27, 1999 at 05:36:26PM -0400, Sylvain Robitaille wrote:
Thanks for your bug report and patch. This has already been fixed Peace, |
From [Unknown Contact. See original ticket]On Wed, 27 Oct 1999, Kurt D. Starsinic wrote:
I see. Sorry I didn't check to see if there was a newer stable version mea culpa! Thanks for the response... -- Sylvain Robitaille syl@alcor.concordia.ca Systems analyst Concordia University |
Migrated from rt.perl.org#1719 (status was 'resolved')
Searchable as RT1719$
The text was updated successfully, but these errors were encountered: