Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better-sched and other async improvement ecosystem fallout #6628

Closed
p6rt opened this issue Oct 22, 2017 · 6 comments
Closed

better-sched and other async improvement ecosystem fallout #6628

p6rt opened this issue Oct 22, 2017 · 6 comments
Labels
regression Issue did not exist previously

Comments

@p6rt
Copy link

p6rt commented Oct 22, 2017

Migrated from rt.perl.org#132343 (status was 'resolved')

Searchable as RT132343$

@p6rt
Copy link
Author

p6rt commented Oct 22, 2017

From @AlexDaniel

Here are some of the modules that are failing on HEAD (but did not fail on 2017.09). At this moment I don't know if the modules are relying on some kind of buggy behavior (which is now fixed?), or if we actually have a regression. If it's not our fault, we still want to make sure that we have tests for these things.

1) WebSocket and better-sched merge

See this issue​: tokuhirom/p6-WebSocket#15

2) Test​::Scheduler and “Push Tap objects down to subscribers”

Also affected​: Concurrent​::Progress, SSH​:LibSSH

See jnthn/p6-test-scheduler#3

3) OO​::Actors and “Start using $*AWAITER in `await` in 6.c”

See jnthn/oo-actors#6

@p6rt
Copy link
Author

p6rt commented Oct 24, 2017

From @AlexDaniel

FWIW I'm not counting 2) and 3) as blockers, but 1) is worth taking a look at. See my comment here​: tokuhirom/p6-WebSocket#15 (comment)
On 2017-10-22 01​:37​:41, alex.jakimenko@​gmail.com wrote​:

Here are some of the modules that are failing on HEAD (but did not
fail on 2017.09). At this moment I don't know if the modules are
relying on some kind of buggy behavior (which is now fixed?), or if we
actually have a regression. If it's not our fault, we still want to
make sure that we have tests for these things.

1) WebSocket and better-sched merge

See this issue​: tokuhirom/p6-WebSocket#15

2) Test​::Scheduler and “Push Tap objects down to subscribers”

Also affected​: Concurrent​::Progress, SSH​:LibSSH

See jnthn/p6-test-scheduler#3

3) OO​::Actors and “Start using $*AWAITER in `await` in 6.c”

See jnthn/oo-actors#6

@p6rt
Copy link
Author

p6rt commented Oct 25, 2017

From @zoffixznet

On Tue, 24 Oct 2017 13​:30​:13 -0700, alex.jakimenko@​gmail.com wrote​:

FWIW I'm not counting 2) and 3) as blockers, but 1) is worth taking a
look at.
See my comment here​:
tokuhirom/p6-WebSocket#15 (comment)
339120879

That looks to be a bug in affinity workers in supply-in-a-sock scenarios.

I made a golfed test[^1] and a hack[^2] that makes the test pass, but isn't enough
to fix the WebSocket module tests, since it applies onto when there's one affinity
worker knocking about and the module likely has more.

Needs a proper fix for the *cause* of the deadlock or a smarter algo for when to
add more affinity workers.

[1] Raku/roast@74445dd
[2] rakudo/rakudo@ce7e544

@p6rt
Copy link
Author

p6rt commented Oct 25, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Oct 25, 2017

From @zoffixznet

On Tue, 24 Oct 2017 21​:48​:16 -0700, cpan@​zoffix.com wrote​:

On Tue, 24 Oct 2017 13​:30​:13 -0700, alex.jakimenko@​gmail.com wrote​:

FWIW I'm not counting 2) and 3) as blockers, but 1) is worth taking a
look at.
See my comment here​:
tokuhirom/p6-WebSocket#15 (comment)
339120879

That looks to be a bug in affinity workers in supply-in-a-sock
scenarios.

I made a golfed test[^1] and a hack[^2] that makes the test pass, but
isn't enough
to fix the WebSocket module tests, since it applies onto when there's
one affinity
worker knocking about and the module likely has more.

Needs a proper fix for the *cause* of the deadlock or a smarter algo
for when to
add more affinity workers.

[1]
Raku/roast@74445dd
[2]
rakudo/rakudo@ce7e544

This is now properly fixed in rakudo/rakudo@59bfa5ab37

As I understand this was the last issue on this ticket, so I'm closing it (tests already went in[^1] and were improved in later commits)

[1] Raku/roast@74445dd

@p6rt p6rt closed this as completed Oct 25, 2017
@p6rt
Copy link
Author

p6rt commented Oct 25, 2017

@zoffixznet - Status changed from 'open' to 'resolved'

@p6rt p6rt added the regression Issue did not exist previously label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Issue did not exist previously
Projects
None yet
Development

No branches or pull requests

1 participant