Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A lot of tests for $! seem to fail #6526

Closed
p6rt opened this issue Sep 16, 2017 · 7 comments
Closed

A lot of tests for $! seem to fail #6526

p6rt opened this issue Sep 16, 2017 · 7 comments
Labels
JVM Related to Rakudo-JVM

Comments

@p6rt
Copy link

p6rt commented Sep 16, 2017

Migrated from rt.perl.org#132103 (status was 'resolved')

Searchable as RT132103$

@p6rt
Copy link
Author

p6rt commented Sep 16, 2017

From @AlexDaniel

From this discussion https://irclog.perlgeek.de/perl6-dev/2017-09-16#i_15171820

3) a lot of tests for $! seem to fail. i think that happens since commit 1a4d94930c (there was a call to nqp​::setmessage removed from method throw)

rakudo/rakudo@1a4d949

@p6rt
Copy link
Author

p6rt commented Sep 16, 2017

From @usev6

Here is a simple example​:

$ ./perl6-j -e 'try { die "foo" }; say $!.perl; say $!.gist'
X​::AdHoc.new(payload => "foo")
Died
  in block <unit> at -e line 1

$ $ ./perl6-m -e 'try { die "foo" }; say $!.perl; say $!.gist'
X​::AdHoc.new(payload => "foo")
foo
  in block <unit> at -e line 1

1 similar comment
@p6rt
Copy link
Author

p6rt commented Sep 16, 2017

From @usev6

Here is a simple example​:

$ ./perl6-j -e 'try { die "foo" }; say $!.perl; say $!.gist'
X​::AdHoc.new(payload => "foo")
Died
  in block <unit> at -e line 1

$ $ ./perl6-m -e 'try { die "foo" }; say $!.perl; say $!.gist'
X​::AdHoc.new(payload => "foo")
foo
  in block <unit> at -e line 1

@p6rt
Copy link
Author

p6rt commented Sep 18, 2017

From @usev6

On Sat, 16 Sep 2017 08​:46​:00 -0700, bartolin@​gmx.de wrote​:

Here is a simple example​:

$ ./perl6-j -e 'try { die "foo" }; say $!.perl; say $!.gist'
X​::AdHoc.new(payload => "foo")
Died
in block <unit> at -e line 1

It looks like the 'Died' stems from this line​: https://github.com/perl6/nqp/blob/862cde8ed431bce5aec64130737cfeafc10e7fc9/src/vm/jvm/runtime/org/perl6/nqp/runtime/Ops.java#L5766

If I revert Raku/nqp@d228c929f8 the above example works as expected. Also, 'make test' for nqp is clean and I the failures I've seen for $! in rakudo (e.g. S02-magicals/dollar_bang.t) are gone. (I'm unable to run 'make spectest', unfortunately.)

Since I'm not completely sure, reverting nqp commit d228c929f8 is the right thing to do, I'll open a PR for that (maybe tomorrow).

@p6rt
Copy link
Author

p6rt commented Sep 18, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Sep 24, 2017

From @usev6

On Mon, 18 Sep 2017 14​:00​:02 -0700, bartolin@​gmx.de wrote​:

On Sat, 16 Sep 2017 08​:46​:00 -0700, bartolin@​gmx.de wrote​:

Here is a simple example​:

$ ./perl6-j -e 'try { die "foo" }; say $!.perl; say $!.gist'
X​::AdHoc.new(payload => "foo")
Died
in block <unit> at -e line 1

It looks like the 'Died' stems from this line​:
https://github.com/perl6/nqp/blob/862cde8ed431bce5aec64130737cfeafc10e7fc9/src/vm/jvm/runtime/org/perl6/nqp/runtime/Ops.java#L5766

If I revert Raku/nqp@d228c929f8 the above
example works as expected. Also, 'make test' for nqp is clean and I
the failures I've seen for $! in rakudo (e.g. S02-
magicals/dollar_bang.t) are gone. (I'm unable to run 'make spectest',
unfortunately.)

Since I'm not completely sure, reverting nqp commit d228c929f8 is the
right thing to do, I'll open a PR for that (maybe tomorrow).

I went ahead and did the revert with Raku/nqp@1177ace084

I'm closing this ticket as 'resolved'.

@p6rt p6rt closed this as completed Sep 24, 2017
@p6rt
Copy link
Author

p6rt commented Sep 24, 2017

@usev6 - Status changed from 'open' to 'resolved'

@p6rt p6rt added the JVM Related to Rakudo-JVM label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JVM Related to Rakudo-JVM
Projects
None yet
Development

No branches or pull requests

1 participant