Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing serialize REPR function for REPR VMHash (Rakudo::Internals::IterationSet) #6179

Closed
p6rt opened this issue Apr 6, 2017 · 8 comments
Closed
Labels
regression Issue did not exist previously testneeded

Comments

@p6rt
Copy link

p6rt commented Apr 6, 2017

Migrated from rt.perl.org#131112 (status was 'resolved')

Searchable as RT131112$

@p6rt
Copy link
Author

p6rt commented Apr 6, 2017

From @dwarring

david@​X346​:~$ perl6 -v
This is Rakudo version 2017.03-128-g87fe800 built on MoarVM version
2017.03-87-g5d73bf4
implementing Perl 6.c.
david@​X346​:~$ echo "class Tst { constant X = set < x y >; } > Tst.pm

^C
david@​X346​:~$ perl6 -v
This is Rakudo version 2017.03-128-g87fe800 built on MoarVM version
2017.03-87-g5d73bf4
implementing Perl 6.c.
david@​X346​:~$ echo "class Tst { constant X = set < x y >; }" > Tst.pm
david@​X346​:~$ perl6 -I . -M Tst
===SORRY!===
Missing serialize REPR function for REPR VMHash
(Rakudo​::Internals​::IterationSet)

@p6rt
Copy link
Author

p6rt commented Apr 6, 2017

From @dwarring

Without the guff, sorry​:

david@​X346​:~$ perl6 -v
This is Rakudo version 2017.03-128-g87fe800 built on MoarVM version
2017.03-87-g5d73bf4
implementing Perl 6.c.
david@​X346​:~$ echo "class Tst { constant X = set < x y >; }" > Tst.pm
david@​X346​:~$ perl6 -I . -M Tst
===SORRY!===
Missing serialize REPR function for REPR VMHash
(Rakudo​::Internals​::IterationSet)

On Fri, Apr 7, 2017 at 10​:04 AM, David Warring <perl6-bugs-followup@​perl.org

wrote​:

# New Ticket Created by David Warring
# Please include the string​: [perl #​131112]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=131112 >

david@​X346​:~$ perl6 -v
This is Rakudo version 2017.03-128-g87fe800 built on MoarVM version
2017.03-87-g5d73bf4
implementing Perl 6.c.
david@​X346​:~$ echo "class Tst { constant X = set < x y >; } > Tst.pm

^C
david@​X346​:~$ perl6 -v
This is Rakudo version 2017.03-128-g87fe800 built on MoarVM version
2017.03-87-g5d73bf4
implementing Perl 6.c.
david@​X346​:~$ echo "class Tst { constant X = set < x y >; }" > Tst.pm
david@​X346​:~$ perl6 -I . -M Tst
===SORRY!===
Missing serialize REPR function for REPR VMHash
(Rakudo​::Internals​::IterationSet)

@p6rt
Copy link
Author

p6rt commented Apr 7, 2017

From @lizmat

Confirmed.

Apparently we need to teach something that Rakudo​::Internals​::IterationSet is nothing but an nqp​::hash.

Or we need to revert the 5% performance gains on creating sets and set operators that having Rakudo​::Internals​::IterationSet brought.

On 7 Apr 2017, at 00​:04, David Warring (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by David Warring
# Please include the string​: [perl #​131112]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=131112 >

david@​X346​:~$ perl6 -v
This is Rakudo version 2017.03-128-g87fe800 built on MoarVM version
2017.03-87-g5d73bf4
implementing Perl 6.c.
david@​X346​:~$ echo "class Tst { constant X = set < x y >; } > Tst.pm

^C
david@​X346​:~$ perl6 -v
This is Rakudo version 2017.03-128-g87fe800 built on MoarVM version
2017.03-87-g5d73bf4
implementing Perl 6.c.
david@​X346​:~$ echo "class Tst { constant X = set < x y >; }" > Tst.pm
david@​X346​:~$ perl6 -I . -M Tst
===SORRY!===
Missing serialize REPR function for REPR VMHash
(Rakudo​::Internals​::IterationSet)

@p6rt
Copy link
Author

p6rt commented Apr 7, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Apr 7, 2017

From @dwarring

Thanks Liz,
I've added a fudged test to S11-modules/require.t

On Fri, 07 Apr 2017 01​:46​:23 -0700, elizabeth wrote​:

Confirmed.

Apparently we need to teach something that
Rakudo​::Internals​::IterationSet is nothing but an nqp​::hash.

Or we need to revert the 5% performance gains on creating sets and set
operators that having Rakudo​::Internals​::IterationSet brought.

On 7 Apr 2017, at 00​:04, David Warring (via RT) <perl6-bugs-
followup@​perl.org> wrote​:

# New Ticket Created by David Warring
# Please include the string​: [perl #​131112]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=131112 >

david@​X346​:~$ perl6 -v
This is Rakudo version 2017.03-128-g87fe800 built on MoarVM version
2017.03-87-g5d73bf4
implementing Perl 6.c.
david@​X346​:~$ echo "class Tst { constant X = set < x y >; } > Tst.pm

^C
david@​X346​:~$ perl6 -v
This is Rakudo version 2017.03-128-g87fe800 built on MoarVM version
2017.03-87-g5d73bf4
implementing Perl 6.c.
david@​X346​:~$ echo "class Tst { constant X = set < x y >; }" > Tst.pm
david@​X346​:~$ perl6 -I . -M Tst
===SORRY!===
Missing serialize REPR function for REPR VMHash
(Rakudo​::Internals​::IterationSet)

@p6rt
Copy link
Author

p6rt commented Apr 7, 2017

From @lizmat

Fixed with 7875eaf9d4ccdbf6f018 , tests needed.

On 7 Apr 2017, at 00​:04, David Warring (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by David Warring
# Please include the string​: [perl #​131112]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=131112 >

david@​X346​:~$ perl6 -v
This is Rakudo version 2017.03-128-g87fe800 built on MoarVM version
2017.03-87-g5d73bf4
implementing Perl 6.c.
david@​X346​:~$ echo "class Tst { constant X = set < x y >; } > Tst.pm

^C
david@​X346​:~$ perl6 -v
This is Rakudo version 2017.03-128-g87fe800 built on MoarVM version
2017.03-87-g5d73bf4
implementing Perl 6.c.
david@​X346​:~$ echo "class Tst { constant X = set < x y >; }" > Tst.pm
david@​X346​:~$ perl6 -I . -M Tst
===SORRY!===
Missing serialize REPR function for REPR VMHash
(Rakudo​::Internals​::IterationSet)

@p6rt
Copy link
Author

p6rt commented Apr 26, 2017

@p6rt
Copy link
Author

p6rt commented Apr 26, 2017

@zoffixznet - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Apr 26, 2017
@p6rt p6rt added regression Issue did not exist previously testneeded labels Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
regression Issue did not exist previously testneeded
Projects
None yet
Development

No branches or pull requests

1 participant