Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IO::Socket::INET - Fails to parse host:port for IPv6 addresses #5960

Closed
p6rt opened this issue Jan 1, 2017 · 7 comments
Closed

IO::Socket::INET - Fails to parse host:port for IPv6 addresses #5960

p6rt opened this issue Jan 1, 2017 · 7 comments

Comments

@p6rt
Copy link

p6rt commented Jan 1, 2017

Migrated from rt.perl.org#130474 (status was 'resolved')

Searchable as RT130474$

@p6rt
Copy link
Author

p6rt commented Jan 1, 2017

From dougljenkins@gmail.com

The IO​::Socket​::INET has code to split the port from the host name when
passed like this​:
127.0.0.1​:3000

But when using IPv6 addresses
[​::1]​:3000

The code fails because the function to split IPv6 addresses returns a Match
object instead of a Str.

@p6rt
Copy link
Author

p6rt commented Jan 2, 2017

From @zoffixznet

On Sat, 31 Dec 2016 19​:21​:51 -0800, dougljenkins@​gmail.com wrote​:

The IO​::Socket​::INET has code to split the port from the host name when
passed like this​:
127.0.0.1​:3000

But when using IPv6 addresses
[​::1]​:3000

The code fails because the function to split IPv6 addresses returns a Match
object instead of a Str.

Fixed in rakudo/rakudo@c1e0d8f

Marking TESTNEEDED.

@p6rt
Copy link
Author

p6rt commented Jan 2, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Jan 2, 2017

From @zoffixznet

On Sat, 31 Dec 2016 19​:21​:51 -0800, dougljenkins@​gmail.com wrote​:

The IO​::Socket​::INET has code to split the port from the host name when
passed like this​:
127.0.0.1​:3000

But when using IPv6 addresses
[​::1]​:3000

The code fails because the function to split IPv6 addresses returns a Match
object instead of a Str.

Tests added in Raku/roast@ea5c5c0

@p6rt
Copy link
Author

p6rt commented Jan 2, 2017

@zoffixznet - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Jan 2, 2017
@p6rt
Copy link
Author

p6rt commented Jan 2, 2017

From dougljenkins@gmail.com

rakudo/rakudo#981

Pull request to resolve issue

On Sat, Dec 31, 2016 at 7​:21 PM, perl6 via RT <perl6-bugs-followup@​perl.org>
wrote​:

Greetings,

This message has been automatically generated in response to the
creation of a trouble ticket regarding​:
"IO​::Socket​::INET - Fails to parse host​:port for IPv6 addresses",
a summary of which appears below.

There is no need to reply to this message right now. Your ticket has been
assigned an ID of [perl #​130474].

Please include the string​:

     \[perl #&#8203;130474\]

in the subject line of all future correspondence about this issue. To do
so,
you may reply to this message.

                    Thank you,
                    perl6\-bugs\-followup@&#8203;perl\.org

-------------------------------------------------------------------------
The IO​::Socket​::INET has code to split the port from the host name when
passed like this​:
127.0.0.1​:3000

But when using IPv6 addresses
[​::1]​:3000

The code fails because the function to split IPv6 addresses returns a Match
object instead of a Str.

@p6rt
Copy link
Author

p6rt commented Jan 2, 2017

From dougljenkins@gmail.com

Raku/roast#211

Added test

On Sun, Jan 1, 2017 at 6​:54 PM, Zoffix Znet via RT <
perl6-bugs-followup@​perl.org> wrote​:

On Sat, 31 Dec 2016 19​:21​:51 -0800, dougljenkins@​gmail.com wrote​:

The IO​::Socket​::INET has code to split the port from the host name when
passed like this​:
127.0.0.1​:3000

But when using IPv6 addresses
[​::1]​:3000

The code fails because the function to split IPv6 addresses returns a
Match
object instead of a Str.

Fixed in https://github.com/rakudo/rakudo/commit/
c1e0d8fbef03bfeed19818ac6a0484e572cbf77f

Marking TESTNEEDED.

@p6rt p6rt added the testneeded label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant