Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

.comb no longer works well with <( )> in Rakudo #5776

Closed
p6rt opened this issue Oct 26, 2016 · 5 comments
Closed

.comb no longer works well with <( )> in Rakudo #5776

p6rt opened this issue Oct 26, 2016 · 5 comments

Comments

@p6rt
Copy link

p6rt commented Oct 26, 2016

Migrated from rt.perl.org#129969 (status was 'resolved')

Searchable as RT129969$

@p6rt
Copy link
Author

p6rt commented Oct 26, 2016

From @masak

<masak> m​: say "abc def abc".comb(/a<(bc)>/)
<camelia> rakudo-moar 23faf6​: OUTPUT«(abc abc)␤»
<masak> I expected "(bc bc)" here
* masak submits rakudobug

Because of the <( )>, the .comb is meant to only capture the "bc" part
of the "abc" match.

<masak> oh, here's a better example for the RT ticket​:
<masak> m​: say "abc xbc".comb(/a<(bc)>/)
<camelia> rakudo-moar 23faf6​: OUTPUT«(abc)␤»
<masak> it's correct in that it matches only on the first word
<masak> it's incorrect in that it includes the "a", when the <( )>
tell it to exclude it

This used to work. I just updated nom like this

From github.com​:rakudo/rakudo
  b87a27b..23faf61 nom -> origin/nom

And I had confirmed before rebuilding that the old build does not
carry the regression.

@p6rt
Copy link
Author

p6rt commented Oct 26, 2016

From @lizmat

Fixed with ae85bac528be5fc6a1 , tests needed

On 26 Oct 2016, at 16​:32, Carl Mäsak (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by "Carl Mäsak"
# Please include the string​: [perl #​129969]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=129969 >

<masak> m​: say "abc def abc".comb(/a<(bc)>/)
<camelia> rakudo-moar 23faf6​: OUTPUT«(abc abc)␤»
<masak> I expected "(bc bc)" here
* masak submits rakudobug

Because of the <( )>, the .comb is meant to only capture the "bc" part
of the "abc" match.

<masak> oh, here's a better example for the RT ticket​:
<masak> m​: say "abc xbc".comb(/a<(bc)>/)
<camelia> rakudo-moar 23faf6​: OUTPUT«(abc)␤»
<masak> it's correct in that it matches only on the first word
<masak> it's incorrect in that it includes the "a", when the <( )>
tell it to exclude it

This used to work. I just updated nom like this

From github.com​:rakudo/rakudo
b87a27b..23faf61 nom -> origin/nom

And I had confirmed before rebuilding that the old build does not
carry the regression.

@p6rt
Copy link
Author

p6rt commented Oct 26, 2016

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Oct 29, 2016

From @usev6

On Wed Oct 26 08​:19​:28 2016, elizabeth wrote​:

Fixed with ae85bac528be5fc6a1 , tests needed

I added three tests to S05-metasyntax/angle-brackets.t with commit Raku/roast@2292a4554a

I'm closing this ticket as 'resolved'.

@p6rt
Copy link
Author

p6rt commented Oct 29, 2016

@usev6 - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant