Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version cmp broken on v6 #5380

Closed
p6rt opened this issue Jun 15, 2016 · 5 comments
Closed

Version cmp broken on v6 #5380

p6rt opened this issue Jun 15, 2016 · 5 comments

Comments

@p6rt
Copy link

p6rt commented Jun 15, 2016

Migrated from rt.perl.org#128408 (status was 'resolved')

Searchable as RT128408$

@p6rt
Copy link
Author

p6rt commented Jun 15, 2016

From zefram@fysh.org

Comparison of Version objects produces silly results where the specific
versions v6 and v6.c are involved​:

v5 cmp v2
More
v6 cmp v2
Less
v7 cmp v2
More
v6.b cmp v2
More
v6.c cmp v2
Less
v6.d cmp v2
More

This seems to be because of this inconsistency​:

(v5).parts.perl
(5,)
(v6).parts.perl
("6",)
(v6.b).parts.perl
(6, "b")
(v6.c).parts.perl
("6", "c")
(v6c).parts.perl
(6, "c")

-zefram

@p6rt
Copy link
Author

p6rt commented Jun 15, 2016

From @lizmat

Fixed with 781c6cd8f3ebc8d11 , tests needed.

On 15 Jun 2016, at 09​:41, Zefram (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by Zefram
# Please include the string​: [perl #​128408]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=128408 >

Comparison of Version objects produces silly results where the specific
versions v6 and v6.c are involved​:

v5 cmp v2
More
v6 cmp v2
Less
v7 cmp v2
More
v6.b cmp v2
More
v6.c cmp v2
Less
v6.d cmp v2
More

This seems to be because of this inconsistency​:

(v5).parts.perl
(5,)
(v6).parts.perl
("6",)
(v6.b).parts.perl
(6, "b")
(v6.c).parts.perl
("6", "c")
(v6c).parts.perl
(6, "c")

-zefram

@p6rt
Copy link
Author

p6rt commented Jun 15, 2016

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Jul 9, 2016

From @zoffixznet

Tests added​: Raku/roast@1c4a4f726d

@p6rt
Copy link
Author

p6rt commented Jul 9, 2016

@zoffixznet - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant