Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing tests for type smileys #5277

Closed
p6rt opened this issue Apr 30, 2016 · 4 comments
Closed

Failing tests for type smileys #5277

p6rt opened this issue Apr 30, 2016 · 4 comments
Labels
JVM Related to Rakudo-JVM

Comments

@p6rt
Copy link

p6rt commented Apr 30, 2016

Migrated from rt.perl.org#128031 (status was 'resolved')

Searchable as RT128031$

@p6rt
Copy link
Author

p6rt commented Apr 30, 2016

From @usev6

Since rakudo commit fe2be65806 there are 5 failing test on rakudo-j in S04-declarations/smiley.t and S12-attributes/smiley.t, each. (I'll fudge them as 'todo').

As it looks said rakudo commit shows a formerly hidden difference between rakudo-m and rakudo-j (or nqp-m and nqp-j). I checked with a Rakudo version 2015.12-60-g37e998d and got exactly the same results for the above evaluations.

$ perl6-j -e 'say { my Int​:U $a }().^name'
?​:?
$ perl6-m -e 'say { my Int​:U $a }().^name'
Int​:U

The reason for this seems to be a different behavior of nqp​::typeparameterized (which is called via src/Perl6/Metamodel/DefiniteHOW.nqp)​:

$ perl6-j -e 'use nqp; my Int​:U $foo; say nqp​::isnull(nqp​::typeparameterized($foo))'
1
$ perl6-m -e 'use nqp; my Int​:U $foo; say nqp​::isnull(nqp​::typeparameterized($foo))'
0

If I call nqp​::typeparameterized with Int​:U directly, JVM and Moar agree​:

$ perl6-j -e 'use nqp; say nqp​::isnull(nqp​::typeparameterized(Int​:U))'
0
perl6-m -e 'use nqp; say nqp​::isnull(nqp​::typeparameterized(Int​:U))'
0

@p6rt
Copy link
Author

p6rt commented Nov 2, 2017

From @usev6

The tests in question are passing again.

I'm closing this ticket as resolved.

1 similar comment
@p6rt
Copy link
Author

p6rt commented Nov 2, 2017

From @usev6

The tests in question are passing again.

I'm closing this ticket as resolved.

@p6rt
Copy link
Author

p6rt commented Nov 2, 2017

@usev6 - Status changed from 'new' to 'resolved'

@p6rt p6rt closed this as completed Nov 2, 2017
@p6rt p6rt added the JVM Related to Rakudo-JVM label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
JVM Related to Rakudo-JVM
Projects
None yet
Development

No branches or pull requests

1 participant