Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TR/ / / is not implemented #5210

Closed
p6rt opened this issue Apr 3, 2016 · 7 comments
Closed

TR/ / / is not implemented #5210

p6rt opened this issue Apr 3, 2016 · 7 comments
Labels
RFC Request For Comments

Comments

@p6rt
Copy link

p6rt commented Apr 3, 2016

Migrated from rt.perl.org#127824 (status was 'resolved')

Searchable as RT127824$

@p6rt
Copy link
Author

p6rt commented Apr 3, 2016

From @AlexDaniel

Although S/ / / is not documented (Raku/doc#437), it is still relatively well-known and is commonly used.

However, I was surprised to see that TR/ / / is not implemented (that is, non-mutating transliteration). This looks like an inconsistency to me. If we have S/ / /, then why not have TR/ / /?

So I am creating this ticket to point out this inconsistency.

One might say that this ticket should be created in the spec repo, but, after all, S/ / / is not present in the specs, so that would be a bit inappropriate.

@p6rt
Copy link
Author

p6rt commented Jul 10, 2016

From @zoffixznet

+1 for adding

@p6rt
Copy link
Author

p6rt commented Oct 8, 2017

From @AlexDaniel

FWIW to add it one will need to hack this part​: https://github.com/rakudo/rakudo/blob/de0533c4d4c9f425ce22432a8e4555ded27cba91/src/Perl6/Actions.nqp#L7999-L8055

See the implementation for S/// for more inspiration​: https://github.com/rakudo/rakudo/blob/de0533c4d4c9f425ce22432a8e4555ded27cba91/src/Perl6/Actions.nqp#L8057-L8234

Basically you'd be checking for 「 $ < sym > eq ' TR '」, which of course has to be first added here as 「<sym=[tr|TR]>」 https://github.com/rakudo/rakudo/blob/nom/src/Perl6/Grammar.nqp#L3853

On 2016-07-09 21​:07​:42, cpan@​zoffix.com wrote​:

+1 for adding

@p6rt
Copy link
Author

p6rt commented Oct 8, 2017

From @AlexDaniel

Oops. Last link​: https://github.com/rakudo/rakudo/blob/de0533c4d4c9f425ce22432a8e4555ded27cba91/src/Perl6/Grammar.nqp#L3853

On 2017-10-07 17​:35​:58, alex.jakimenko@​gmail.com wrote​:

FWIW to add it one will need to hack this part​:
https://github.com/rakudo/rakudo/blob/de0533c4d4c9f425ce22432a8e4555ded27cba91/src/Perl6/Actions.nqp#L7999-
L8055

See the implementation for S/// for more inspiration​:
https://github.com/rakudo/rakudo/blob/de0533c4d4c9f425ce22432a8e4555ded27cba91/src/Perl6/Actions.nqp#L8057-
L8234

Basically you'd be checking for 「$<sym> eq 'TR'」, which of course has
to be
first added here as 「<sym=[tr|TR]>」
https://github.com/rakudo/rakudo/blob/nom/src/Perl6/Grammar.nqp#L3853

On 2016-07-09 21​:07​:42, cpan@​zoffix.com wrote​:

+1 for adding

@p6rt
Copy link
Author

p6rt commented Dec 13, 2017

From @zoffixznet

On Sat, 07 Oct 2017 17​:36​:28 -0700, alex.jakimenko@​gmail.com wrote​:

Oops. Last link​:
https://github.com/rakudo/rakudo/blob/de0533c4d4c9f425ce22432a8e4555ded27cba91/src/Perl6/Grammar.nqp#L3853

On 2017-10-07 17​:35​:58, alex.jakimenko@​gmail.com wrote​:

FWIW to add it one will need to hack this part​:

https://github.com/rakudo/rakudo/blob/de0533c4d4c9f425ce22432a8e4555ded27cba91/src/Perl6/Actions.nqp#L7999-

L8055

See the implementation for S/// for more inspiration​:

https://github.com/rakudo/rakudo/blob/de0533c4d4c9f425ce22432a8e4555ded27cba91/src/Perl6/Actions.nqp#L8057-

L8234

Basically you'd be checking for 「$<sym> eq 'TR'」, which of course has
to be
first added here as 「<sym=[tr|TR]>」
https://github.com/rakudo/rakudo/blob/nom/src/Perl6/Grammar.nqp#L3853

On 2016-07-09 21​:07​:42, cpan@​zoffix.com wrote​:

+1 for adding

Thank you for the report. This is now fixed.

Fix​: rakudo/rakudo@f69586240975f67
Test​: Raku/roast@27cc9417fc220409b

@p6rt
Copy link
Author

p6rt commented Dec 13, 2017

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Dec 13, 2017

@zoffixznet - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Dec 13, 2017
@p6rt p6rt added the RFC Request For Comments label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
RFC Request For Comments
Projects
None yet
Development

No branches or pull requests

1 participant