Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

「dir」 dies if weird unicode sequences are encountered (dir;) #5165

Closed
p6rt opened this issue Mar 7, 2016 · 9 comments
Closed

「dir」 dies if weird unicode sequences are encountered (dir;) #5165

p6rt opened this issue Mar 7, 2016 · 9 comments

Comments

@p6rt
Copy link

p6rt commented Mar 7, 2016

Migrated from rt.perl.org#127671 (status was 'resolved')

Searchable as RT127671$

@p6rt
Copy link
Author

p6rt commented Mar 7, 2016

From @AlexDaniel

One-liner to reproduce the bug (preferably run it in an empty directory)​:

perl -E 'mkdir pack "h*", "60ba"'; perl6 -e 'dir; say �hello�'

Result​:
Malformed UTF-8 at line 1 col 2
  in block <unit> at -e line 1

It should not die. Such file (or directory) exists and all operations with it should work.

I've reproduced that on linux with ext4 filesystem. ugexe confirmed it.

It was reported that this bug is not reproducible with that one-liner on OS X​:
<ParsonsNose> AlexDaniel I get no errors. it just makes a directory called ^F%AB/ ..

Windows gives no error, and doesn't appear to make the directory

See also this​: http://irclog.perlgeek.de/perl6/2016-03-07#i_12150444

@p6rt
Copy link
Author

p6rt commented Mar 13, 2016

From @FROGGS

Patch​: MoarVM/MoarVM@79dce1101b

I hesitate to put a test for this in...
Closing as resolved anyway.

1 similar comment
@p6rt
Copy link
Author

p6rt commented Mar 13, 2016

From @FROGGS

Patch​: MoarVM/MoarVM@79dce1101b

I hesitate to put a test for this in...
Closing as resolved anyway.

@p6rt
Copy link
Author

p6rt commented Mar 13, 2016

@FROGGS - Status changed from 'new' to 'resolved'

@p6rt
Copy link
Author

p6rt commented Dec 22, 2016

From @AlexDaniel

Why?

On 2016-03-13 10​:53​:55, FROGGS.de wrote​:

Patch​: MoarVM/MoarVM@79dce1101b

I hesitate to put a test for this in...
Closing as resolved anyway.

@p6rt
Copy link
Author

p6rt commented Dec 22, 2016

@AlexDaniel - Status changed from 'resolved' to 'open'

@p6rt
Copy link
Author

p6rt commented Mar 2, 2017

From @zoffixznet

Explanation and ideas on IRC​: https://irclog.perlgeek.de/moarvm/2017-03-02#i_14193748

- It's risky to be part of normal tests, lest the user won't be able to delete these weird dirs
- Setup `make risky-test` target that would run these risky tests only when user asks (knowing they're on a system that can be trashed freely)

@p6rt
Copy link
Author

p6rt commented Feb 2, 2018

From @AlexDaniel

Test added in Raku/roast@a7590d6

Note that the test *does create* files with weird names, but that's totally OK in /tmp I think.

On 2017-03-02 07​:06​:54, cpan@​zoffix.com wrote​:

Explanation and ideas on IRC​: https://irclog.perlgeek.de/moarvm/2017-
03-02#i_14193748

- It's risky to be part of normal tests, lest the user won't be able
to delete these weird dirs
- Setup `make risky-test` target that would run these risky tests only
when user asks (knowing they're on a system that can be trashed
freely)

@p6rt
Copy link
Author

p6rt commented Feb 2, 2018

@AlexDaniel - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant