Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Supply.categorize.done doesn't distribute .done to sub-supplies #3655

Closed
p6rt opened this issue Jan 25, 2015 · 5 comments
Closed

Supply.categorize.done doesn't distribute .done to sub-supplies #3655

p6rt opened this issue Jan 25, 2015 · 5 comments

Comments

@p6rt
Copy link

p6rt commented Jan 25, 2015

Migrated from rt.perl.org#123674 (status was 'resolved')

Searchable as RT123674$

@p6rt
Copy link
Author

p6rt commented Jan 25, 2015

From @Mouq

Tapping Supply.categorize(&key-generator) results in a key => Supply pair.
However, when the original supply is .done, the Supplies generated by the
.categorize are never .done.

The output of golf.p6 (attached) should end with each of the value supplies
having .done called on them, producing "Supply for key 1 done\nSupply for
key 2 done\n…"

From IRC​:

<moritz> Mouq​: should it call .done of the sub-supplies before or after the
outer?
<Mouq> I'd say after, since that seems to be the case for other
supply-generating methods, but I don't really know. Although if you're
relying on the order that .done is called on Supplies, you're probably
doing something wrong :P

@p6rt
Copy link
Author

p6rt commented Jan 25, 2015

From @Mouq

golf.p6

@p6rt
Copy link
Author

p6rt commented Jan 26, 2015

From @moritz

On Sun Jan 25 14​:24​:00 2015, Mouq wrote​:

Tapping Supply.categorize(&key-generator) results in a key => Supply pair.
However, when the original supply is .done, the Supplies generated by the
.categorize are never .done.

fixed with this rakudo commit​:

commit 94501a6fcaf0102f48ce6f55907b2233b3ea959d
Author​: Moritz Lenz <moritz@​faui2k3.org>
Date​: 2015-01-25 22​:34​:18 +0000

  Supply.categorize​: distribute .done to sub-supplies

src/core/SupplyOperations.pm | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)

And tested with this roast commit​:

commit 0821592f8606ccff3f4a343715fc4d35d46fe0b8
Author​: Moritz Lenz <moritz@​faui2k3.org>
Date​: 2015-01-26 06​:18​:46 +0000

  RT #​123674​: Test that sub-supplies from categorize get .done

S17-supply/categorize.t | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)

Cheers,
Moritz

@p6rt
Copy link
Author

p6rt commented Jan 26, 2015

The RT System itself - Status changed from 'new' to 'open'

@p6rt p6rt closed this as completed Jan 26, 2015
@p6rt
Copy link
Author

p6rt commented Jan 26, 2015

@moritz - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant