Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macosx file access time failures #3469

Closed
p6rt opened this issue Aug 3, 2014 · 5 comments
Closed

macosx file access time failures #3469

p6rt opened this issue Aug 3, 2014 · 5 comments

Comments

@p6rt
Copy link

p6rt commented Aug 3, 2014

Migrated from rt.perl.org#122467 (status was 'resolved')

Searchable as RT122467$

@p6rt
Copy link
Author

p6rt commented Aug 3, 2014

From @coke

The following two tests in S16-filehandles/filestat.t currently fail on OS X​:

ok ($original1_accessed == $tmpfile1.IO.accessed), 'IO.accessed should
NOT be updated when file is opened for writing';

  ok ($original1_accessed == $tmpfile1.IO.accessed), 'IO.accessed
should NOT be updated when file is opened for reading';

Neither of these assertions hold true on the mac. Should we be
declaring (and testing) they are true on every OS?

--
Will "Coke" Coleda

@p6rt
Copy link
Author

p6rt commented Aug 4, 2014

From @lizmat

On 04 Aug 2014, at 01​:30, Will Coleda (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by Will Coleda
# Please include the string​: [perl #​122467]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=122467 >

The following two tests in S16-filehandles/filestat.t currently fail on OS X​:

ok ($original1_accessed == $tmpfile1.IO.accessed), 'IO.accessed should
NOT be updated when file is opened for writing';

ok \($original1\_accessed == $tmpfile1\.IO\.accessed\), 'IO\.accessed

should NOT be updated when file is opened for reading';

Neither of these assertions hold true on the mac. Should we be
declaring (and testing) they are true on every OS?

These tests now get an unexpected TODO pass on my system :-(

FWIW, this is a property (noatime) of the file system on which the check is being done. There is no way we can assume this is always (not) set. So I think these tests are bogus. I would propose we remove them.

Liz

@p6rt
Copy link
Author

p6rt commented Aug 4, 2014

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Aug 4, 2014

From @coke

On Mon Aug 04 02​:01​:46 2014, elizabeth wrote​:

On 04 Aug 2014, at 01​:30, Will Coleda (via RT) <perl6-bugs-
followup@​perl.org> wrote​:

# New Ticket Created by Will Coleda
# Please include the string​: [perl #​122467]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=122467 >

The following two tests in S16-filehandles/filestat.t currently fail
on OS X​:

ok ($original1_accessed == $tmpfile1.IO.accessed), 'IO.accessed
should
NOT be updated when file is opened for writing';

ok ($original1_accessed == $tmpfile1.IO.accessed), 'IO.accessed
should NOT be updated when file is opened for reading';

Neither of these assertions hold true on the mac. Should we be
declaring (and testing) they are true on every OS?

These tests now get an unexpected TODO pass on my system :-(

FWIW, this is a property (noatime) of the file system on which the
check is being done. There is no way we can assume this is always
(not) set. So I think these tests are bogus. I would propose we
remove them.

Liz

…And you did. Your plan works for me. Closing ticket.

--
Will "Coke" Coleda

@p6rt
Copy link
Author

p6rt commented Aug 4, 2014

@coke - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Aug 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant