Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BagHash.grab doesn't properly update .elems #3261

Closed
p6rt opened this issue Oct 29, 2013 · 9 comments
Closed

BagHash.grab doesn't properly update .elems #3261

p6rt opened this issue Oct 29, 2013 · 9 comments
Labels

Comments

@p6rt
Copy link

p6rt commented Oct 29, 2013

Migrated from rt.perl.org#120407 (status was 'resolved')

Searchable as RT120407$

@p6rt
Copy link
Author

p6rt commented Oct 29, 2013

From @coke

S02-types/baghash.t has a test that creates a BagHash, .grab's some items from it. The final tests in the block are​:

  is $b.total, 0, '.grab *should* change BagHash';
  is $b.elems, 0, '.grab *should* change BagHash';

The first test passes, but the second fails - .elems returns 2 - there were 3 elements to start with, and 2 .grabs - looks like the first one is correctly updating .elems, but future ones are not.

--
Will "Coke" Coleda

@p6rt
Copy link
Author

p6rt commented Oct 29, 2013

From @lizmat

On 29 Oct 2013, at 13​:34, Will Coleda (via RT) <perl6-bugs-followup@​perl.org> wrote​:

# New Ticket Created by Will Coleda
# Please include the string​: [perl #​120407]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=120407 >

S02-types/baghash.t has a test that creates a BagHash, .grab's some items from it. The final tests in the block are​:

is $b.total, 0, '.grab *should* change BagHash';
is $b.elems, 0, '.grab *should* change BagHash';

The first test passes, but the second fails - .elems returns 2 - there were 3 elements to start with, and 2 .grabs - looks like the first one is correctly updating .elems, but future ones are not.

Is this on the JVM or on Parrot? I don't see the failure on Parrot.

Liz

@p6rt
Copy link
Author

p6rt commented Oct 29, 2013

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Oct 29, 2013

From @coke

On Tue Oct 29 07​:01​:58 2013, elizabeth wrote​:

On 29 Oct 2013, at 13​:34, Will Coleda (via RT) <perl6-bugs-
followup@​perl.org> wrote​:

# New Ticket Created by Will Coleda
# Please include the string​: [perl #​120407]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=120407 >

S02-types/baghash.t has a test that creates a BagHash, .grab's some
items from it. The final tests in the block are​:

is $b.total, 0, '.grab *should* change BagHash';
is $b.elems, 0, '.grab *should* change BagHash';

The first test passes, but the second fails - .elems returns 2 -
there were 3 elements to start with, and 2 .grabs - looks like the
first one is correctly updating .elems, but future ones are not.

Is this on the JVM or on Parrot? I don't see the failure on Parrot.

Liz

JVM - Tried to indicate this via the [JVM] in the subject.

--
Will "Coke" Coleda

1 similar comment
@p6rt
Copy link
Author

p6rt commented Oct 29, 2013

From @coke

On Tue Oct 29 07​:01​:58 2013, elizabeth wrote​:

On 29 Oct 2013, at 13​:34, Will Coleda (via RT) <perl6-bugs-
followup@​perl.org> wrote​:

# New Ticket Created by Will Coleda
# Please include the string​: [perl #​120407]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=120407 >

S02-types/baghash.t has a test that creates a BagHash, .grab's some
items from it. The final tests in the block are​:

is $b.total, 0, '.grab *should* change BagHash';
is $b.elems, 0, '.grab *should* change BagHash';

The first test passes, but the second fails - .elems returns 2 -
there were 3 elements to start with, and 2 .grabs - looks like the
first one is correctly updating .elems, but future ones are not.

Is this on the JVM or on Parrot? I don't see the failure on Parrot.

Liz

JVM - Tried to indicate this via the [JVM] in the subject.

--
Will "Coke" Coleda

@p6rt
Copy link
Author

p6rt commented Oct 29, 2013

From @lizmat

On 29 Oct 2013, at 17​:43, Will Coleda via RT <bugs-comment@​bugs6.perl.org> wrote​:

On Tue Oct 29 07​:01​:58 2013, elizabeth wrote​:

On 29 Oct 2013, at 13​:34, Will Coleda (via RT) <perl6-bugs-
followup@​perl.org> wrote​:

# New Ticket Created by Will Coleda
# Please include the string​: [perl #​120407]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl6/Ticket/Display.html?id=120407 >

S02-types/baghash.t has a test that creates a BagHash, .grab's some
items from it. The final tests in the block are​:

is $b.total, 0, '.grab *should* change BagHash';
is $b.elems, 0, '.grab *should* change BagHash';

The first test passes, but the second fails - .elems returns 2 -
there were 3 elements to start with, and 2 .grabs - looks like the
first one is correctly updating .elems, but future ones are not.

Is this on the JVM or on Parrot? I don't see the failure on Parrot.

Liz

JVM - Tried to indicate this via the [JVM] in the subject.

Note to self​: pay attention to Subject lines. :-)

Liz

@p6rt
Copy link
Author

p6rt commented Oct 21, 2014

From @usev6

The tests in question are passing again (and they are unfudged). AFAICT the relevant commits to rakudo were​:

* rakudo/rakudo@7ff58f0

* rakudo/rakudo@3687508

I'm closing this ticket.

1 similar comment
@p6rt
Copy link
Author

p6rt commented Oct 21, 2014

From @usev6

The tests in question are passing again (and they are unfudged). AFAICT the relevant commits to rakudo were​:

* rakudo/rakudo@7ff58f0

* rakudo/rakudo@3687508

I'm closing this ticket.

@p6rt p6rt closed this as completed Oct 21, 2014
@p6rt
Copy link
Author

p6rt commented Oct 21, 2014

@usev6 - Status changed from 'open' to 'resolved'

@p6rt p6rt added the jvm/moar label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant