New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lddlflags (and ccdlflags) overridden on GNU/kFreeBSD #12498
Comments
From @ntyniThis is a bug report for perl from Niko Tyni <ntyni@debian.org>, hints/gnukfreebsd.sh currently overrides any lddflags (or ccdlflags) Further, digging into the history, it looks like the The attached proposed patch removes the divergences from Linux hints This is also <http://bugs.debian.org/689713>. Flags: Site configuration information for perl 5.17.5: Configured by niko at Wed Oct 17 15:17:11 EEST 2012. Summary of my perl5 (revision 5 version 17 subversion 5) configuration: Locally applied patches: @INC for perl 5.17.5: Environment for perl 5.17.5: |
From @ntyni0001-Don-t-overwrite-Config-lddlflags-or-ccdlflags-on-GNU.patchFrom d7993ad77af99331542d3e35f0e880d9e31c7bbb Mon Sep 17 00:00:00 2001
From: Niko Tyni <ntyni@debian.org>
Date: Tue, 16 Oct 2012 23:51:02 +0300
Subject: [PATCH] Don't overwrite $Config{lddlflags} or ccdlflags on
GNU/kFreeBSD
Blindly overwriting lddflags or ccdlflags overrides any additional
values given as Configure arguments.
Further, digging into the history, it looks like the
comment about Configure setting these "where $osname = linux"
was outdated even when it was applied in commit
46c947e8b9def6de34ac831834a3c290ab266515 (Perforce change 24017)
as the earlier commit
fb2e1bc0638d5a5d7ac552a79a71a996a5d604cc (Perforce change 23909)
added gnu* matches to the relevant Configure parts.
Therefore removing the divergences from Linux hints as unnecessary.
---
hints/gnukfreebsd.sh | 3 ---
1 file changed, 3 deletions(-)
diff --git a/hints/gnukfreebsd.sh b/hints/gnukfreebsd.sh
index 1225f69..435afe7 100644
--- a/hints/gnukfreebsd.sh
+++ b/hints/gnukfreebsd.sh
@@ -5,6 +5,3 @@
. ./hints/linux.sh
-# Configure sets these where $osname = linux
-ccdlflags='-Wl,-E'
-lddlflags='-shared'
--
1.7.10.4
|
From @LeontOn Wed, Oct 17, 2012 at 4:33 PM, Niko Tyni <perlbug-followup@perl.org> wrote:
The patch looks sensible to me. That said, the fact that you need to override lddlflags suggests I wish lddlflags was as simple as setting it to '-shared' and ldflags Leon |
The RT System itself - Status changed from 'new' to 'open' |
From @TuxOn Wed, 17 Oct 2012 18:32:34 +0200, Leon Timmermans <fawaka@gmail.com>
/me enters the swamp ... It is a squishy gray line of what *can* and what *cannot* we e.g. there are some native compilers that allow $CC to be native and
$ ld -shared We're not all living in a GNU world
-- |
From @doughera88On Wed, 17 Oct 2012, Niko Tyni wrote:
Yes, this looks sensible. I'll take care of it. I'll also remove the same -- |
From @doughera88On Wed, 17 Oct 2012, Andy Dougherty wrote:
Thanks, applied as commit 7dc6565 -- |
@doughera88 - Status changed from 'open' to 'resolved' |
From @LeontOn Wed, Oct 17, 2012 at 7:17 PM, H.Merijn Brand <h.m.brand@xs4all.nl> wrote:
Yeah, I realize this is messy, but I do think we can make it slightly better.
I know, I meant it in the sense that I wish it would have whatever Leon |
Migrated from rt.perl.org#115324 (status was 'resolved')
Searchable as RT115324$
The text was updated successfully, but these errors were encountered: