New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl v5.17.3-133-g3da9985 breaks DOY/Moose-2.0603.tar.gz #12358
Comments
From @andkgit bisect commit 3da9985 Croak for \local %{\%foo} also affected SPROUT/CSS-DOM-0.14.tar.gz Sample fail reports not yet available at cpantesters perl -V Summary of my perl5 (revision 5 version 17 subversion 4) configuration: Characteristics of this binary (from libperl): -- |
From @cpansproutOn Mon Aug 27 21:49:07 2012, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
It should be an error, because the local does nothing in that case. It $list[0] = []; Localising the element, not its dereferencement, is the correct thing to do: $list[0] = []; That means CSS::DOM’s test suite is not good enough. I’m looking into Moose now. -- Father Chrysostomos |
The RT System itself - Status changed from 'new' to 'open' |
From @cpansproutOn Mon Aug 27 21:49:07 2012, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
OK, I have two patches for Moose. The first one removes the local, making it behave in bleadperl exactly The second patch keeps the local, changing things to what was probably Choose wisely. -- Father Chrysostomos |
From @cpansproutInline Patchdiff -rup Moose-2.0603-qRHQsv-orig/lib/Moose/Exporter.pm Moose-2.0603-qRHQsv/lib/Moose/Exporter.pm
--- Moose-2.0603-qRHQsv-orig/lib/Moose/Exporter.pm 2012-06-28 09:18:50.000000000 -0700
+++ Moose-2.0603-qRHQsv/lib/Moose/Exporter.pm 2012-08-28 00:23:48.000000000 -0700
@@ -140,13 +140,13 @@ sub _make_exporter {
}
{
- my $seen = {};
+ our %_seen;
sub _follow_also {
my $class = shift;
my $exporting_package = shift;
- local %$seen = ( $exporting_package => 1 );
+ local %_seen = ( $exporting_package => 1 );
return uniq( _follow_also_real($exporting_package) );
}
@@ -171,9 +171,9 @@ sub _make_exporter {
for my $package (@also) {
die
"Circular reference in 'also' parameter to Moose::Exporter between $exporting_package and $package"
- if $seen->{$package};
+ if $_seen{$package};
- $seen->{$package} = 1;
+ $_seen{$package} = 1;
}
return map { $_, _follow_also_real($_) } @also; |
From @cpansproutInline Patchdiff -rup Moose-2.0603-qRHQsv-orig/lib/Moose/Exporter.pm Moose-2.0603-qRHQsv/lib/Moose/Exporter.pm
--- Moose-2.0603-qRHQsv-orig/lib/Moose/Exporter.pm 2012-06-28 09:18:50.000000000 -0700
+++ Moose-2.0603-qRHQsv/lib/Moose/Exporter.pm 2012-08-28 00:17:15.000000000 -0700
@@ -146,7 +146,7 @@ sub _make_exporter {
my $class = shift;
my $exporting_package = shift;
- local %$seen = ( $exporting_package => 1 );
+ %$seen = ( $exporting_package => 1 );
return uniq( _follow_also_real($exporting_package) );
} |
From bug-Moose@rt.cpan.org<URL: https://rt.cpan.org/Ticket/Display.html?id=79257 > On Tue Aug 28 03:32:02 2012, perlbug-followup@perl.org wrote:
RT switched the order of the patches. It’s the other way round. |
From bug-Moose@rt.cpan.org<URL: https://rt.cpan.org/Ticket/Display.html?id=79257 > Fixed in 2.0604. |
From @jkeenanOn Wed Sep 19 14:23:25 2012, bug-Moose@rt.cpan.org wrote:
Does that make this rt.perl.org ticket closable as well? Thank you very much. |
From @cpansproutOn Wed Sep 19 17:50:42 2012, jkeenan wrote:
Yes. I’ll take care of CSS::DOM. -- Father Chrysostomos |
@cpansprout - Status changed from 'open' to 'resolved' |
From @andk"James E Keenan via RT" <perlbug-followup@perl.org> writes:
From my POV, yes. -- |
Migrated from rt.perl.org#114628 (status was 'resolved')
Searchable as RT114628$
The text was updated successfully, but these errors were encountered: