Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cygwin make install fails copying some documentation #2815

Closed
p6rt opened this issue Jul 4, 2012 · 5 comments
Closed

cygwin make install fails copying some documentation #2815

p6rt opened this issue Jul 4, 2012 · 5 comments
Labels

Comments

@p6rt
Copy link

p6rt commented Jul 4, 2012

Migrated from rt.perl.org#113984 (status was 'resolved')

Searchable as RT113984$

@p6rt
Copy link
Author

p6rt commented Jul 4, 2012

From @ronaldxs

In cygwin the CP make variable is defined as /bin/cp rather than
"$(PERL) -MExtUtils​::Command -e cp" as in other environments. The
rakudo Configure.pl seems to ultimately set this variable based on
config/init/hints/cygwin.pm in the parrot build tree and that
hints/cygwin.pm file has a comment noting that ExtUtils​::Command has a
bug with a ticket concerning the failure to set the executable bit on
cygwin.

The reason setting the make CP variable to /bin/cp breaks "make
install" for rakudo is that there are commands to copy some
documentation files, included below, and, since the $(DOCS) variable
indirectly refers to a "docs/announce" directory, the *nix /bin/cp
command tries to copy that directory and returns a 1 error code after
printing a warning. The ExtUtils​::Command cp fails silently instead.

...
# the docs/* below refers to docs/announce which is a directory and
breaks install
DOCS = README CREDITS LICENSE docs/*
...
  $(CP) $(DOCS) $(DESTDIR)$(DOCDIR)/rakudo
  $(CP) $(DOCS)/announce
$(DESTDIR)$(DOCDIR)/rakudo/announce

This bug also breaks "make install" for Rakudo Star.

Ron

@p6rt
Copy link
Author

p6rt commented Jul 4, 2012

From @pmichaud

The reason setting the make CP variable to /bin/cp breaks "make
install" for rakudo is that there are commands to copy some
documentation files, included below, and, since the $(DOCS) variable
indirectly refers to a "docs/announce" directory, the *nix /bin/cp
command tries to copy that directory and returns a 1 error code after
printing a warning. The ExtUtils​::Command cp fails silently instead.

I think I've now fixed this in Rakudo commit 61a3add; the cp command
will still give a warning (and copy the files) but no longer aborts the
make. If you can test/verify that this now works (i.e., doesn't fail),
then I can close this ticket.

Thanks!

Pm

@p6rt
Copy link
Author

p6rt commented Jul 4, 2012

The RT System itself - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Jul 4, 2012

From @pmichaud

Now fixed in ea8b97e.

Thanks!

Pm

@p6rt
Copy link
Author

p6rt commented Jul 4, 2012

@pmichaud - Status changed from 'open' to 'resolved'

@p6rt p6rt closed this as completed Jul 4, 2012
@p6rt p6rt added the Bug label Jan 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant