Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Range's min/max don't take a comparator #2570

Closed
p6rt opened this issue Dec 1, 2011 · 8 comments
Closed

Range's min/max don't take a comparator #2570

p6rt opened this issue Dec 1, 2011 · 8 comments

Comments

@p6rt
Copy link

p6rt commented Dec 1, 2011

Migrated from rt.perl.org#105118 (status was 'rejected')

Searchable as RT105118$

@p6rt
Copy link
Author

p6rt commented Dec 1, 2011

From @coke

09​:55 < [Coke]> nom​: say (-10..10).min​: { abs $^a &lt;=&gt; abs $^b }09​:55
<+p6eval> nom 17a235​: OUTPUT«Too many positional parameters passed;
got 2                but expected 1␤  in method min at
src/gen/CORE.setting​:1232␤                in block <anon> at
/tmp/FOX6arzPat​:1␤  in <anon> at                /tmp/FOX6arzPat​:1␤»

but

09​:56 < [Coke]> nom​: say (1,4,-2).min​: { abs $^a &lt;=&gt; abs $^b }09​:56
<+p6eval> nom 17a235​: OUTPUT«1␤»
This is causing failures in S32-list/minmax.t
--
Will "Coke" Coleda

@p6rt
Copy link
Author

p6rt commented Dec 1, 2011

From @coke

On Thu Dec 01 06​:57​:56 2011, coke wrote​:

09​:55 < [Coke]> nom​: say (-10..10).min​: { abs $^a &lt;=&gt; abs $^b }09​:55
<+p6eval> nom 17a235​: OUTPUT«Too many positional parameters passed;
got 2                but expected 1␤  in method min at
src/gen/CORE.setting​:1232␤                in block <anon> at
/tmp/FOX6arzPat​:1␤  in <anon> at                /tmp/FOX6arzPat​:1␤»

but

09​:56 < [Coke]> nom​: say (1,4,-2).min​: { abs $^a &lt;=&gt; abs $^b }09​:56
<+p6eval> nom 17a235​: OUTPUT«1␤»
This is causing failures in S32-list/minmax.t

Similar issues with Range's "max" also.

--
Will "Coke" Coleda

1 similar comment
@p6rt
Copy link
Author

p6rt commented Dec 1, 2011

From @coke

On Thu Dec 01 06​:57​:56 2011, coke wrote​:

09​:55 < [Coke]> nom​: say (-10..10).min​: { abs $^a &lt;=&gt; abs $^b }09​:55
<+p6eval> nom 17a235​: OUTPUT«Too many positional parameters passed;
got 2                but expected 1␤  in method min at
src/gen/CORE.setting​:1232␤                in block <anon> at
/tmp/FOX6arzPat​:1␤  in <anon> at                /tmp/FOX6arzPat​:1␤»

but

09​:56 < [Coke]> nom​: say (1,4,-2).min​: { abs $^a &lt;=&gt; abs $^b }09​:56
<+p6eval> nom 17a235​: OUTPUT«1␤»
This is causing failures in S32-list/minmax.t

Similar issues with Range's "max" also.

--
Will "Coke" Coleda

@p6rt
Copy link
Author

p6rt commented Dec 1, 2011

@coke - Status changed from 'new' to 'open'

@p6rt
Copy link
Author

p6rt commented Dec 27, 2011

From kris@shannon.id.au

Range does not do Positional, so it's min is separate from

our multi method min( @​values​: *&by )

and should not take any arguments.

@p6rt
Copy link
Author

p6rt commented Dec 27, 2011

From kris@shannon.id.au

This looks like a DUP of #​63716

@p6rt
Copy link
Author

p6rt commented Apr 5, 2013

From @coke

On Tue Dec 27 05​:28​:45 2011, Kris.Shannon wrote​:

This looks like a DUP of #​63716

From that ticket​:

S03​:2885 describes slightly different semantics for
.min and .max in Ranges, and doesn't mention an Ordering parameter at all.

Rejecting ticket.

--
Will "Coke" Coleda

@p6rt
Copy link
Author

p6rt commented Apr 5, 2013

@coke - Status changed from 'open' to 'rejected'

@p6rt p6rt closed this as completed Apr 5, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant