Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t/re/re.t timeout too short for sh4 #11409

Closed
p5pRT opened this issue Jun 4, 2011 · 6 comments
Closed

t/re/re.t timeout too short for sh4 #11409

p5pRT opened this issue Jun 4, 2011 · 6 comments

Comments

@p5pRT
Copy link

p5pRT commented Jun 4, 2011

Migrated from rt.perl.org#92226 (status was 'resolved')

Searchable as RT92226$

@p5pRT
Copy link
Author

p5pRT commented Jun 4, 2011

From @jmdh

This describes an issue originally reported by Nobuhiro Iwamatsu at
<http​://bugs.debian.org/cgi-bin/bugreport.cgi?bug=626125>.

On the sh4 architecture, the 2 second timeout in t/re/re.t was too
short. This patch (by Nobuhiro Iwamatsu) adjusts the timeout to
10 seconds.

Dominic.

--
Dominic Hargreaves | http​://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)

@p5pRT
Copy link
Author

p5pRT commented Jun 4, 2011

From @jmdh

perl_re.t_sh4_timeout.diff
# Update lengthen time-out time for t/re/re.t.
#
# When we carry out this test on SH4, it becomes the time-out.
# 2 seconds are set in watchdog, but are too short for SH4.
# This patch was changed for 10 seconds.
#
# $ time ./perl  t/re/re.t
# 1..19
# ok 1 - is_regexp(REGEXP ref)
# ok 2 - is_regexp(REGEXP)
# ok 3 - is_regexp("")
# ok 4 - regexp_pattern[0] (ref)
# ok 5 - regexp_pattern[1] (ref)
# ok 6 - scalar regexp_pattern (ref)
# ok 7 - regexp_pattern[0] (bare REGEXP)
# ok 8 - regexp_pattern[1] (bare REGEXP)
# ok 9 - scalar regexp_pattern (bare REGEXP)
# ok 10 - !regexp_pattern("")
# ok 11 - regnames
# ok 12 - regnames
# ok 13 - regnames in scalar context
# ok 14 - regnames
# ok 15
# ok 16
# ok 17
# ok 18
# ok 19 - Didn't loop
#
# real    0m7.482s
# user    0m3.848s
# sys     0m0.036s

diff --git a/t/re/re.t b/t/re/re.t
index 249c6dd..84a5d1d 100755
--- a/t/re/re.t
+++ b/t/re/re.t
@@ -54,7 +54,7 @@ if ('1234'=~/(?:(?<A>\d)|(?<C>!))(?<B>\d)(?<A>\d)(?<B>\d)/){
 
     { # Keep this test last, as whole script will be interrupted if times out
         # Bug #72998; this can loop 
-        watchdog(2);
+        watchdog(10);
         eval '"\x{100}\x{FB00}" =~ /\x{100}\N{U+66}+/i';
         pass("Didn't loop");
     }

@p5pRT
Copy link
Author

p5pRT commented Jun 4, 2011

From @jmdh

I should have mentioned that the patch is against 5.12, but applies
cleanly to ext/re/t/re_funcs_u.t in blead.

--
Dominic Hargreaves | http​://www.larted.org.uk/~dom/
PGP key 5178E2A5 from the.earth.li (keyserver,web,email)

@p5pRT
Copy link
Author

p5pRT commented Jun 5, 2011

From @cpansprout

On Sat Jun 04 15​:17​:30 2011, dom wrote​:

This describes an issue originally reported by Nobuhiro Iwamatsu at
<http​://bugs.debian.org/cgi-bin/bugreport.cgi?bug=626125>.

On the sh4 architecture, the 2 second timeout in t/re/re.t was too
short. This patch (by Nobuhiro Iwamatsu) adjusts the timeout to
10 seconds.

Dominic.

Thank you. Applied as 7c47ab2.

@p5pRT
Copy link
Author

p5pRT commented Jun 5, 2011

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jun 5, 2011

@cpansprout - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant