New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Compress::Zlib location conflicts with autosplit #10282
Comments
From mls@suse.deCreated by mls@suse.deThe following code (stripped down from Mail-SpamAssassin-3.3.1) prints The difference between 5.10.1 and 5.12.0 is a change in the location of (It's also weird that $^S is not set in the __DIE__ handler, but 5.10.1 Perl Info
|
From @pmqsIs the change below, that was made a while back when Compress::Zlib lost it's xs file, responsible for the issue? ( If so, does it need to change? Paul
|
The RT System itself - Status changed from 'new' to 'open' |
From mls@suse.deA simple fix would be to add 'Compress/Zlib' to the archpms M. |
From @pmqsI've found the problem. Compress::Zlib still has an autoload section that was needed when it was an XS module. I forgot to remove it when the XS code got moved to Compress::Raw::Zlib. I'll sort out the CPAN copy. Paul
|
From @pmqsFrom: Michael Schroeder [mailto:mls@suse.de]
Sorry, no - Compress::Zlib isn't arch dependent anymore. Paul |
From @pmqsFrom: Michael Schroeder [mailto:mls@suse.de]
Yep, I have that sorted. Paul |
From mls@suse.deOn Fri, Apr 09, 2010 at 05:38:07PM +0100, Paul Marquess wrote:
Then please fix installperl so that Compress::Zlib's autosplit.ix Cheers, -- |
From @iabynOn Fri, Apr 09, 2010 at 11:48:05PM +0100, Paul Marquess wrote:
Is this something that will need pulling in for 5.12.1? -- |
From @pmqs
I'd say, yes, it is. That can be achieved by either syncing core with the CPAN copy of Paul |
From @pmqsHere is a patch that addresses #74088 I'll include this in the next CPAN update for Compress::Zlib Paul |
From @pmqs0001-perl-74088.patchFrom 571d8c96cf5d0683212052ceac7c8e53f40b3f3c Mon Sep 17 00:00:00 2001
From: paul <paul@paul-desktop.(none)>
Date: Thu, 15 Apr 2010 19:35:44 +0100
Subject: [PATCH] perl-74088
---
cpan/IO-Compress/Changes | 6 ++++++
cpan/IO-Compress/lib/Compress/Zlib.pm | 15 ++-------------
2 files changed, 8 insertions(+), 13 deletions(-)
diff --git a/cpan/IO-Compress/Changes b/cpan/IO-Compress/Changes
index c98bef1..e3a7a70 100644
--- a/cpan/IO-Compress/Changes
+++ b/cpan/IO-Compress/Changes
@@ -1,6 +1,12 @@
CHANGES
-------
+ 2.024_01 15 April 2010
+
+ * Compress::Zlib
+ Remove autoload code from Zlib.pm.
+ [perl #74088]
+
2.024 7 January 2010
* Compress::Zlib
diff --git a/cpan/IO-Compress/lib/Compress/Zlib.pm b/cpan/IO-Compress/lib/Compress/Zlib.pm
index 9424df6..b546dac 100644
--- a/cpan/IO-Compress/lib/Compress/Zlib.pm
+++ b/cpan/IO-Compress/lib/Compress/Zlib.pm
@@ -3,7 +3,6 @@ package Compress::Zlib;
require 5.004 ;
require Exporter;
-use AutoLoader;
use Carp ;
use IO::Handle ;
use Scalar::Util qw(dualvar);
@@ -16,9 +15,9 @@ use IO::Uncompress::Gunzip 2.024 ;
use strict ;
use warnings ;
use bytes ;
-our ($VERSION, $XS_VERSION, @ISA, @EXPORT, @EXPORT_OK, %EXPORT_TAGS, $AUTOLOAD);
+our ($VERSION, $XS_VERSION, @ISA, @EXPORT, @EXPORT_OK, %EXPORT_TAGS);
-$VERSION = '2.024';
+$VERSION = '2.024_01';
$XS_VERSION = $VERSION;
$VERSION = eval $VERSION;
@@ -46,16 +45,6 @@ BEGIN
*zlib_version = \&Compress::Raw::Zlib::zlib_version;
}
-sub AUTOLOAD {
- my($constname);
- ($constname = $AUTOLOAD) =~ s/.*:://;
- my ($error, $val) = Compress::Raw::Zlib::constant($constname);
- Carp::croak $error if $error;
- no strict 'refs';
- *{$AUTOLOAD} = sub { $val };
- goto &{$AUTOLOAD};
-}
-
use constant FLAG_APPEND => 1 ;
use constant FLAG_CRC => 2 ;
use constant FLAG_ADLER => 4 ;
--
1.6.0.4
|
From @cpansproutThis was fixed by commit e8796d6. |
@cpansprout - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#74088 (status was 'resolved')
Searchable as RT74088$
The text was updated successfully, but these errors were encountered: