Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

podchecker says Unknown command 'encoding' #9105

Closed
p5pRT opened this issue Nov 8, 2007 · 4 comments
Closed

podchecker says Unknown command 'encoding' #9105

p5pRT opened this issue Nov 8, 2007 · 4 comments

Comments

@p5pRT
Copy link

p5pRT commented Nov 8, 2007

Migrated from rt.perl.org#47271 (status was 'resolved')

Searchable as RT47271$

@p5pRT
Copy link
Author

p5pRT commented Nov 8, 2007

From @nwc10

Created by @nwc10

I wanted to add an

  =encoding utf8

to perl5100delta.pod because it's in UTF-8.

I ran podchecker before I committed it. podchecker fails it.

Here's an example we can all already run​:

./perl -Ilib pod/podchecker pod/perlcn.pod
*** ERROR​: Unknown command 'encoding' at line 11 in file pod/perlcn.pod
pod/perlcn.pod has 1 pod syntax error.

Um, it seems, um, bonkers, that our own core POD checking tool declares some
of our existing POD files invalid. Hence why I set severity to high and flag
it as a core bug rather than a library bug.

Nicholas Clark

Perl Info

Flags:
    category=core
    severity=high

Site configuration information for perl 5.10.0:

Configured by nick at Thu Nov  8 13:43:56 GMT 2007.

Summary of my perl5 (revision 5 version 10 subversion 0) configuration:
  Platform:
    osname=freebsd, osvers=6.2-release-p4, archname=i386-freebsd-thread-multi
    uname='freebsd saigo.etla.org 6.2-release-p4 freebsd 6.2-release-p4 #2: sun apr 29 08:28:44 bst 2007 root@saigo.etla.org:usrobjusrsrcsyssaigo2 i386 '
    config_args='-Dusedevel=y -Dcc=ccache gcc -Dld=gcc -Ubincompat5005 -Uinstallusrbinperl -Dcf_email=nick@ccl4.org -Dperladmin=nick@ccl4.org -Dinc_version_list=  -Dinc_version_list_init=0 -Doptimize=-g -Dusethreads -Uuse64bitint -Uusemymalloc -Duseperlio -Dprefix=~/Sandpit/snap5.9.x-32242 -Dinstallman1dir=none -Dinstallman3dir=none -Uuserelocatableinc -Dmad -de'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=define, usemultiplicity=define
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=undef, use64bitall=undef, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='ccache gcc', ccflags ='-DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -DDEBUGGING -fno-strict-aliasing -pipe -I/usr/local/include',
    optimize='-g',
    cppflags='-DHAS_FPSETMASK -DHAS_FLOATINGPOINT_H -DDEBUGGING -fno-strict-aliasing -pipe -I/usr/local/include'
    ccversion='', gccversion='3.4.6 [FreeBSD] 20060305', gccosandvers=''
    intsize=4, longsize=4, ptrsize=4, doublesize=8, byteorder=1234
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=12
    ivtype='long', ivsize=4, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=4, prototype=define
  Linker and Libraries:
    ld='gcc', ldflags ='-pthread -Wl,-E  -L/usr/local/lib'
    libpth=/usr/lib /usr/local/lib
    libs=-lm -lcrypt
    perllibs=-lm -lcrypt
    libc=, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags=' '
    cccdlflags='-DPIC -fPIC', lddlflags='-shared  -L/usr/local/lib'

Locally applied patches:
    DEVEL


@INC for perl 5.10.0:
    lib
    /home/nick/Sandpit/snap5.9.x-32242/lib/perl5/5.10.0/i386-freebsd-thread-multi
    /home/nick/Sandpit/snap5.9.x-32242/lib/perl5/5.10.0
    /home/nick/Sandpit/snap5.9.x-32242/lib/perl5/site_perl/5.10.0/i386-freebsd-thread-multi
    /home/nick/Sandpit/snap5.9.x-32242/lib/perl5/site_perl/5.10.0
    .


Environment for perl 5.10.0:
    HOME=/home/nick
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/nick/bin:/sbin:/bin:/usr/sbin:/usr/bin:/usr/games:/usr/local/sbin:/usr/local/bin:/usr/X11R6/bin:/home/nick/bin:/usr/local/sbin:/sbin:/usr/sbin
    PERL_BADLANG (unset)
    SHELL=/usr/local/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Nov 15, 2007

From @smpeters

On Thu Nov 08 08​:06​:36 2007, nicholas wrote​:

This is a bug report for perl from nick@​ccl4.org,
generated with the help of perlbug 1.36 running under perl 5.10.0.

-----------------------------------------------------------------
[Please enter your report here]

I wanted to add an

=encoding utf8

to perl5100delta.pod because it's in UTF-8.

I ran podchecker before I committed it. podchecker fails it.

Here's an example we can all already run​:

./perl -Ilib pod/podchecker pod/perlcn.pod
*** ERROR​: Unknown command 'encoding' at line 11 in file
pod/perlcn.pod
pod/perlcn.pod has 1 pod syntax error.

Um, it seems, um, bonkers, that our own core POD checking tool
declares some
of our existing POD files invalid. Hence why I set severity to high
and flag
it as a core bug rather than a library bug.

Nicholas Clark

This should be fixed with the following change.

Steve Peters

Change 32330 by stevep@​stevep-kirk on 2007/11/15 21​:20​:41

  Change Pod​::Checker to allow the "=encoding" Pod command. Fixes
  RT #47271​: podchecker says Unknown command 'encoding'

Affected files ...

... //depot/perl/lib/Pod/Checker.pm#28 edit

Differences ...

==== //depot/perl/lib/Pod/Checker.pm#28 (text) ====

@​@​ -10,7 +10,7 @​@​
package Pod​::Checker;

use vars qw($VERSION);
-$VERSION = 1.43; ## Current version of this package
+$VERSION = 1.4301; ## Current version of this package
require 5.005; ## requires this Perl version or later

use Pod​::ParseUtils; ## for hyperlinks and lists
@​@​ -364,6 +364,7 @​@​
  'for' => 1,
  'begin' => 1,
  'end' => 1,
+ 'encoding' => '1',
);

my %VALID_SEQUENCES = (

@p5pRT
Copy link
Author

p5pRT commented Nov 15, 2007

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Nov 15, 2007

@smpeters - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant