New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow options to be passed to prelink in Windows #12453
Comments
From @ikegamiCreated by @ikegamiHi, When using MS's compiler, symbols aren't exported by DLLs unless prelink() builds this .def file. It supports options that allow Patch forthcoming. Thanks, Perl Info
|
From @ikegamiPatch attached. Not sure what to do about the file versions. |
From @ikegami0001-Allow-a-list-of-symbols-to-export-to-be-passed-to-li.patchFrom 7376a39ef4f98e8cc890df640408d0a863f0f001 Mon Sep 17 00:00:00 2001
From: Eric Brine <ikegami@adaelis.com>
Date: Mon, 1 Oct 2012 19:30:04 -0700
Subject: [PATCH] Allow a list of symbols to export to be passed to link() when on Windows, as on other OSes.
---
.../lib/ExtUtils/CBuilder/Platform/Windows.pm | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows.pm b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows.pm
index 20fabf7..32bf482 100644
--- a/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows.pm
+++ b/dist/ExtUtils-CBuilder/lib/ExtUtils/CBuilder/Platform/Windows.pm
@@ -212,7 +212,8 @@ sub link {
(my $def_base = $spec{def_file}) =~ tr/'"//d;
$def_base =~ s/\.def$//;
- $self->prelink( dl_name => $args{module_name},
+ $self->prelink( %args,
+ dl_name => $args{module_name},
dl_file => $def_base,
dl_base => $spec{basename} );
--
1.7.2.5
|
@ikegami - Status changed from 'new' to 'open' |
From @steve-m-hayEric Brine via RT wrote on 2012-10-02:
Thanks for the patch. It looks good to me. I will test it and apply later with appropriate version bumps if all is well. |
From @LeontOn Tue, Oct 2, 2012 at 4:37 AM, Eric Brine <perlbug-followup@perl.org> wrote:
I can't say I'm surprised it's broken in such a way, I've fixed Leon |
From @ikegamiOn Tue, Oct 2, 2012 at 4:02 AM, Steve Hay <Steve.Hay@verosoftware.com> wrote:
I tested it by changing $cb->link(objects => [$o_file], module_name => "t::dyna_low"); to $cb->link(objects => [$o_file], module_name => "t::dyna_low", in DynaLoader::Functions's t/dyna_low.t. The test doesn't succeed with - Eric |
From @steve-m-hayThanks again, now applied as 4ae0770. |
From [Unknown Contact. See original ticket]Thanks again, now applied as 4ae0770. |
@steve-m-hay - Status changed from 'open' to 'resolved' |
@ikegami - Status changed from 'resolved' to 'open' |
From @ikegamiOn Sun Mar 10 17:31:50 2013, ikegami@adaelis.com wrote:
Hi, ExtUtils::CBuilder is dual-lifed, but the CPAN release is out of date. Thanks, |
From @LeontOn Thu, May 23, 2013 at 9:08 PM, Eric Brine via RT
I think Alberto volunteered for that ;-) Leon |
From @ikegamiOn Thu, May 23, 2013 at 5:21 PM, Leon Timmermans via RT <
w00t! It's been done! Closing ticket. |
@ikegami - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#115100 (status was 'resolved')
Searchable as RT115100$
The text was updated successfully, but these errors were encountered: