New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl fb85c04 (?^...) breaks CPAN #10658
Comments
From @andkThis ticket is considered to hold pointers to all CPAN distros that are ADAMK/Aspect-0.92.tar.gz -- |
From @avarOn Thu, Sep 23, 2010 at 06:39, Andreas J. Koenig via RT
I've fixed this in YAML::Syck and uploaded it as 1.15 to CPAN. |
The RT System itself - Status changed from 'new' to 'open' |
From @khwilliamson(Andreas J. Koenig) (via RT) wrote:
I spent some time looking at a problem that came up with one of these. But Avar reminded me on IRC that there is an API to do that parsing for use re; $mods will contain all the non-default modifiers, and $pat the guts of |
From @khwilliamsonkarl williamson wrote:
I forgot to say that you need to say re::regexp_pattern($ref); I've also patched perldelta, which is attached, as perlbug has stopped |
From @khwilliamson0001-perldelta-Give-better-instructions-about.patchFrom 8df611470f97a7fd0f2d7e5cb10ea45f0612e703 Mon Sep 17 00:00:00 2001
From: Karl Williamson <public@khwilliamson.com>
Date: Thu, 23 Sep 2010 19:50:34 -0600
Subject: [PATCH] perldelta: Give better instructions about (?^...)
Avar pointed out that there is an existing API wwhich helps in coping
with this
---
pod/perldelta.pod | 17 ++++++++++++++---
1 files changed, 14 insertions(+), 3 deletions(-)
diff --git a/pod/perldelta.pod b/pod/perldelta.pod
index 5bb3706..7b76c9d 100644
--- a/pod/perldelta.pod
+++ b/pod/perldelta.pod
@@ -68,11 +68,22 @@ L</Selected Bug Fixes> section.
Default regular expression modifiers are now notated by using
C<(?^...)>. Code relying on the old stringification will fail. The
purpose of this is so that when new modifiers are added, such code will
-not have to change, as the stringification will automatically
-incorporate the new modifiers.
+not have to change (after this one time), as the stringification will
+automatically incorporate the new modifiers.
Code that needs to work properly with both old- and new-style regexes
-can use something like the following:
+can avoid the whole issue by using:
+
+ use re qw(regexp_pattern);
+ my ($pat, $mods) = regexp_pattern($re_ref);
+
+where C<$re_ref> is a reference to a compiled regular expression. Upon
+return, C<$mods> will be a string containing all the non-default
+modifiers used when the regular expression was compiled, and C<$pattern>
+the actual pattern.
+
+If the actual stringification is important, you can use something like
+the following:
# Accept both old and new-style stringification
my $modifiers = (qr/foobar/ =~ /\Q(?^/) ? '^' : '-xism';
--
1.5.6.3
|
From @khwilliamsonkarl williamson wrote:
And another thing about this, I ended up having to grep for -xism:, |
From @rgarciaOn 23 September 2010 08:39, Andreas J. Koenig via RT
I pushed a fix on github ; will release later. http://github.com/rgs/Test-LongString/commit/344e3692e1f21e45c67f15c09f893c77a86ce367 |
From @andk
> This ticket is considered to hold pointers to all CPAN distros that are I just want to give you an updated list of affected modules, the list is ADAMK/Aspect-0.92.tar.gz -- |
From @andk
Since 5.13.6 is close I want to update the list again. Note that it is Data::Dump, Exception::Base, Moose, Test::Deep have been fixed and new ADAMK/ Aspect-0.92.tar.gz -- |
From @briandfoyI think I've fixed Test::Output for blead. CPAN Testers doesn't seem to have any reports for |
From @andk
> I think I've fixed Test::Output for blead. CPAN Testers doesn't seem I have sent 4 testers reports with recent bleadperls and 7 with not so test PASS Test-Output-0.16_02 (perl-5.13.5) x86_64-linux-ld 2.6.32-2-amd64 There seems something broken on cpantesters throughput, my score in -- |
From @andk
This is where we're standing today. Ten unpatched, 6 patched, two fixed ADAMK/ Aspect-0.92.tar.gz #62257 -- |
From @obraOn Wed Dec 01 20:18:19 2010, andreas.koenig.7os6VVqR@franz.ak.mind.de wrote:
The following dists are still broken on CPAN
Of these, I'd love it if someone could run reverse-deps and tell me how much of The following, I believe, are no longer an issue:
Major new release, no obvious changelog
Fix released
Fixed in 0.23
Fixed in 0.30
Fixed in 3.38
Fixed in 0.08
Fixed |
From @cpansproutOn Fri Apr 01 23:07:13 2011, jesse wrote:
YAML: deps.cpantesters.org has a bug in it (reported) that is causing Getopt-LL: Class-Dot-Model and File-BSED Regexp-Log: Regexp-Assemble: 30 dependents CGI-Alert: none Test-Exception-LessClever: 25 Test-Base: 152 YAML-LibYAML: About 40 immediate dependents, but the same Test-Unit: none There are more modules to be added to the list of those broken by (?^). Apache-LogRegex-1.5: none Data-FormValidator-Constraints-Words-0.04: Parse-RandGen-0.202: none Regexp-English-1.00: none Regexp-HTMLify-0.001: none Regexp-Parser-0.20: none Switch-Perlish-1.0.5: none Template-Parser-CET-0.05: Test-DatabaseRow-1.04: Regex-Iterator-0.3: none Text-Quote-0.3: AI-Prolog YAML-Old-0.81: none |
From @obraOn Sun 3.Apr'11 at 14:29:40 -0700, Father Chrysostomos via RT wrote: Thanks for the triage.
I've confirmed with ingy that he's working to fix To make an arbitrary call: If a module doesn't have at least 5 To that end, I'd consider the following blcoking:
I'd not consider the following blocking
|
From chromatic@wgz.orgOn Sunday 03 April 2011 at 14:29, Father Chrysostomos wrote:
Fixed in 1.01, not that it should block anything. -- c |
From @obraOn Sun Apr 03 21:11:41 2011, jesse@bestpractical.com wrote:
Ingy has uploaded new versions of his modules. David and Chad have With that, I'm thrilled to be able to resolve this ticket as a 5.14 |
@obra - Status changed from 'open' to 'resolved' |
From david@landgren.netOn 06/04/2011 16:15, Jesse via RT wrote:
Fixed by 0.35 (slightly amazed to discover it has 30 dependants)
David -- |
From @cpansproutOn Wed Apr 06 07:15:33 2011, jesse wrote:
Did you perhaps confuse YAML.pm with YAML::XS? YAML.pm has not been I’m re-opening this ticket. (If you disagree, please just close it.) |
@cpansprout - Status changed from 'resolved' to 'open' |
From @cpansproutOn Wed Apr 06 07:15:33 2011, jesse wrote:
Did you perhaps confuse YAML.pm with YAML::XS? YAML.pm has not been I’m re-opening this ticket. (If you disagree, please just close it.) |
From @obraAdam, You'd said you were going to get a new release of YAML that works on Is there anything that we can do to help that happen in the next -Jesse On Sun 17.Apr'11 at 14:03:04 -0700, Father Chrysostomos via RT wrote:
|
From @obraIngy has just uploaded YAML.pm 0.73, which I've verified passes on blead. I'm resolving this ticket until we find another catastrophic blead- |
From [Unknown Contact. See original ticket]Ingy has just uploaded YAML.pm 0.73, which I've verified passes on blead. I'm resolving this ticket until we find another catastrophic blead- |
@obra - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#78008 (status was 'resolved')
Searchable as RT78008$
The text was updated successfully, but these errors were encountered: