New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH] Another SEGV in Data::Dumper #10106
Comments
From @cpansprout$ perl5.6.2 -MData::Dumper -le' Data::Dumper->Dumpxs([*{*STDERR{IO}}])' Same in 5.11.4. Use of uninitialized value $category in concatenation (.) or string Flags: This perlbug was built using Perl 5.10.1 - Thu Sep 24 18:07:44 PDT 2009 Site configuration information for perl 5.11.4: Configured by sprout at Wed Jan 20 14:43:32 PST 2010. Summary of my perl5 (revision 5 version 11 subversion 4) configuration: Platform: Locally applied patches: @INC for perl 5.11.4: Environment for perl 5.11.4: |
From @cpansproutOn Jan 24, 2010, at 1:50 PM, Father Chrysostomos wrote:
Here is the patch. |
From @cpansproutInline Patchdiff -Nurp blead/dist/Data-Dumper/Dumper.xs blead-dd-segv/dist/Data-Dumper/Dumper.xs
--- blead/dist/Data-Dumper/Dumper.xs 2009-11-19 08:51:38.000000000 -0800
+++ blead-dd-segv/dist/Data-Dumper/Dumper.xs 2010-01-23 09:21:15.000000000 -0800
@@ -909,7 +909,7 @@ DD_dump(pTHX_ SV *val, const char *name,
}
else if (realtype == SVt_PVGV) {/* GLOBs can end up with scribbly names */
c = SvPV(val, i);
- ++c; --i; /* just get the name */
+ if(i) ++c, --i; /* just get the name */
if (i >= 6 && strncmp(c, "main::", 6) == 0) {
c += 4;
i -= 4;
diff -Nurp blead/dist/Data-Dumper/t/bugs.t blead-dd-segv/dist/Data-Dumper/t/bugs.t
--- blead/dist/Data-Dumper/t/bugs.t 2009-11-19 08:51:38.000000000 -0800
+++ blead-dd-segv/dist/Data-Dumper/t/bugs.t 2010-01-22 22:26:55.000000000 -0800
@@ -12,7 +12,7 @@ BEGIN {
}
use strict;
-use Test::More tests => 5;
+use Test::More tests => 6;
use Data::Dumper;
{
@@ -80,4 +80,9 @@ sub doh
doh('fixed');
ok(1, "[perl #56766]"); # Still no core dump? We are fine.
+# [perl #72332] Segfault on empty-string glob
+Data::Dumper->Dump([*{*STDERR{IO}}]);
+ok("ok", #ok
+ "empty-string glob [perl #72332]");
+
# EOF |
From @tseeHi all, Father Chrysostomos wrote:
Should this be in 5.12? If so, I can check and apply it tonight. Best regards, |
The RT System itself - Status changed from 'new' to 'open' |
From @obra
If it's on this list: http://tinyurl.com/ygo9awx, then the answer is http://www.nntp.perl.org/group/perl.perl5.porters/2010/01/msg155374.html
-- |
From @tseeHi Jesse, jesse wrote:
I have the attention span of a slug. :) Anyhow, the bug in question is sort of a follow-up on something that was --Steffen |
From @cpansproutOn Mon Jan 25 00:48:48 2010, sprout wrote:
Applied as ecf0432 |
From [Unknown Contact. See original ticket]On Mon Jan 25 00:48:48 2010, sprout wrote:
Applied as ecf0432 |
@cpansprout - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#72332 (status was 'resolved')
Searchable as RT72332$
The text was updated successfully, but these errors were encountered: