New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DragonFly thread lib selection #9905
Comments
From corecode@fs.ei.tum.deHey, attached patch fixes the thread library detection in DragonFly. All Please let me know if you have any questions. Thanks, -- |
From corecode@fs.ei.tum.deperl-dragonfly-threads.diff$NetBSD$
--- hints/dragonfly.sh.orig 2009-10-09 15:28:17 +0200
+++ hints/dragonfly.sh
@@ -19,18 +19,10 @@ esac
# out here to avoid duplicating them everywhere.
case "$osvers" in
*) objformat=`/usr/bin/objformat`
- if [ x$objformat = xelf ]; then
- libpth="/usr/lib /usr/local/lib"
- glibpth="/usr/lib /usr/local/lib"
- ldflags="-Wl,-E "
- lddlflags="-shared "
- else
- if [ -e /usr/lib/aout ]; then
- libpth="/usr/lib/aout /usr/local/lib /usr/lib"
- glibpth="/usr/lib/aout /usr/local/lib /usr/lib"
- fi
- lddlflags='-Bshareable'
- fi
+ libpth="/usr/lib /usr/local/lib"
+ glibpth="/usr/lib /usr/local/lib"
+ ldflags="-Wl,-E "
+ lddlflags="-shared "
cccdlflags='-DPIC -fPIC'
;;
esac
@@ -67,43 +59,16 @@ d_voidsig='define'
cat > UU/usethreads.cbu <<'EOCBU'
case "$usethreads" in
$define|true|[yY]*)
- lc_r=`/sbin/ldconfig -r|grep ':-lc_r'|awk '{print $NF}'|sed -n '$p'`
case "$osvers" in
- *) if [ ! -r "$lc_r" ]; then
- cat <<EOM >&4
-POSIX threads should be supported by FreeBSD $osvers --
-but your system is missing the shared libc_r.
-(/sbin/ldconfig -r doesn't find any).
+ *) ldflags="-pthread $ldflags"
-Consider using the latest STABLE release.
-EOM
- exit 1
- fi
- case "$osvers" in
- *) ldflags="-pthread $ldflags"
- ;;
- esac
# Both in 4.x and 5.x gethostbyaddr_r exists but
# it is "Temporary function, not threadsafe"...
# Presumably earlier it didn't even exist.
d_gethostbyaddr_r="undef"
d_gethostbyaddr_r_proto="0"
- ;;
- esac
- set `echo X "$libswanted "| sed -e 's/ c / c_r /'`
- shift
- libswanted="$*"
- # Configure will probably pick the wrong libc to use for nm scan.
- # The safest quick-fix is just to not use nm at all...
- usenm=false
-
- unset lc_r
-
- # Even with the malloc mutexes the Perl malloc does not
- # seem to be threadsafe in FreeBSD?
- case "$usemymalloc" in
- '') usemymalloc=n ;;
+ ;;
esac
esac
EOCBU
|
From @bingosOn Fri, Oct 09, 2009 at 10:49:56AM -0700, Simon 'corecode' Schubert (via RT) wrote:
Thanks, applied as http://perl5.git.perl.org/perl.git/commit/6c1b5ced I will test when I have access to a Dragonfly BSD system on Monday. Cheers, --
|
The RT System itself - Status changed from 'new' to 'open' |
From @bingosOn Sat, Oct 10, 2009 at 07:31:34PM +0100, Chris 'BinGOs' Williams wrote:
Okay, managed to get a Dragonfly BSD 2.0.1 system going today to test Builds fine with ./Configure -de -Dusedevel -Dusethreads && make make test though hangs on cpan/libnet/t/hostname.t had to eventually give up on it after an hour. Don't know if this is a Dragonfly thing, or a dfly running under vmware thing. Maybe someone else with a dfly system on 'real' hardware would like to pitch in Cheers, --
|
From corecode@fs.ei.tum.deChris 'BinGOs' Williams wrote:
Thanks for trying to test! The most recent version is 2.4.1, which is over a year newer - it might
Well, I am running multiple DragonFly systems :) The thread patch for Let me know if you need some other testing. cheers -- |
From @bingosOn Tue, Oct 13, 2009 at 01:12:26AM +0200, Simon 'corecode' Schubert wrote:
o.O not noticed that. Cool. I'll have to try that out when I get the tuits.
Yeah, I should be grateful if you could find the time to test blead perl $ git clone git://perl5.git.perl.org/perl.git perl Many thanks, --
|
From @doughera88On Mon, 12 Oct 2009, Chris 'BinGOs' Williams wrote:
I saw something similar a while ago with NetBSD (or maybe it was OpenBSD) In any case, I don't think it's related to this patch at all. -- |
From corecode@fs.ei.tum.deChris 'BinGOs' Williams wrote:
Failed 5 tests out of 1709, 99.71% okay. Please let me know whether and how I should investigate this further. cheers |
From @obraOn Fri, Oct 16, 2009 at 06:55:47PM +0200, Simon 'corecode' Schubert wrote:
Simon, I'd be curious to know how the just-released 5.11.1 does for you. Thanks!
-- |
From @maukeOn Tue Oct 20 11:36:03 2009, jesse wrote:
This ticket is listed in perl5120delta: DragonFly BSD * Fix thread library selection [perl #69686] I think it can be closed. Objections? |
From @ap* l.mai@web.de via RT <perlbug-followup@perl.org> [2016-02-22 22:20]:
The patch was applied in 6c1b5ce Not sure why Jesse wanted feedback from the OP on whether his own patch I say close. |
From @jkeenanOn Fri May 20 23:09:31 2016, aristotle wrote:
Closing. -- |
@jkeenan - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#69686 (status was 'resolved')
Searchable as RT69686$
The text was updated successfully, but these errors were encountered: