New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recent changes to inline.h have broken VC6 build on Windows #16381
Comments
From @steve-m-hayI've just discovered that the VC6 build on Windows is broken: cl -c -nologo -GF -W3 -I..\lib\CORE -I.\include -I. -I.. -DWIN32 It seems that VC6 doesn't understand the "ULL" suffixes on numbers in |
From @khwilliamsonPlease check if this branch (which contains a number of irrelevant commits as well) fixes the problem |
The RT System itself - Status changed from 'new' to 'open' |
From @xenuOn Thu, 25 Jan 2018 06:04:00 -0800
Do we really want to keep supporting VC6? That compiler is 20 years old, I feel that VC6 support is a liability. |
From @LeontOn Fri, Jan 26, 2018 at 12:22 AM, Tomasz Konojacki <me@xenu.pl> wrote:
The question is really: do we want to keep supporting C89 (long long Leon |
From @xenuOn Fri, 26 Jan 2018 03:09:33 +0100
Yeah, but it's an *extremely* common extension found in many non-C99 |
From @khwilliamsonOn 01/25/2018 07:30 PM, Tomasz Konojacki wrote:
Nonetheless, until the project decides it won't support C89 anymore, we And that decision will take a while to make, and there must be some If someone wants to propose requiring C99, it should be brought up on a |
From @steve-m-hayOn 25 January 2018 at 17:42, Karl Williamson via RT
I assume you mean the smoke-me/khw-variant branch? I tried that and 1) inline.h causes warnings: ..\inline.h(629) : warning C4244: '+=' : conversion from 'unsigned 2) the build still fails, now during Encode: panic: _force_out_malformed_utf8_message should be called only when I haven't looked into whether such problems (the second in particular) |
From @steve-m-hayOn 25 January 2018 at 23:22, Tomasz Konojacki <me@xenu.pl> wrote:
I personally agree, and have suggested dropping support before, but https://www.nntp.perl.org/group/perl.perl5.porters/2013/09/msg207597.html |
From @steve-m-hayOn 26 January 2018 at 08:50, Steve Hay <steve.m.hay@googlemail.com> wrote:
With current blead but commit 1d2af57 So smoke-me/khw-variant fixes the inline.h problem, but introduces |
From @craigberryOn Fri, Jan 26, 2018 at 3:00 AM, Steve Hay via perl5-porters
It seems to me that things *have* changed since then. If we remove I didn't reread every message in that thread, but it seems to me it 1.) ActiveState binaries are built with VC6 so it needs to be So I really don't see any reason to keep it, and removing it now does |
From @khwilliamsonOn 01/26/2018 06:40 AM, Steve Hay via perl5-porters wrote:
Is it the same hardware you're running each OS version on? I looked at the code, and I think the new warnings are bogus. blead The panic I would have to look at it more depth. If it's the same |
From @steve-m-hayOn 26 January 2018 at 16:34, Karl Williamson <public@khwilliamson.com> wrote:
Both compilers were running on the same machine running Windows 8.1. I've now tried VC6 and VC14 (VC++ 2015) on a second machine (running It could well be a compiler problem, as you say. |
From @khwilliamsonOn 01/25/2018 09:04 PM, Karl Williamson wrote:
And similarly for MSVC6. With that in mind, please test the latest smoke-me/khw-variant, as I |
From @steve-m-hayOn 28 January 2018 at 17:41, Karl Williamson <public@khwilliamson.com> wrote:
Yes, that fixes the VC6 build. Thanks. |
From @steve-m-hayOn 29 January 2018 at 08:29, Steve Hay <steve.m.hay@googlemail.com> wrote:
I get a test failure after building it, though :-/ C:\Dev\Git\perl\t>.\perl harness ../ext/XS-APItest/t/utf8.t Test Summary Report ../ext/XS-APItest/t/utf8.t (Wstat: 65280 Tests: 324 Failed: 0) |
From @steve-m-hayOn 29 January 2018 at 09:17, Steve Hay <steve.m.hay@googlemail.com> wrote:
(I get the same with VC14 too, so this isn't VC6-specific.) |
From @khwilliamsonOn 01/29/2018 07:01 AM, Steve Hay wrote:
So this is a new failure? If so, can you bisect it (starting with |
From @khwilliamsonOn 01/29/2018 11:08 AM, Karl Williamson wrote:
Never mind, I was able to reproduce the problem on dromedary's win32, On dromedary, if I revert the unrelated commits, the problem goes away, |
From @khwilliamsonOn 01/27/2018 04:23 AM, Steve Hay wrote:
I realized later that a bunch of callers could potentially call the When you get around to trying VC6 again, you could make sure this hasn't |
From @steve-m-hayOn 31 January 2018 at 02:03, Karl Williamson <public@khwilliamson.com> wrote:
It's still working fine, thanks. |
From @khwilliamsonOP agrees it is fixed |
@khwilliamson - Status changed from 'open' to 'resolved' |
From @demerphqOn 26 January 2018 at 16:01, Craig A. Berry <craig.a.berry@gmail.com> wrote:
+1. Yves -- |
Migrated from rt.perl.org#132766 (status was 'resolved')
Searchable as RT132766$
The text was updated successfully, but these errors were encountered: