New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
pl2bat
BAT files exit with incorrect ERRORLEVEL and process exit codes
#16361
Comments
From RIVY@cpan.orgCreated by rivy@cpan.netThis is a bug report for perl from rivy@cpan.net, ----------------------------------------------------------------- As currently defined, the BAT files created with `pl2bat` will exit with Examples of failures, (from the CMD shell): ``` batch ``` batch Changing... `if errorlevel 1 goto script_failed_so_exit_with_non_zero_val 2>nul` ... to ... `if NOT "%errorlevel%" == "0" ( goto #_undefined_label_# 2>nul || will exit the process correctly, returning a correct process code and With the change: ``` batch Additionally, it works for all non-zero ERRORLEVELs (such as the common ``` batch Thanks for the attention! Perl Info
|
From @LeontOn Sat, Jan 13, 2018 at 6:12 PM, Roy Ivy III <perlbug-followup@perl.org> wrote:
In the past two decades pl2bat got forked twice. First in My main limitation here is not really being a Windows person, and Leon |
The RT System itself - Status changed from 'new' to 'open' |
From RIVY@cpan.orgOn Sun, 14 Jan 2018 14:39:20 -0800, LeonT wrote:
I can help. I saw the [ExtUtils::Helpers](https://github.com/Leont/extutils-helpers) repo. But, given the code that I saw in perl, I wasn't sure how it was related. I've been working on an AppVeyor configuration that could help with the Windows testing. I'll open a couple of issues on the repo with some suggestions and an AppVeyor configuration. |
From RIVY@cpan.orgOn Sun, 14 Jan 2018 14:39:20 -0800, LeonT wrote:
Leon, I forked [ExtUtils::PL2Bat](https://github.com/rivy/perl.ExtUtils-PL2Bat) and added all the needed corrections (to PL2Bat, the AppVeyor CI config, and testing). I've pushed a [PR](Perl-Toolchain-Gang/extutils-pl2bat#3) for all the changes. The PL2Bat changes include fixed handling of "echo", "ERRORLEVEL", and general environment state. Testing now checks for correct process exit status as well as the actual exit code. And the new AppVeyor config correctly tests against all `perl` versions back to v5.8.9; and all tests are now passing. This should give you a much better Windows base for further changes. Let me know if I can be of further assistance, or if you need changes to the PR. - Roy |
Migrated from rt.perl.org#132717 (status was 'open')
Searchable as RT132717$
The text was updated successfully, but these errors were encountered: