New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH] Set more sensible -O optimization on FreeBSD #16357
Comments
From @tomhukinsCreated by @tomhukinsThe attached patch sets a more sensible, standard optimization flag on Perl Info
|
From @tomhukins0001-Set-more-sensible-O-optimization-on-FreeBSD.patchFrom 8dbb5231affc72b0d72f960351406bfdb0c3c371 Mon Sep 17 00:00:00 2001
From: Tom Hukins <tom@eborcom.com>
Date: Wed, 10 Jan 2018 18:53:24 +0000
Subject: [PATCH] Set more sensible -O optimization on FreeBSD
FreeBSD's /usr/share/mk/sys.mk specifies -O2 for architectures other
than arm and mips. By default, compile perl with the same optimization
levels.
---
hints/freebsd.sh | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/hints/freebsd.sh b/hints/freebsd.sh
index 5d69dee0eb..07eab0e252 100644
--- a/hints/freebsd.sh
+++ b/hints/freebsd.sh
@@ -343,3 +343,10 @@ case "$cc" in
;;
esac
+case `uname -p` in
+arm|mips)
+ ;;
+*)
+ test "$optimize" || optimize='-O2'
+ ;;
+esac
--
2.15.1
|
From mat@cpan.orgI don't think lagging behind what FreeBSD does is a great idea. It would probably be just as good to inherit CFLAGS set by the OS and or the user using something like: $ make -f /dev/null -V CFLAGS |
The RT System itself - Status changed from 'new' to 'open' |
From mat@cpan.orgIt would inherit the right value depending on the architecture being built: $ env MACHINE_ARCH=mips64 make -f /dev/null -V CFLAGS |
@tonycoz - Status changed from 'open' to 'pending release' |
From @jkeenanOn Tue, 16 Jan 2018 05:19:05 GMT, tonyc wrote:
Tony, can you elaborate a bit more on why you applied this patch despite the objection of the Perl maintainer for FreeBSD? I'm not saying Mat is definitely correct, but I think his statements should be addressed. Thank you very much. -- |
From @tomhukinsOn Thu, Jan 11, 2018 at 05:30:13AM -0800, Mathieu Arnold via RT wrote:
I agree there's scope for future improvement. However, reusing the Tom |
From @tonycozOn Tue, 16 Jan 2018 05:14:47 -0800, jkeenan wrote:
I wasn't aware he was the FreeBSD maintainer. In general we don't have Configure inherit from the environment, though someone building perl can certain do that by passing "-Dccflags=$CFLAGS" or similar on the Configure command line. Tony |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release yesterday of Perl 5.28.0, this and 185 other issues have been Perl 5.28.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#132704 (status was 'resolved')
Searchable as RT132704$
The text was updated successfully, but these errors were encountered: