New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Carp quoting issue #16247
Comments
From tk@giga.or.atCreated by tk@giga.or.atOne of the self tests of Function-Parameters fails with perl-5.26.1 The original bug report is at The test program that fails and should not fail according to #!perl use Carp; my $file = __FILE__; { eval { my $line_confess = $line + 6; ::like($@, qr/^abc 123 at \Q$file\E line $line_confess\.?\n\tFoo::foo\((["'])abc\1, 123\) called at \Q$file\E line $line_foo/); SKIP: { skip "Sub::Name required", 1 unless eval { require Sub::Name }; { eval { my $line_confess = $line + 24; ::like($@, qr/^9 at \Q$file\E line $line_confess\.?\n\tBar::bar\(4, 5\) called at \Q$file\E line $line_bar/); } done_testing; For me, on NetBSD-8.99.6/amd64 with perl-5.26.1 this gives: # perl test Perl Info
|
From @jkeenanOn Tue, 14 Nov 2017 23:30:56 GMT, tk@giga.or.at wrote:
The second test -- the one where Sub::Name has been installed and is being used -- appears to be dependent on line numbers hard-coded into the file -- yet the test which is of concern is "failing" only with respect to line numbers. You can get the second test to "pass" simply by manipulating the numbers assigned in these two lines: ##### And since it's only the second test that is failing, it is just as likely that this is a bug in Sub::Name (not part of the core distribution) as it is in Carp. Thank you very much. -- |
The RT System itself - Status changed from 'new' to 'open' |
From @maukeOn Wed, 15 Nov 2017 08:15:52 -0800, jkeenan wrote:
The test output is: not ok 1 The second test is not failing; the first test is. And the line numbers in the failure are identical: # Failed test at test line 25. "... line 15" and "... line 19" match. The problem is that what should have been pretty-printed as Foo::foo("abc", 123) by Carp::confess got emitted as Foo::foo("\"abc\"", 123) instead. |
From tk@giga.or.atOn Wed, Nov 15, 2017 at 08:15:52AM -0800, James E Keenan via RT wrote:
I think there is a misunderstanding here. The second test passes fine for me. The first test fails. From the test output above:
And when you look at the 'Failed test' lines you see that they |
From zefram@fysh.orgBoth tests pass for me, on perl 5.26.1 with Carp 1.42 on amd64 Linux. -zefram |
From @eserteDana Wed, 15 Nov 2017 21:04:24 -0800, zefram@fysh.org reče:
NetBSD's perl is patched. See ftp://ftp.netbsd.org/pub/pkgsrc/current/pkgsrc/lang/perl5/patches/ and especially ftp://ftp.netbsd.org/pub/pkgsrc/current/pkgsrc/lang/perl5/patches/patch-dist_Carp_lib_Carp.pm Regards, |
From zefram@fysh.orgslaven@rezic.de via RT wrote:
Aha! Applying that patch makes the test case fail for me, both on 5.26.1 It looks like the patch is derived from a patch for an older version No bug relevant to p5p. -zefram |
From @xsawyerxOn 11/16/2017 08:36 AM, slaven@rezic.de via RT wrote:
Does anyone know the Perl porters in NetBSD? :) |
From tk@giga.or.atOn Thu, Nov 16, 2017 at 01:41:25AM -0800, Sawyer X via RT wrote:
I can remove the patch from perl in pkgsrc. Is there a better version available, or should it just be removed |
From zefram@fysh.orgThomas Klausner wrote:
It would best be removed without replacement. It is not a successful -zefram |
@xsawyerx - Status changed from 'open' to 'rejected' |
From @xsawyerxOn 11/16/2017 11:22 AM, Zefram wrote:
Thank you everyone. I'm marking the ticket as rejected. |
Migrated from rt.perl.org#132448 (status was 'rejected')
Searchable as RT132448$
The text was updated successfully, but these errors were encountered: