New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Multiconcat breaks AIX builds #16239
Comments
From @khwilliamsonThis is a bug report for perl from khw@cpan.org, AIX builds are giving assertion failures since multiconcat, like "../../miniperl" "-I../../lib" Functions_pm.PL This is happening even with ilmari's patch applied A bisect did not give perfect results, but I believe it to be Add OP_MULTICONCAT op Flags: Site configuration information for perl 5.27.6: Configured by khw at Sat Nov 11 06:08:38 MET 2017. Summary of my perl5 (revision 5 version 27 subversion 6) configuration: @INC for perl 5.27.6: Environment for perl 5.27.6: PATH=/perl/usr/khw/bin:/bin:/usr/local/ppc64/bin:/usr/bin:/etc:/usr/sbin:/pro/local/bin:/pro/bin:/usr/local/bin:/usr/vac/bin:/usr/local/sbin:/usr/ucb:/usr/bin/X11:/sbin:/usr/java14/jre/bin:/usr/java14/bin |
From @khwilliamsonI verified that the recent fix That is, this problem persists after this commit is applied. |
The RT System itself - Status changed from 'new' to 'open' |
From @iabynOn Fri, Nov 10, 2017 at 09:51:25PM -0800, karl williamson wrote:
Do you have a link to the smoke report, and/or the commit which this -- |
From @khwilliamsonOn 11/13/2017 09:24 AM, Dave Mitchell wrote:
It was today's blead as of b6f3718 #define Copy(s,d,n,t) (MEM_WRAP_CHECK_(n,t) perl_assert_ptr(d), And looking at that makes me wonder what the point of perl_assert_ptr() #define perl_assert_ptr(p) assert( ((void*)(p)) != 0 ) Why is the cast necessary? and if it is then why doesn't proto.h use assert(p) |
From @demerphqOn 13 Nov 2017 17:46, "Karl Williamson" <public@khwilliamson.com> wrote: On 11/13/2017 09:24 AM, Dave Mitchell wrote:
It was today's blead as of b6f3718 #define Copy(s,d,n,t) (MEM_WRAP_CHECK_(n,t) perl_assert_ptr(d), And looking at that makes me wonder what the point of perl_assert_ptr() #define perl_assert_ptr(p) assert( ((void*)(p)) != 0 ) Why is the cast necessary? It's a portability fix. I forget the details but this was a Zefram And if it is then why doesn't proto.h use this formulation? Instead it uses assert(p) Probably because the other macro is new and we haven't encountered the core Yves |
From @demerphqOn 13 Nov 2017 17:52, "demerphq" <demerphq@gmail.com> wrote: On 13 Nov 2017 17:46, "Karl Williamson" <public@khwilliamson.com> wrote: On 11/13/2017 09:24 AM, Dave Mitchell wrote:
It was today's blead as of b6f3718 #define Copy(s,d,n,t) (MEM_WRAP_CHECK_(n,t) perl_assert_ptr(d), And looking at that makes me wonder what the point of perl_assert_ptr() #define perl_assert_ptr(p) assert( ((void*)(p)) != 0 ) Why is the cast necessary? It's a portability fix. I forget the details but this was a Zefram See the thread "New assert()s in handy.h cause annoying warnings" The problem is that the simple assert form throws warnings about always Yves |
From @iabynOn Mon, Nov 13, 2017 at 09:45:29AM -0700, Karl Williamson wrote:
Now fixed with commit 6623aa6 OP_MULTICONCAT: fix AIX M op.c -- |
From @khwilliamsonI confirmed that AIX now builds. so am resolving this ticket |
@khwilliamson - Status changed from 'open' to 'resolved' |
From @xsawyerxOn 11/13/2017 05:52 PM, demerphq wrote:
Hey Yves, Any chance we could add documentation in the code explaining the reason Also, shouldn't this macro be uppercase? Thanks! |
Migrated from rt.perl.org#132430 (status was 'resolved')
Searchable as RT132430$
The text was updated successfully, but these errors were encountered: