New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bleadperl breaks Data-Printer-0.39 #16096
Comments
From @jkeenanData-Printer-0.39 is failing on blead perl. Carlos Guevara called my http://fast-matrix.cpantesters.org/?dist=Data-Printer;os=freebsd;perl=5.27.3;reports=1. They persist as of commit 1fb2d10, ##### # Failed test 'tied hash contains tied message' Test Summary Report t/19-tied.t (Wstat: 256 Tests: 13 Failed: 1) Not bisected, but damage occurred since July 21. |
From @jkeenanSummary of my perl5 (revision 5 version 27 subversion 3) configuration: Characteristics of this binary (from libperl): |
From @jkeenanOn Tue, 01 Aug 2017 00:09:32 GMT, jkeenan@pobox.com wrote:
Data-Printer was doing fine as of 0283ad9, so the breakage probably occurred during the large merge on July 27. -- |
The RT System itself - Status changed from 'new' to 'open' |
From @jkeenanOn Tue, 01 Aug 2017 00:19:35 GMT, jkeenan wrote:
This can be reduced to the program attached. Run with perl-5.26.0 or at commit 0283ad9 (before the MERGE), it produces: ##### Run at, say, commit 1fb2d10 (after the MERGE), it produces: ##### Thank you very much. -- |
From @iabynOn Mon, Jul 31, 2017 at 06:40:19PM -0700, James E Keenan via RT wrote:
Thanks for the reduction. It fails because the test file t/19-tied.t has Reducing it further to sub TIEHASH { bless { test => 1} } sub FIRSTKEY { sub NEXTKEY { sub SCALAR { } my %var; produces this output with 5.27.2: NOT EMPTY (via keys test) and produces no output on blead, because 'scalar(keys %tied)' in boolean A look on grep.cpan.me shows 3 distributions that have an empty SCALAR Data-Printer-0.39/t/19-tied.t -- |
From @jkeenanOn Tue, 01 Aug 2017 07:48:24 GMT, davem wrote:
So this is a case where "CPAN had suboptimal code and blead came along and understandably broke it." What is the fix which we should recommend to the CPAN maintainers? -- |
From zefram@fysh.orgJames E Keenan via RT wrote:
CPAN was doing something that might have permitted and blead made it
Delete the empty SCALAR method. This (or any other fix acceptable to -zefram |
From @jkeenanOn Tue, 01 Aug 2017 07:48:24 GMT, davem wrote:
Tie-TinyURL fails tests against Perl 5 blead (v5.27.2-87-gdf84d7b) -- but the failures occur whether or not I comment out 'sub SCALAR {}'.
HTML-Template-Pro tests and installs successfully against Perl 5 blead. (Of course, it may be the case that its test suite doesn't touch 'sub SCALAR {}'.) Thank you very much. -- |
From @garuData-Printer 0.40 was just pushed to CPAN with the fix. Works on my blead now :) Many thanks to Jim, Dave and Zefram for finding and debugging this. Cheers! garu On Tue, 01 Aug 2017 07:05:53 -0700, zefram@fysh.org wrote:
|
From @jkeenanOn Wed, 02 Aug 2017 01:16:54 GMT, garu wrote:
Confirmed. ##### Marking ticket Resolved. Thank you very much. |
@jkeenan - Status changed from 'open' to 'resolved' |
From @iabynOn Tue, Aug 01, 2017 at 03:07:49PM -0700, James E Keenan via RT wrote:
It also fails against 5.27.2, so it isn't a regression. -- |
From @jkeenanOn Fri, 04 Aug 2017 11:30:43 GMT, davem wrote:
Agreed. The APIs used in the test file have probably changed since the tests were originally written. So not relevant to the subject of this RT. |
Migrated from rt.perl.org#131824 (status was 'resolved')
Searchable as RT131824$
The text was updated successfully, but these errors were encountered: