New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[PATCH] allow make
to succeed when builddir path contains spaces
#16071
Comments
From @ptolemarchCreated by @ptolemarchAt the moment, it's not possible to build perl in a directory, in Unix, The proximate problem is that `mkppport` fails. What seems to be This small patch removes the step in `mkppport` that adds these extra Perl Info
|
From @ptolemarch0001-which_perl-already-adds-quotes-when-necessary.patchFrom cf97c377205803ee78d48e1136251131670c2563 Mon Sep 17 00:00:00 2001
From: David Hand <davidhand@davidhand.com>
Date: Fri, 30 Jun 2017 18:26:26 -0400
Subject: [PATCH] which_perl() already adds quotes when necessary
`mkppport` needs the path to the perl binary to be build, which it gets
from the `which_perl()` subroutine from `MakeMaker::Test::Utils`. This
subroutine already checks for spaces and conditionally wraps the path in
quotes. Doing it twice effectively undoes the quoting.
This patch should enable `make` to succeed even if path to the build
directory contains spaces.
---
mkppport | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mkppport b/mkppport
index 9f4fd75a4a..d334fb994a 100644
--- a/mkppport
+++ b/mkppport
@@ -137,7 +137,7 @@ sub readlist
sub run
{
my @args = ("-I" . File::Spec->catdir((File::Spec->updir) x 2, 'lib'), @_);
- my $run = $perl =~ m/\s/ ? qq("$perl") : $perl;
+ my $run = $perl;
for (@args) {
$_ = qq("$_") if $^O eq 'VMS' && /^[^"]/;
$run .= " $_";
--
2.11.0
|
From @jkeenanOn Sun, 09 Jul 2017 06:09:04 GMT, davidhand@davidhand.com wrote:
I have a feeling that this has been proposed before, but have not been able to locate the relevant RT number. Does anyone recall that? Thank you very much. -- |
The RT System itself - Status changed from 'new' to 'open' |
From @jkeenanOn Sun, 09 Jul 2017 15:04:17 GMT, jkeenan wrote:
http://www.nntp.perl.org/group/perl.perl5.porters/2014/10/msg221337.html http://www.nntp.perl.org/group/perl.perl5.porters/2015/08/msg229692.html -- |
From @jkeenanOn Mon, 10 Jul 2017 01:58:02 GMT, jkeenan wrote:
Upon further inspection, the thread above appears not to be relevant.
-- |
From @jkeenanOn Mon, 10 Jul 2017 02:03:30 GMT, jkeenan wrote:
This RT may also be relevant: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=129152 -- |
Migrated from rt.perl.org#131723 (status was 'open')
Searchable as RT131723$
The text was updated successfully, but these errors were encountered: