Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong bracket type in perlre.pod #16027

Closed
p5pRT opened this issue Jun 19, 2017 · 6 comments
Closed

Wrong bracket type in perlre.pod #16027

p5pRT opened this issue Jun 19, 2017 · 6 comments
Labels
distro-Linux documentation

Comments

@p5pRT
Copy link

p5pRT commented Jun 19, 2017

Migrated from rt.perl.org#131603 (status was 'resolved')

Searchable as RT131603$
@p5pRT
Copy link
Author

p5pRT commented Jun 19, 2017

From choroba@matfyz.cz

Created by choroba@matfyz.cz

In perlre.pod where /x is explained, "(?​:" is decomposed into "{",
"?", and "​:", i.e. the first character is wrong.

Patch attached.

Ch.

Perl Info 

Flags:
     category=docs
     severity=low

This perlbug was built using Perl 5.18.2 - Tue Oct 18 09:56:00 UTC 2016
It is being executed now by  Perl 5.18.2 - Tue Oct 18 09:53:40 UTC 2016.

Site configuration information for perl 5.18.2:

Configured by abuild at Tue Oct 18 09:53:40 UTC 2016.

Summary of my perl5 (revision 5 version 18 subversion 2) configuration:

   Platform:
     osname=linux, osvers=4.4.24-1-default, archname=x86_64-linux-thread-multi
     uname='linux lamb01 4.4.24-1-default #1 smp wed oct 12 14:23:39 utc 2016 (1288c77) x86_64 x86_64 x86_64 gnulinux '
     config_args='-ds -e -Dprefix=/usr -Dvendorprefix=/usr -Dinstallusrbinperl -Dusethreads -Di_db -Di_dbm -Di_ndbm -Di_gdbm -Dd_dbm_open -Duseshrplib=true -Doptimize=-fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -Wall -pipe -Accflags=-DPERL_USE_SAFE_PUTENV -Dotherlibdirs=/usr/lib/perl5/site_perl -Dinc_version_list=5.18.0/x86_64-linux-thread-multi 5.18.0 5.18.1/x86_64-linux-thread-multi 5.18.1'
     hint=recommended, useposix=true, d_sigaction=define
     useithreads=define, usemultiplicity=define
     useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
     use64bitint=define, use64bitall=define, uselongdouble=undef
     usemymalloc=n, bincompat5005=undef
   Compiler:
     cc='cc', ccflags ='-D_REENTRANT -D_GNU_SOURCE -DPERL_USE_SAFE_PUTENV -fno-strict-aliasing -pipe -fstack-protector -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64',
     optimize='-fmessage-length=0 -grecord-gcc-switches -O2 -Wall -D_FORTIFY_SOURCE=2 -fstack-protector -funwind-tables -fasynchronous-unwind-tables -g -Wall -pipe',
     cppflags='-D_REENTRANT -D_GNU_SOURCE -DPERL_USE_SAFE_PUTENV -fno-strict-aliasing -pipe -fstack-protector'
     ccversion='', gccversion='4.8.5', gccosandvers=''
     intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
     d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
     ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
     alignbytes=8, prototype=define
   Linker and Libraries:
     ld='cc', ldflags =' -L/usr/local/lib64 -fstack-protector'
     libpth=/lib64 /usr/lib64 /usr/local/lib64
     libs=-lm -ldl -lcrypt -lpthread
     perllibs=-lm -ldl -lcrypt -lpthread
     libc=/lib64/libc-2.22.so, so=so, useshrplib=true, libperl=libperl.so
     gnulibc_version='2.22'
   Dynamic Linking:
     dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E -Wl,-rpath,/usr/lib/perl5/5.18.2/x86_64-linux-thread-multi/CORE'
     cccdlflags='-fPIC', lddlflags='-shared -L/usr/local/lib64 -fstack-protector'

Locally applied patches:



@INC for perl 5.18.2:
     /home/choroba/perl5/lib/perl5/5.18.2/x86_64-linux-thread-multi
     /home/choroba/perl5/lib/perl5/5.18.2
     /home/choroba/perl5/lib/perl5/x86_64-linux-thread-multi
     /home/choroba/perl5/lib/perl5
     /usr/lib/perl5/site_perl/5.18.2/x86_64-linux-thread-multi
     /usr/lib/perl5/site_perl/5.18.2
     /usr/lib/perl5/vendor_perl/5.18.2/x86_64-linux-thread-multi
     /usr/lib/perl5/vendor_perl/5.18.2
     /usr/lib/perl5/5.18.2/x86_64-linux-thread-multi
     /usr/lib/perl5/5.18.2
     /usr/lib/perl5/site_perl


Environment for perl 5.18.2:
     HOME=/home/choroba
     LANG=en_US.utf8
     LANGUAGE (unset)
     LC_CTYPE=en_US.UTF-8
     LD_LIBRARY_PATH (unset)
     LOGDIR (unset)
     PATH=/home/choroba/bin:/usr/local/bin:/usr/bin:/bin:/usr/bin/X11:/home/choroba/perl5/bin:.
     PERL5LIB=/home/choroba/perl5/lib/perl5
     PERL_BADLANG (unset)
     PERL_LOCAL_LIB_ROOT=/home/choroba/perl5
     PERL_MB_OPT=--install_base "/home/choroba/perl5"
     PERL_MM_OPT=INSTALL_BASE=/home/choroba/perl5
     SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Jun 19, 2017

From choroba@matfyz.cz

diff --git a/pod/perlre.pod b/pod/perlre.pod
index 57a98e4466..9cab16e223 100644
--- a/pod/perlre.pod
+++ b/pod/perlre.pod
@​@​ -505,7 +505,7 @​@​ a C<\Q...\E> stays unaffected by C</x>. And note that C</x> doesn't affect
space interpretation within a single multi-character construct. For
example in C<\x{...}>, regardless of the C</x> modifier, there can be no
spaces. Same for a L<quantifier|/Quantifiers> such as C<{3}> or
-C<{5,}>. Similarly, C<(?​:...)> can't have a space between the C<"{">,
+C<{5,}>. Similarly, C<(?​:...)> can't have a space between the C<"(">,
C<"?">, and C<"​:">. Within any delimiters for such a
construct, allowed spaces are not affected by C</x>, and depend on the
construct. For example, C<\x{...}> can't have spaces because hexadecimal

@p5pRT
Copy link
Author

p5pRT commented Jun 20, 2017

From @jkeenan

On Mon, 19 Jun 2017 13​:28​:06 GMT, choroba@​matfyz.cz wrote​:

This is a bug report for perl from choroba@​matfyz.cz,
generated with the help of perlbug 1.39 running under perl 5.18.2.

-----------------------------------------------------------------
[Please describe your issue here]

In perlre.pod where /x is explained, "(?​:" is decomposed into "{",
"?", and "​:", i.e. the first character is wrong.

Patch attached.

Ch.

Applied to blead in commit b7f3661. The patch did not apply cleanly because surrounding code has changed. So I had to type it manually. Please double check that I have done so correctly and that the results are as intended.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Jun 20, 2017

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Jun 21, 2017

From choroba@matfyz.cz

I used perlbug from 5.18 to create the report, but the page was created against a fresh blead. The previous change in perlre.pod happend in March, so I don't see how the patch could have been uncleanly applied. Nevertheless, the change seems OK.

Ch.

On Mon, 19 Jun 2017 19​:17​:37 -0700, jkeenan wrote​:

On Mon, 19 Jun 2017 13​:28​:06 GMT, choroba@​matfyz.cz wrote​:

This is a bug report for perl from choroba@​matfyz.cz,
generated with the help of perlbug 1.39 running under perl 5.18.2.

-----------------------------------------------------------------
[Please describe your issue here]

In perlre.pod where /x is explained, "(?​:" is decomposed into "{",
"?", and "​:", i.e. the first character is wrong.

Patch attached.

Ch.

Applied to blead in commit b7f3661.
The patch did not apply cleanly because surrounding code has changed.
So I had to type it manually. Please double check that I have done so
correctly and that the results are as intended.

Thank you very much.

@p5pRT
Copy link
Author

p5pRT commented Jun 22, 2017

@jkeenan - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Jun 22, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-Linux documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT