Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bleadperl v5.25.8-47-gd1f8d421df breaks SPROUT/JE-0.066.tar.gz #15833

Closed
p5pRT opened this issue Jan 25, 2017 · 6 comments
Closed

Bleadperl v5.25.8-47-gd1f8d421df breaks SPROUT/JE-0.066.tar.gz #15833

p5pRT opened this issue Jan 25, 2017 · 6 comments

Comments

@p5pRT
Copy link

p5pRT commented Jan 25, 2017

Migrated from rt.perl.org#130640 (status was 'resolved')

Searchable as RT130640$
@p5pRT
Copy link
Author

p5pRT commented Jan 25, 2017

From @andk

bisect

  d1f8d42 is the first bad commit
  commit d1f8d42
  Author​: Karl Williamson <khw@​cpan.org>
  Date​: Mon Dec 19 13​:25​:06 2016 -0700
 
  utf8.c​: Forbid zero-length malformation under DEBUGGING
 
diagnostics

  Test Summary Report
  -------------------
  t/11.02-left-expressions.t (Wstat​: 134 Tests​: 21 Failed​: 0)
  Non-zero wait status​: 134
  Parse errors​: Bad plan. You planned 37 tests but ran 21.
  t/11.04-unary.t (Wstat​: 134 Tests​: 14 Failed​: 0)
  Non-zero wait status​: 134
  Parse errors​: Bad plan. You planned 111 tests but ran 14.
  t/11.08-relational.t (Wstat​: 134 Tests​: 282 Failed​: 0)
  Non-zero wait status​: 134
  Parse errors​: Bad plan. You planned 284 tests but ran 282.
  t/15.01.03-uri-functions.t (Wstat​: 134 Tests​: 15 Failed​: 0)
  Non-zero wait status​: 134
  Parse errors​: Bad plan. You planned 106 tests but ran 15.
  t/15.01.02-global-functions.t (Wstat​: 134 Tests​: 2711 Failed​: 0)
  Non-zero wait status​: 134
  Parse errors​: Bad plan. You planned 3456 tests but ran 2711.
  t/15.10-regexp-objects.t (Wstat​: 134 Tests​: 156 Failed​: 0)
  Non-zero wait status​: 134
  Parse errors​: Bad plan. You planned 512 tests but ran 156.
  t/parse00-strings.t (Wstat​: 134 Tests​: 16 Failed​: 0)
  Non-zero wait status​: 134
  Parse errors​: Bad plan. You planned 18 tests but ran 16.
  Files=102, Tests=15376, 90 wallclock secs ( 1.72 usr 0.91 sys + 130.76 cusr 3.70 csys = 137.09 CPU)

perl -V

Summary of my perl5 (revision 5 version 25 subversion 9) configuration​:
  Commit id​: d1f8d42
  Platform​:
  osname=linux
  osvers=4.8.0-2-amd64
  archname=x86_64-linux-ld
  uname='linux k93msid 4.8.0-2-amd64 #1 smp debian 4.8.11-1 (2016-12-02) x86_64 gnulinux '
  config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.8-47-gd1f8d421df/0a29 -Dmyhostname=k93msid -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dlibswanted=cl pthread socket inet nsl gdbm dbm malloc dl ld sun m crypt sec util c cposix posix ucb BSD gdbm_compat -Uuseithreads -Duselongdouble -DDEBUGGING=both'
  hint=recommended
  useposix=true
  d_sigaction=define
  useithreads=undef
  usemultiplicity=undef
  use64bitint=define
  use64bitall=define
  uselongdouble=define
  usemymalloc=n
  bincompat5005=undef
  Compiler​:
  cc='cc'
  ccflags ='-fwrapv -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
  optimize='-O2 -g'
  cppflags='-fwrapv -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
  ccversion=''
  gccversion='6.2.1 20161124'
  gccosandvers=''
  intsize=4
  longsize=8
  ptrsize=8
  doublesize=8
  byteorder=12345678
  doublekind=3
  d_longlong=define
  longlongsize=8
  d_longdbl=define
  longdblsize=16
  longdblkind=3
  ivtype='long'
  ivsize=8
  nvtype='long double'
  nvsize=16
  Off_t='off_t'
  lseeksize=8
  alignbytes=16
  prototype=define
  Linker and Libraries​:
  ld='cc'
  ldflags =' -fstack-protector-strong -L/usr/local/lib'
  libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/6/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
  libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
  libc=libc-2.24.so
  so=so
  useshrplib=false
  libperl=libperl.a
  gnulibc_version='2.24'
  Dynamic Linking​:
  dlsrc=dl_dlopen.xs
  dlext=so
  d_dlsymun=undef
  ccdlflags='-Wl,-E'
  cccdlflags='-fPIC'
  lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
  Compile-time options​:
  DEBUGGING
  HAS_TIMES
  PERLIO_LAYERS
  PERL_COPY_ON_WRITE
  PERL_DONT_CREATE_GVSV
  PERL_MALLOC_WRAP
  PERL_OP_PARENT
  PERL_PRESERVE_IVUV
  PERL_USE_DEVEL
  USE_64_BIT_ALL
  USE_64_BIT_INT
  USE_LARGE_FILES
  USE_LOCALE
  USE_LOCALE_COLLATE
  USE_LOCALE_CTYPE
  USE_LOCALE_NUMERIC
  USE_LOCALE_TIME
  USE_LONG_DOUBLE
  USE_PERLIO
  USE_PERL_ATOF
  Built under linux
  Compiled at Jan 25 2017 09​:35​:57
  @​INC​:
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.8-47-gd1f8d421df/0a29/lib/site_perl/5.25.9/x86_64-linux-ld
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.8-47-gd1f8d421df/0a29/lib/site_perl/5.25.9
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.8-47-gd1f8d421df/0a29/lib/5.25.9/x86_64-linux-ld
  /home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.8-47-gd1f8d421df/0a29/lib/5.25.9
  .

--
andreas

@p5pRT
Copy link
Author

p5pRT commented Jan 26, 2017

From @khwilliamson

On 01/25/2017 03​:22 AM, (Andreas J. Koenig) (via RT) wrote​:

# New Ticket Created by (Andreas J. Koenig)
# Please include the string​: [perl #130640]
# in the subject line of all future correspondence about this issue.
# <URL​: https://rt-archive.perl.org/perl5/Ticket/Display.html?id=130640 >

bisect
------
d1f8d42 is the first bad commit
commit d1f8d42
Author​: Karl Williamson <khw@​cpan.org>
Date​: Mon Dec 19 13​:25​:06 2016 -0700

  utf8\.c&#8203;: Forbid zero\-length malformation under DEBUGGING

This appears to be as a result of an API change for which I'm
unapologetic. If you have nothing to decode, don't call the decoder.
Previously it resulted in the insertion of a NUL, which is probably not
what was wanted anyway.

diagnostics
-----------
Test Summary Report
-------------------
t/11.02-left-expressions.t (Wstat​: 134 Tests​: 21 Failed​: 0)
Non-zero wait status​: 134
Parse errors​: Bad plan. You planned 37 tests but ran 21.
t/11.04-unary.t (Wstat​: 134 Tests​: 14 Failed​: 0)
Non-zero wait status​: 134
Parse errors​: Bad plan. You planned 111 tests but ran 14.
t/11.08-relational.t (Wstat​: 134 Tests​: 282 Failed​: 0)
Non-zero wait status​: 134
Parse errors​: Bad plan. You planned 284 tests but ran 282.
t/15.01.03-uri-functions.t (Wstat​: 134 Tests​: 15 Failed​: 0)
Non-zero wait status​: 134
Parse errors​: Bad plan. You planned 106 tests but ran 15.
t/15.01.02-global-functions.t (Wstat​: 134 Tests​: 2711 Failed​: 0)
Non-zero wait status​: 134
Parse errors​: Bad plan. You planned 3456 tests but ran 2711.
t/15.10-regexp-objects.t (Wstat​: 134 Tests​: 156 Failed​: 0)
Non-zero wait status​: 134
Parse errors​: Bad plan. You planned 512 tests but ran 156.
t/parse00-strings.t (Wstat​: 134 Tests​: 16 Failed​: 0)
Non-zero wait status​: 134
Parse errors​: Bad plan. You planned 18 tests but ran 16.
Files=102, Tests=15376, 90 wallclock secs ( 1.72 usr 0.91 sys + 130.76 cusr 3.70 csys = 137.09 CPU)

perl -V
-------
Summary of my perl5 (revision 5 version 25 subversion 9) configuration​:
Commit id​: d1f8d42
Platform​:
osname=linux
osvers=4.8.0-2-amd64
archname=x86_64-linux-ld
uname='linux k93msid 4.8.0-2-amd64 #1 smp debian 4.8.11-1 (2016-12-02) x86_64 gnulinux '
config_args='-Dprefix=/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.8-47-gd1f8d421df/0a29 -Dmyhostname=k93msid -Dinstallusrbinperl=n -Uversiononly -Dusedevel -des -Ui_db -Dlibswanted=cl pthread socket inet nsl gdbm dbm malloc dl ld sun m crypt sec util c cposix posix ucb BSD gdbm_compat -Uuseithreads -Duselongdouble -DDEBUGGING=both'
hint=recommended
useposix=true
d_sigaction=define
useithreads=undef
usemultiplicity=undef
use64bitint=define
use64bitall=define
uselongdouble=define
usemymalloc=n
bincompat5005=undef
Compiler​:
cc='cc'
ccflags ='-fwrapv -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64'
optimize='-O2 -g'
cppflags='-fwrapv -DDEBUGGING -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
ccversion=''
gccversion='6.2.1 20161124'
gccosandvers=''
intsize=4
longsize=8
ptrsize=8
doublesize=8
byteorder=12345678
doublekind=3
d_longlong=define
longlongsize=8
d_longdbl=define
longdblsize=16
longdblkind=3
ivtype='long'
ivsize=8
nvtype='long double'
nvsize=16
Off_t='off_t'
lseeksize=8
alignbytes=16
prototype=define
Linker and Libraries​:
ld='cc'
ldflags =' -fstack-protector-strong -L/usr/local/lib'
libpth=/usr/local/lib /usr/lib/gcc/x86_64-linux-gnu/6/include-fixed /usr/include/x86_64-linux-gnu /usr/lib /lib/x86_64-linux-gnu /lib/../lib /usr/lib/x86_64-linux-gnu /usr/lib/../lib /lib
libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
libc=libc-2.24.so
so=so
useshrplib=false
libperl=libperl.a
gnulibc_version='2.24'
Dynamic Linking​:
dlsrc=dl_dlopen.xs
dlext=so
d_dlsymun=undef
ccdlflags='-Wl,-E'
cccdlflags='-fPIC'
lddlflags='-shared -O2 -g -L/usr/local/lib -fstack-protector-strong'

Characteristics of this binary (from libperl)​:
Compile-time options​:
DEBUGGING
HAS_TIMES
PERLIO_LAYERS
PERL_COPY_ON_WRITE
PERL_DONT_CREATE_GVSV
PERL_MALLOC_WRAP
PERL_OP_PARENT
PERL_PRESERVE_IVUV
PERL_USE_DEVEL
USE_64_BIT_ALL
USE_64_BIT_INT
USE_LARGE_FILES
USE_LOCALE
USE_LOCALE_COLLATE
USE_LOCALE_CTYPE
USE_LOCALE_NUMERIC
USE_LOCALE_TIME
USE_LONG_DOUBLE
USE_PERLIO
USE_PERL_ATOF
Built under linux
Compiled at Jan 25 2017 09​:35​:57
@​INC​:
/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.8-47-gd1f8d421df/0a29/lib/site_perl/5.25.9/x86_64-linux-ld
/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.8-47-gd1f8d421df/0a29/lib/site_perl/5.25.9
/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.8-47-gd1f8d421df/0a29/lib/5.25.9/x86_64-linux-ld
/home/sand/src/perl/repoperls/installed-perls/host/k93msid/v5.25.8-47-gd1f8d421df/0a29/lib/5.25.9
.

@p5pRT
Copy link
Author

p5pRT commented Jan 26, 2017

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Feb 21, 2017

From @tonycoz

On Thu, 26 Jan 2017 11​:46​:11 -0800, public@​khwilliamson.com wrote​:

This appears to be as a result of an API change for which I'm
unapologetic. If you have nothing to decode, don't call the decoder.
Previously it resulted in the insertion of a NUL, which is probably
not
what was wanted anyway.

This is partly fixed by aee9b91.

JE was seeing the assertion from calling ord().

Some tests still fail, but I don't think they're due to this change.

Tony

@p5pRT
Copy link
Author

p5pRT commented Mar 20, 2017

From @iabyn

On Mon, Feb 20, 2017 at 08​:04​:15PM -0800, Tony Cook via RT wrote​:

On Thu, 26 Jan 2017 11​:46​:11 -0800, public@​khwilliamson.com wrote​:

This appears to be as a result of an API change for which I'm
unapologetic. If you have nothing to decode, don't call the decoder.
Previously it resulted in the insertion of a NUL, which is probably
not
what was wanted anyway.

This is partly fixed by aee9b91.

JE was seeing the assertion from calling ord().

Some tests still fail, but I don't think they're due to this change.

I just tried with a threaded DEBUGGING blead, and all tests passed on
JE-0.066. So I'll close this ticket.

--
Never do today what you can put off till tomorrow.

@p5pRT p5pRT closed this as completed Mar 20, 2017
@p5pRT
Copy link
Author

p5pRT commented Mar 20, 2017

@iabyn - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT