[PATCH] Add prototypes for 6 mathoms to satisfy -Wmissing-prototypes #15816
Comments
From @petdanceCreated by @petdanceclang -Wmissing-prototypes has turned up these 6 functions that Perl Info |
From @petdance0001-Add-prototypes-for-6-functions-to-satisfy-Wmissing-p.patchFrom 347e62f88e069e6d10f54036400428f7f10f6fdd Mon Sep 17 00:00:00 2001
From: Andy Lester <andy@petdance.com>
Date: Sun, 15 Jan 2017 12:12:29 -0600
Subject: [PATCH] Add prototypes for 6 functions to satisfy
-Wmissing-prototypes
---
mathoms.c | 6 ++++++
1 file changed, 6 insertions(+)
diff --git a/mathoms.c b/mathoms.c
index 92cd77a..4916433 100644
--- a/mathoms.c
+++ b/mathoms.c
@@ -143,6 +143,7 @@ Perl_sv_2uv(pTHX_ SV *sv)
* this function provided for binary compatibility only
*/
+NV Perl_sv_2nv(pTHX_ SV *sv); /* prototype to pass -Wmissing-prototypes */
NV
Perl_sv_2nv(pTHX_ SV *sv)
{
@@ -154,6 +155,7 @@ Perl_sv_2nv(pTHX_ SV *sv)
* this function provided for binary compatibility only
*/
+char *Perl_sv_2pv(pTHX_ SV *sv, STRLEN *lp); /* prototype to pass -Wmissing-prototypes */
char *
Perl_sv_2pv(pTHX_ SV *sv, STRLEN *lp)
{
@@ -555,6 +557,7 @@ Perl_printf_nocontext(const char *format, ...)
* So it is in perl for (say) POSIX to use.
* Needed for SunOS with Sun's 'acc' for example.
*/
+NV Perl_huge(void); /* prototype to pass -Wmissing-prototypes */
NV
Perl_huge(void)
{
@@ -1073,6 +1076,7 @@ Perl_my_lstat(pTHX)
return my_lstat_flags(SV_GMAGIC);
}
+I32 Perl_sv_eq(pTHX_ SV *sv1, SV *sv2); /* prototype to pass -Wmissing-prototypes */
I32
Perl_sv_eq(pTHX_ SV *sv1, SV *sv2)
{
@@ -1080,6 +1084,7 @@ Perl_sv_eq(pTHX_ SV *sv1, SV *sv2)
}
#ifdef USE_LOCALE_COLLATE
+char * Perl_sv_collxfrm(pTHX_ SV *const sv, STRLEN *const nxp); /* prototype to pass -Wmissing-prototypes */
char *
Perl_sv_collxfrm(pTHX_ SV *const sv, STRLEN *const nxp)
{
@@ -1099,6 +1104,7 @@ Perl_mem_collxfrm(pTHX_ const char *input_string, STRLEN len, STRLEN *xlen)
#endif
+bool Perl_sv_2bool(pTHX_ SV *const sv); /* prototype to pass -Wmissing-prototype */
bool
Perl_sv_2bool(pTHX_ SV *const sv)
{
--
1.8.3.1
|
From @iabynOn Thu, Jan 19, 2017 at 09:06:43PM -0800, Andy Lester wrote:
Shouldn't instead those prototypes be automatically generated by adding -- |
|
The RT System itself - Status changed from 'new' to 'open' |
From @petdance
They're not in embed.fnc. I'm assuming that's because they're mathoms, only there for backward compatibility. -- |
From @iabynOn Sat, Jan 21, 2017 at 11:12:26AM -0600, Andy Lester wrote:
Then they need to have entries added to embed.fnc, like the other Apmb |IV |sv_2iv |NN SV *sv -- |
From @petdance
Thanks. I’ll close this ticket when I’ve done that. — |
From @petdanceThis has been closed and moved to 130717. |
|
@petdance - Status changed from 'open' to 'rejected' |
Migrated from rt.perl.org#130592 (status was 'rejected')
Searchable as RT130592$
The text was updated successfully, but these errors were encountered: