[PATCH] Test failures under DragonFly BSD #15800
Comments
From @xenuCreated by @xenuFollowing three tests fail under DragonFly BSD on blead: ../cpan/IO-Socket-IP/t/16v6only.t Basically, I had to add exclusions that are already in stat() tests fails because on UFS st_ctime and st_mtime sigaction tests fail because dfly doesn't set uid and pid IO::Socket::IP failure was reported to its maintainer[1]. PS. Last week I told Jim that I will setup dfly smoker. I [1] - https://rt.cpan.org/Ticket/Display.html?id=119780 (apologies if it's a duplicate, I forgot to add perlbug boilerplate Perl Info |
From @xenuThe patch is attached. |
From @xenu0001-perl-130534-fix-test-failures-under-DragonFly-BSD.patchFrom fecb6dd6cf97b2ad6374bcd3ffcf22a6b75e59f3 Mon Sep 17 00:00:00 2001
From: Tomasz Konojacki <me@xenu.pl>
Date: Tue, 10 Jan 2017 03:47:51 +0100
Subject: [PATCH] (perl #130534) fix test failures under DragonFly BSD
---
ext/POSIX/t/sigaction.t | 4 +++-
t/op/stat.t | 10 +++++-----
2 files changed, 8 insertions(+), 6 deletions(-)
diff --git a/ext/POSIX/t/sigaction.t b/ext/POSIX/t/sigaction.t
index ddcc021524..99bbb9f531 100644
--- a/ext/POSIX/t/sigaction.t
+++ b/ext/POSIX/t/sigaction.t
@@ -204,7 +204,9 @@ SKIP: {
||
($^O.$Config{osvers}) =~ /^openbsd[0-6]\./
||
- ($^O eq 'gnu'));
+ ($^O eq 'gnu')
+ ||
+ ($^O eq 'dragonfly'));
my $tests = keys %{{ %siginfo, %opt_val }};
eval 'use POSIX qw(SA_SIGINFO); SA_SIGINFO';
skip("no SA_SIGINFO", $tests) if $@;
diff --git a/t/op/stat.t b/t/op/stat.t
index 4df4ac7264..323c4982fc 100644
--- a/t/op/stat.t
+++ b/t/op/stat.t
@@ -43,10 +43,11 @@ $Is_Solaris = $^O eq 'solaris';
$Is_VMS = $^O eq 'VMS';
$Is_MPRAS = $^O =~ /svr4/ && -f '/etc/.relid';
$Is_Android = $^O =~ /android/;
+$Is_Dfly = $^O eq 'dragonfly';
$Is_Dosish = $Is_Dos || $Is_OS2 || $Is_MSWin32 || $Is_NetWare;
-$Is_UFS = $Is_Darwin && (() = `df -t ufs . 2>/dev/null`) == 2;
+$ufs_no_ctime = ($Is_Dfly || $Is_Darwin) && (() = `df -t ufs . 2>/dev/null`) == 2;
if ($Is_Cygwin && !is_miniperl) {
require Win32;
@@ -141,8 +142,7 @@ SKIP: {
# no ctime concept $ctime is ALWAYS == $mtime
# expect netware to be the same ...
skip "No ctime concept on this OS", 2
- if $Is_MSWin32 ||
- ($Is_Darwin && $Is_UFS);
+ if $Is_MSWin32 || $ufs_no_ctime;
if( !ok($mtime, 'hard link mtime') ||
!isnt($mtime, $ctime, 'hard link ctime != mtime') ) {
@@ -151,8 +151,8 @@ SKIP: {
# has this problem. Building on the ClearCase VOBS filesystem may also
# cause this failure.
#
-# Darwin's UFS doesn't have a ctime concept, and thus is expected to fail
-# this test.
+# Some UFS implementations don't have a ctime concept, and thus are
+# expected to fail this test.
DIAG
}
}
--
2.11.0
|
|
@khwilliamson - Status changed from 'new' to 'open' |
From @khwilliamsonThanks, Applied to blead as a4ea138 |
|
@khwilliamson - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release today of Perl 5.26.0, this and 210 other issues have been Perl 5.26.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
|
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#130534 (status was 'resolved')
Searchable as RT130534$
The text was updated successfully, but these errors were encountered: