Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Perl_rpeep(OP *): Assertion `oldop' failed (op.c:13829) #15745

Closed
p5pRT opened this issue Dec 3, 2016 · 7 comments
Closed

Perl_rpeep(OP *): Assertion `oldop' failed (op.c:13829) #15745

p5pRT opened this issue Dec 3, 2016 · 7 comments
Labels

Comments

@p5pRT
Copy link

p5pRT commented Dec 3, 2016

Migrated from rt.perl.org#130247 (status was 'resolved')

Searchable as RT130247$

@p5pRT
Copy link
Author

p5pRT commented Dec 3, 2016

From @geeknik

Triggered with Perl v5.25.7-26-g7332835.

./perl -e '0for()x0or(0)x0'
perl​: op.c​:13829​: void Perl_rpeep(OP *)​: Assertion `oldop' failed.
Aborted

@p5pRT
Copy link
Author

p5pRT commented Dec 5, 2016

From @hvds

On Fri, 02 Dec 2016 17​:28​:39 -0800, brian.carpenter@​gmail.com wrote​:

Triggered with Perl v5.25.7-26-g7332835.

./perl -e '0for()x0or(0)x0'
perl​: op.c​:13829​: void Perl_rpeep(OP *)​: Assertion `oldop' failed.
Aborted

This occurs during the optimization of "(...) x 0", and has been there since that optimization was first introduced​:

commit c57eecc
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Mon Oct 20 23​:29​:01 2014 -0700

  Optimise ($foo)x1 and ($foo)x0 in list cx

Hugo

@p5pRT
Copy link
Author

p5pRT commented Dec 5, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Dec 5, 2016

From @iabyn

On Mon, Dec 05, 2016 at 04​:17​:31AM -0800, Hugo van der Sanden via RT wrote​:

On Fri, 02 Dec 2016 17​:28​:39 -0800, brian.carpenter@​gmail.com wrote​:

Triggered with Perl v5.25.7-26-g7332835.

./perl -e '0for()x0or(0)x0'
perl​: op.c​:13829​: void Perl_rpeep(OP *)​: Assertion `oldop' failed.
Aborted

This occurs during the optimization of "(...) x 0", and has been there since that optimization was first introduced​:

commit c57eecc
Author​: Father Chrysostomos <sprout@​cpan.org>
Date​: Mon Oct 20 23​:29​:01 2014 -0700

Optimise \($foo\)x1 and \($foo\)x0 in list cx

Now fixed​:

commit 5aa240e
Author​: David Mitchell <davem@​iabyn.com>
AuthorDate​: Mon Dec 5 14​:54​:44 2016 +0000
Commit​: David Mitchell <davem@​iabyn.com>
CommitDate​: Mon Dec 5 14​:56​:43 2016 +0000

  assertion failure in ... or ((0) x 0))
 
  [perl #130247] Perl_rpeep(OP *)​: Assertion `oldop' failed
 
  the 'x 0' optimising code in rpeep didn't expect the repeat expression
  to occur on the op_other side of an op_next chain.

--
"But Sidley Park is already a picture, and a most amiable picture too.
The slopes are green and gentle. The trees are companionably grouped at
intervals that show them to advantage. The rill is a serpentine ribbon
unwound from the lake peaceably contained by meadows on which the right
amount of sheep are tastefully arranged." -- Lady Croom, "Arcadia"

@p5pRT
Copy link
Author

p5pRT commented Dec 5, 2016

@iabyn - Status changed from 'open' to 'pending release'

@p5pRT
Copy link
Author

p5pRT commented May 30, 2017

From @khwilliamson

Thank you for filing this report. You have helped make Perl better.

With the release today of Perl 5.26.0, this and 210 other issues have been
resolved.

Perl 5.26.0 may be downloaded via​:
https://metacpan.org/release/XSAWYERX/perl-5.26.0

If you find that the problem persists, feel free to reopen this ticket.

@p5pRT p5pRT closed this as completed May 30, 2017
@p5pRT
Copy link
Author

p5pRT commented May 30, 2017

@khwilliamson - Status changed from 'pending release' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant