Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[PATCH] Organize files in pod/.gitignore correctly #15736

Closed
p5pRT opened this issue Nov 28, 2016 · 5 comments
Closed

[PATCH] Organize files in pod/.gitignore correctly #15736

p5pRT opened this issue Nov 28, 2016 · 5 comments
Labels
distro-Linux type-core

Comments

@p5pRT
Copy link

p5pRT commented Nov 28, 2016

Migrated from rt.perl.org#130194 (status was 'resolved')

Searchable as RT130194$
@p5pRT
Copy link
Author

p5pRT commented Nov 28, 2016

From @petdance

Created by @petdance

The pod/.gitignore file has sections of files that should be ignored.
Three of the files are in the wrong section, in the architecture-specific
section instead of the generated-files section.

This changes no functionality, but may help future maintainers
from confusion.

Perl Info 

Flags:
    category=core
    severity=low
    Type=Patch
    PatchStatus=HasPatch

Site configuration information for perl 5.24.0:

Configured by andy at Sun Jun  5 23:28:46 CDT 2016.

Summary of my perl5 (revision 5 version 24 subversion 0) configuration:
   
  Platform:
    osname=linux, osvers=3.10.0-327.18.2.el7.x86_64, archname=x86_64-linux
    uname='linux clifford 3.10.0-327.18.2.el7.x86_64 #1 smp thu may 12 11:03:55 utc 2016 x86_64 x86_64 x86_64 gnulinux '
    config_args='-de -Dprefix=/home/andy/perl5/perlbrew/perls/perl-5.24.0 -Aeval:scriptdir=/home/andy/perl5/perlbrew/perls/perl-5.24.0/bin'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2',
    optimize='-O2',
    cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion='', gccversion='4.8.5 20150623 (Red Hat 4.8.5-4)', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib /lib/../lib64 /usr/lib/../lib64 /lib /lib64 /usr/lib64 /usr/local/lib64
    libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    libc=libc-2.17.so, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version='2.17'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'

Locally applied patches:
    Devel::PatchPerl 1.38


@INC for perl 5.24.0:
    /home/andy/perl5/perlbrew/perls/perl-5.24.0/lib/site_perl/5.24.0/x86_64-linux
    /home/andy/perl5/perlbrew/perls/perl-5.24.0/lib/site_perl/5.24.0
    /home/andy/perl5/perlbrew/perls/perl-5.24.0/lib/5.24.0/x86_64-linux
    /home/andy/perl5/perlbrew/perls/perl-5.24.0/lib/5.24.0
    .


Environment for perl 5.24.0:
    HOME=/home/andy
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/andy/perl5/perlbrew/bin:/home/andy/perl5/perlbrew/perls/perl-5.24.0/bin:/home/andy/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin
    PERLBREW_BASHRC_VERSION=0.75
    PERLBREW_HOME=/home/andy/.perlbrew
    PERLBREW_MANPATH=/home/andy/perl5/perlbrew/perls/perl-5.24.0/man
    PERLBREW_PATH=/home/andy/perl5/perlbrew/bin:/home/andy/perl5/perlbrew/perls/perl-5.24.0/bin
    PERLBREW_PERL=perl-5.24.0
    PERLBREW_ROOT=/home/andy/perl5/perlbrew
    PERLBREW_VERSION=0.75
    PERLCRITIC=/home/andy/tw/Dev/perlcriticrc
    PERL_BADLANG (unset)
    SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Nov 28, 2016

From @petdance

gitignore.patch 
diff --git a/pod/.gitignore b/pod/.gitignore
index 50e8685..874cc72 100644
--- a/pod/.gitignore
+++ b/pod/.gitignore
@@ -17,7 +17,6 @@
 /perllinux.pod
 /perlmacos.pod
 /perlmacosx.pod
-/perlmodlib.pod
 /perlnetware.pod
 /perlopenbsd.pod
 /perlos2.pod
@@ -29,10 +28,8 @@
 /perlsolaris.pod
 /perlsymbian.pod
 /perlsynology.pod
-/perltoc.pod
 /perltru64.pod
 /perltw.pod
-/perluniprops.pod
 /perlvms.pod
 /perlvos.pod
 /perlwin32.pod
@@ -56,6 +53,9 @@
 /perl5258delta.pod
 /perlapi.pod
 /perlintern.pod
+/perlmodlib.pod
+/perltoc.pod
+/perluniprops.pod
 *.html
 *.man
 /perlfunc/

@p5pRT
Copy link
Author

p5pRT commented Dec 3, 2016

From @jkeenan

On Mon, 28 Nov 2016 01​:45​:18 GMT, petdance wrote​:

This is a bug report for perl from andy@​petdance.com,
generated with the help of perlbug 1.40 running under perl 5.24.0.

-----------------------------------------------------------------
[Please describe your issue here]

The pod/.gitignore file has sections of files that should be ignored.
Three of the files are in the wrong section, in the architecture-
specific
section instead of the generated-files section.

This changes no functionality, but may help future maintainers
from confusion.

Thanks, applied in commit 9094660.

Please note​: If you can prepare your patch with 'git format-patch', you save the committer from having, for the most part, to compose the commit message. If you send a regular diff, the patch can be applied but then the committer has to make a (possibly incorrect) decision as to the content of the commit message.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Dec 3, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT p5pRT closed this as completed Dec 3, 2016
@p5pRT
Copy link
Author

p5pRT commented Dec 3, 2016

@jkeenan - Status changed from 'open' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
distro-Linux type-core
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@p5pRT