Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[PATCH] Internal cleanup in numeric.c, no functional changes #15636

Closed
p5pRT opened this issue Sep 30, 2016 · 13 comments
Closed

[PATCH] Internal cleanup in numeric.c, no functional changes #15636

p5pRT opened this issue Sep 30, 2016 · 13 comments

Comments

@p5pRT
Copy link

p5pRT commented Sep 30, 2016

Migrated from rt.perl.org#129766 (status was 'resolved')

Searchable as RT129766$

@p5pRT
Copy link
Author

p5pRT commented Sep 30, 2016

From @petdance

Created by @petdance

Minor internal cleanups in numeric.c

* Simplified some variable instantiation in Perl_my_atof, including
  removing some unnecessary initialization.
* Removed some unnecessary casting in Perl_my_atof2.
* Added consts to three other internal vars.

Perl Info

Flags:
    category=core
    severity=low
    Type=Patch
    PatchStatus=HasPatch

Site configuration information for perl 5.24.0:

Configured by andy at Sun Jun  5 23:28:46 CDT 2016.

Summary of my perl5 (revision 5 version 24 subversion 0) configuration:
   
  Platform:
    osname=linux, osvers=3.10.0-327.18.2.el7.x86_64, archname=x86_64-linux
    uname='linux clifford 3.10.0-327.18.2.el7.x86_64 #1 smp thu may 12 11:03:55 utc 2016 x86_64 x86_64 x86_64 gnulinux '
    config_args='-de -Dprefix=/home/andy/perl5/perlbrew/perls/perl-5.24.0 -Aeval:scriptdir=/home/andy/perl5/perlbrew/perls/perl-5.24.0/bin'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 -D_FORTIFY_SOURCE=2',
    optimize='-O2',
    cppflags='-fwrapv -fno-strict-aliasing -pipe -fstack-protector-strong -I/usr/local/include'
    ccversion='', gccversion='4.8.5 20150623 (Red Hat 4.8.5-4)', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678, doublekind=3
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16, longdblkind=3
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='cc', ldflags =' -fstack-protector-strong -L/usr/local/lib'
    libpth=/usr/local/lib /usr/lib /lib/../lib64 /usr/lib/../lib64 /lib /lib64 /usr/lib64 /usr/local/lib64
    libs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    perllibs=-lpthread -lnsl -ldl -lm -lcrypt -lutil -lc
    libc=libc-2.17.so, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version='2.17'
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E'
    cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack-protector-strong'

Locally applied patches:
    Devel::PatchPerl 1.38


@INC for perl 5.24.0:
    /home/andy/perl5/perlbrew/perls/perl-5.24.0/lib/site_perl/5.24.0/x86_64-linux
    /home/andy/perl5/perlbrew/perls/perl-5.24.0/lib/site_perl/5.24.0
    /home/andy/perl5/perlbrew/perls/perl-5.24.0/lib/5.24.0/x86_64-linux
    /home/andy/perl5/perlbrew/perls/perl-5.24.0/lib/5.24.0
    .


Environment for perl 5.24.0:
    HOME=/home/andy
    LANG=en_US.UTF-8
    LANGUAGE (unset)
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/andy/perl5/perlbrew/bin:/home/andy/perl5/perlbrew/perls/perl-5.24.0/bin:/home/andy/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/sbin:/usr/local/bin:/usr/bin:/usr/local/sbin:/usr/sbin
    PERLBREW_BASHRC_VERSION=0.75
    PERLBREW_HOME=/home/andy/.perlbrew
    PERLBREW_MANPATH=/home/andy/perl5/perlbrew/perls/perl-5.24.0/man
    PERLBREW_PATH=/home/andy/perl5/perlbrew/bin:/home/andy/perl5/perlbrew/perls/perl-5.24.0/bin
    PERLBREW_PERL=perl-5.24.0
    PERLBREW_ROOT=/home/andy/perl5/perlbrew
    PERLBREW_VERSION=0.75
    PERL_BADLANG (unset)
    SHELL=/bin/bash

@p5pRT
Copy link
Author

p5pRT commented Sep 30, 2016

From @petdance

const.patch
diff --git a/numeric.c b/numeric.c
index 0c73749..7e05966 100644
--- a/numeric.c
+++ b/numeric.c
@@ -1022,7 +1022,7 @@ Perl_grok_number_flags(pTHX_ const char *pv, STRLEN len, UV *valuep, U32 flags)
   if ((s + 2 < send) && strchr("inqs#", toFOLD(*s))) {
       /* Really detect inf/nan. Start at d, not s, since the above
        * code might have already consumed the "1." or "1". */
-      int infnan = Perl_grok_infnan(aTHX_ &d, send);
+      const int infnan = Perl_grok_infnan(aTHX_ &d, send);
       if ((infnan & IS_NUMBER_INFINITY)) {
           return (numtype | infnan); /* Keep sign for infinity. */
       }
@@ -1089,7 +1089,7 @@ Perl_grok_atoUV(const char *pv, UV *valptr, const char** endptr)
                 /* This could be unrolled like in grok_number(), but
                  * the expected uses of this are not speed-needy, and
                  * unlikely to need full 64-bitness. */
-                U8 digit = *s++ - '0';
+                const U8 digit = *s++ - '0';
                 if (val < uv_max_div_10 ||
                     (val == uv_max_div_10 && digit <= uv_max_mod_10)) {
                     val = val * 10 + digit;
@@ -1221,9 +1221,6 @@ Perl_my_atof(pTHX_ const char* s)
         DECLARATION_FOR_LC_NUMERIC_MANIPULATION;
         STORE_LC_NUMERIC_SET_TO_NEEDED();
         if (PL_numeric_radix_sv && IN_LC(LC_NUMERIC)) {
-            const char *standard = NULL, *local = NULL;
-            bool use_standard_radix;
-
             /* Look through the string for the first thing that looks like a
              * decimal point: either the value in the current locale or the
              * standard fallback of '.'. The one which appears earliest in the
@@ -1231,10 +1228,9 @@ Perl_my_atof(pTHX_ const char* s)
              * that we have to determine this beforehand because on some
              * systems, Perl_atof2 is just a wrapper around the system's atof.
              * */
-            standard = strchr(s, '.');
-            local = strstr(s, SvPV_nolen(PL_numeric_radix_sv));
-
-            use_standard_radix = standard && (!local || standard < local);
+            const char * const standard = strchr(s, '.');
+            const char * const local = strstr(s, SvPV_nolen(PL_numeric_radix_sv));
+            const bool use_standard_radix = standard && (!local || standard < local);
 
             if (use_standard_radix)
                 SET_NUMERIC_STANDARD();
@@ -1266,7 +1262,7 @@ S_my_atof_infnan(pTHX_ const char* s, bool negative, const char* send, NV* value
 {
     const char *p0 = negative ? s - 1 : s;
     const char *p = p0;
-    int infnan = grok_infnan(&p, send);
+    const int infnan = grok_infnan(&p, send);
     if (infnan && p != p0) {
         /* If we can generate inf/nan directly, let's do so. */
 #ifdef NV_INF
@@ -1428,9 +1424,9 @@ Perl_my_atof2(pTHX_ const char* orig, NV* value)
 
 #if defined(NV_INF) || defined(NV_NAN)
     {
-        const char* endp;
+        char* endp;
         if ((endp = S_my_atof_infnan(aTHX_ s, negative, send, value)))
-            return (char*)endp;
+            return endp;
     }
 #endif
 

@p5pRT
Copy link
Author

p5pRT commented Sep 30, 2016

From @jkeenan

On Fri Sep 30 10​:20​:48 2016, petdance wrote​:

This is a bug report for perl from andy@​petdance.com,
generated with the help of perlbug 1.40 running under perl 5.24.0.

-----------------------------------------------------------------
[Please describe your issue here]

Minor internal cleanups in numeric.c

* Simplified some variable instantiation in Perl_my_atof, including
removing some unnecessary initialization.
* Removed some unnecessary casting in Perl_my_atof2.
* Added consts to three other internal vars.

Now available for smoke-testing in branch​:

smoke-me/jkeenan/petdance/129766-numeric-c

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Sep 30, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Oct 1, 2016

From @jkeenan

On Fri Sep 30 12​:50​:17 2016, jkeenan wrote​:

On Fri Sep 30 10​:20​:48 2016, petdance wrote​:

This is a bug report for perl from andy@​petdance.com,
generated with the help of perlbug 1.40 running under perl 5.24.0.

-----------------------------------------------------------------
[Please describe your issue here]

Minor internal cleanups in numeric.c

* Simplified some variable instantiation in Perl_my_atof, including
removing some unnecessary initialization.
* Removed some unnecessary casting in Perl_my_atof2.
* Added consts to three other internal vars.

Now available for smoke-testing in branch​:

smoke-me/jkeenan/petdance/129766-numeric-c

The patch is failing to compile when you configure with '-Dcc=g++'.

See smoke reports at http​://perl.develop-help.com/?b=smoke-me%2Fjkeenan%2Fpetdance%2F129766-numeric-c

I have locally reproduced the same type of failures as reported by George's g++ smoke runs at the above link. When I call 'make', I very quickly start to get warnings like these​:

#####
In file included from perl.c​:37​:0​:
perl.h​:6950​:19​: warning​: anonymous type with no linkage used to declare variable ‘c
onst<anonymous union> PL_inf’ with linkage
INFNAN_NV_U8_DECL PL_inf;
  ^
perl.h​:6951​:19​: warning​: anonymous type with no linkage used to declare variable ‘c
onst<anonymous union> PL_nan’ with linkage
INFNAN_NV_U8_DECL PL_nan;
  ^
#####

Eventually, 'make' collapses with output like this​:

#####
$ tail -30 petdance-numeric-c-gpp.transcript |cat
INFNAN_NV_U8_DECL PL_nan;
  ^
rm -f ../../lib/auto/POSIX/POSIX.so
g++ -shared -O2 -L/usr/local/lib -fstack-protector-strong POSIX.o -o ../../lib/auto/POSIX/POSIX.so \
  -lm \
 
/usr/bin/ld​: POSIX.o​: relocation R_X86_64_PC32 against undefined symbol `PL_nan' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld​: final link failed​: Bad value
collect2​: error​: ld returned 1 exit status
Makefile​:478​: recipe for target '../../lib/auto/POSIX/POSIX.so' failed
make[1]​: *** [../../lib/auto/POSIX/POSIX.so] Error 1
make[1]​: Leaving directory '/home/jkeenan/gitwork/perl/ext/POSIX'
make[1]​: Entering directory '/home/jkeenan/gitwork/perl/ext/POSIX'
/home/jkeenan/gitwork/perl/ext/POSIX/../../miniperl "-I../../lib" -MExtUtils​::Command​::MM -e 'cp_nonempty' -- POSIX.bs ../../lib/auto/POSIX/POSIX.bs 644
rm -f ../../lib/auto/POSIX/POSIX.so
g++ -shared -O2 -L/usr/local/lib -fstack-protector-strong POSIX.o -o ../../lib/auto/POSIX/POSIX.so \
  -lm \
 
/usr/bin/ld​: POSIX.o​: relocation R_X86_64_PC32 against undefined symbol `PL_nan' can not be used when making a shared object; recompile with -fPIC
/usr/bin/ld​: final link failed​: Bad value
collect2​: error​: ld returned 1 exit status
Makefile​:478​: recipe for target '../../lib/auto/POSIX/POSIX.so' failed
make[1]​: *** [../../lib/auto/POSIX/POSIX.so] Error 1
make[1]​: Leaving directory '/home/jkeenan/gitwork/perl/ext/POSIX'
Unsuccessful make(ext/POSIX)​: code=512 at make_ext.pl line 569.
makefile​:600​: recipe for target 'lib/auto/POSIX/POSIX.so' failed
make​: *** [lib/auto/POSIX/POSIX.so] Error 25
#####

Transcripts available upon request, but these are easily reproducible.

OTOH, on FreeBSD-10.3, where clang is the default cc, 'make' and 'make test_harness' completed successfully.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Oct 1, 2016

From @jkeenan

On Sat Oct 01 06​:20​:14 2016, jkeenan wrote​:

On Fri Sep 30 12​:50​:17 2016, jkeenan wrote​:

On Fri Sep 30 10​:20​:48 2016, petdance wrote​:

This is a bug report for perl from andy@​petdance.com,
generated with the help of perlbug 1.40 running under perl 5.24.0.

-----------------------------------------------------------------
[Please describe your issue here]

Minor internal cleanups in numeric.c

* Simplified some variable instantiation in Perl_my_atof, including
removing some unnecessary initialization.
* Removed some unnecessary casting in Perl_my_atof2.
* Added consts to three other internal vars.

Now available for smoke-testing in branch​:

smoke-me/jkeenan/petdance/129766-numeric-c

The patch is failing to compile when you configure with '-Dcc=g++'.

See smoke reports at http​://perl.develop-help.com/?b=smoke-
me%2Fjkeenan%2Fpetdance%2F129766-numeric-c

I have locally reproduced the same type of failures as reported by
George's g++ smoke runs at the above link. When I call 'make', I very
quickly start to get warnings like these​:

#####
In file included from perl.c​:37​:0​:
perl.h​:6950​:19​: warning​: anonymous type with no linkage used to
declare variable ‘c
onst<anonymous union> PL_inf’ with linkage
INFNAN_NV_U8_DECL PL_inf;
^
perl.h​:6951​:19​: warning​: anonymous type with no linkage used to
declare variable ‘c
onst<anonymous union> PL_nan’ with linkage
INFNAN_NV_U8_DECL PL_nan;
^
#####

Eventually, 'make' collapses with output like this​:

#####
$ tail -30 petdance-numeric-c-gpp.transcript |cat
INFNAN_NV_U8_DECL PL_nan;
^
rm -f ../../lib/auto/POSIX/POSIX.so
g++ -shared -O2 -L/usr/local/lib -fstack-protector-strong POSIX.o -o
../../lib/auto/POSIX/POSIX.so \
-lm \

/usr/bin/ld​: POSIX.o​: relocation R_X86_64_PC32 against undefined
symbol `PL_nan' can not be used when making a shared object; recompile
with -fPIC
/usr/bin/ld​: final link failed​: Bad value
collect2​: error​: ld returned 1 exit status
Makefile​:478​: recipe for target '../../lib/auto/POSIX/POSIX.so' failed
make[1]​: *** [../../lib/auto/POSIX/POSIX.so] Error 1
make[1]​: Leaving directory '/home/jkeenan/gitwork/perl/ext/POSIX'
make[1]​: Entering directory '/home/jkeenan/gitwork/perl/ext/POSIX'
/home/jkeenan/gitwork/perl/ext/POSIX/../../miniperl "-I../../lib"
-MExtUtils​::Command​::MM -e 'cp_nonempty' -- POSIX.bs
../../lib/auto/POSIX/POSIX.bs 644
rm -f ../../lib/auto/POSIX/POSIX.so
g++ -shared -O2 -L/usr/local/lib -fstack-protector-strong POSIX.o -o
../../lib/auto/POSIX/POSIX.so \
-lm \

/usr/bin/ld​: POSIX.o​: relocation R_X86_64_PC32 against undefined
symbol `PL_nan' can not be used when making a shared object; recompile
with -fPIC
/usr/bin/ld​: final link failed​: Bad value
collect2​: error​: ld returned 1 exit status
Makefile​:478​: recipe for target '../../lib/auto/POSIX/POSIX.so' failed
make[1]​: *** [../../lib/auto/POSIX/POSIX.so] Error 1
make[1]​: Leaving directory '/home/jkeenan/gitwork/perl/ext/POSIX'
Unsuccessful make(ext/POSIX)​: code=512 at make_ext.pl line 569.
makefile​:600​: recipe for target 'lib/auto/POSIX/POSIX.so' failed
make​: *** [lib/auto/POSIX/POSIX.so] Error 25
#####

Transcripts available upon request, but these are easily reproducible.

OTOH, on FreeBSD-10.3, where clang is the default cc, 'make' and 'make
test_harness' completed successfully.

Possible false alarm!

To create a branch for smoke testing, I forked from blead at​:

#####
commit afabfeb
Author​: Jarkko Hietaniemi <jhi@​iki.fi>
AuthorDate​: Fri Sep 30 07​:35​:53 2016
Commit​: Jarkko Hietaniemi <jhi@​iki.fi>
CommitDate​: Fri Sep 30 08​:40​:28 2016

  vax-netbsd​: do not export inf/nan which we do not have
#####

blead is failing to compile where -Dcc=g++'. See, e.g.​: http​://perl.develop-help.com/raw/?id=195564

So the real problem is probably in blead, not in this branch.

Thank you very much.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Oct 1, 2016

From @jkeenan

On Sat Oct 01 06​:30​:40 2016, jkeenan wrote​:

On Sat Oct 01 06​:20​:14 2016, jkeenan wrote​:

On Fri Sep 30 12​:50​:17 2016, jkeenan wrote​:

On Fri Sep 30 10​:20​:48 2016, petdance wrote​:

This is a bug report for perl from andy@​petdance.com,
generated with the help of perlbug 1.40 running under perl
5.24.0.

-----------------------------------------------------------------
[Please describe your issue here]

Minor internal cleanups in numeric.c

* Simplified some variable instantiation in Perl_my_atof,
including
removing some unnecessary initialization.
* Removed some unnecessary casting in Perl_my_atof2.
* Added consts to three other internal vars.

Now available for smoke-testing in branch​:

smoke-me/jkeenan/petdance/129766-numeric-c

The patch is failing to compile when you configure with '-Dcc=g++'.

See smoke reports at http​://perl.develop-help.com/?b=smoke-
me%2Fjkeenan%2Fpetdance%2F129766-numeric-c

I have locally reproduced the same type of failures as reported by
George's g++ smoke runs at the above link. When I call 'make', I
very
quickly start to get warnings like these​:

#####
In file included from perl.c​:37​:0​:
perl.h​:6950​:19​: warning​: anonymous type with no linkage used to
declare variable ‘c
onst<anonymous union> PL_inf’ with linkage
INFNAN_NV_U8_DECL PL_inf;
^
perl.h​:6951​:19​: warning​: anonymous type with no linkage used to
declare variable ‘c
onst<anonymous union> PL_nan’ with linkage
INFNAN_NV_U8_DECL PL_nan;
^
#####

Eventually, 'make' collapses with output like this​:

#####
$ tail -30 petdance-numeric-c-gpp.transcript |cat
INFNAN_NV_U8_DECL PL_nan;
^
rm -f ../../lib/auto/POSIX/POSIX.so
g++ -shared -O2 -L/usr/local/lib -fstack-protector-strong POSIX.o
-o
../../lib/auto/POSIX/POSIX.so \
-lm \

/usr/bin/ld​: POSIX.o​: relocation R_X86_64_PC32 against undefined
symbol `PL_nan' can not be used when making a shared object;
recompile
with -fPIC
/usr/bin/ld​: final link failed​: Bad value
collect2​: error​: ld returned 1 exit status
Makefile​:478​: recipe for target '../../lib/auto/POSIX/POSIX.so'
failed
make[1]​: *** [../../lib/auto/POSIX/POSIX.so] Error 1
make[1]​: Leaving directory '/home/jkeenan/gitwork/perl/ext/POSIX'
make[1]​: Entering directory '/home/jkeenan/gitwork/perl/ext/POSIX'
/home/jkeenan/gitwork/perl/ext/POSIX/../../miniperl "-I../../lib"
-MExtUtils​::Command​::MM -e 'cp_nonempty' -- POSIX.bs
../../lib/auto/POSIX/POSIX.bs 644
rm -f ../../lib/auto/POSIX/POSIX.so
g++ -shared -O2 -L/usr/local/lib -fstack-protector-strong POSIX.o
-o
../../lib/auto/POSIX/POSIX.so \
-lm \

/usr/bin/ld​: POSIX.o​: relocation R_X86_64_PC32 against undefined
symbol `PL_nan' can not be used when making a shared object;
recompile
with -fPIC
/usr/bin/ld​: final link failed​: Bad value
collect2​: error​: ld returned 1 exit status
Makefile​:478​: recipe for target '../../lib/auto/POSIX/POSIX.so'
failed
make[1]​: *** [../../lib/auto/POSIX/POSIX.so] Error 1
make[1]​: Leaving directory '/home/jkeenan/gitwork/perl/ext/POSIX'
Unsuccessful make(ext/POSIX)​: code=512 at make_ext.pl line 569.
makefile​:600​: recipe for target 'lib/auto/POSIX/POSIX.so' failed
make​: *** [lib/auto/POSIX/POSIX.so] Error 25
#####

Transcripts available upon request, but these are easily
reproducible.

OTOH, on FreeBSD-10.3, where clang is the default cc, 'make' and
'make
test_harness' completed successfully.

Possible false alarm!

To create a branch for smoke testing, I forked from blead at​:

#####
commit afabfeb
Author​: Jarkko Hietaniemi <jhi@​iki.fi>
AuthorDate​: Fri Sep 30 07​:35​:53 2016
Commit​: Jarkko Hietaniemi <jhi@​iki.fi>
CommitDate​: Fri Sep 30 08​:40​:28 2016

vax-netbsd​: do not export inf/nan which we do not have
#####

blead is failing to compile where -Dcc=g++'. See, e.g.​:
http​://perl.develop-help.com/raw/?id=195564

So the real problem is probably in blead, not in this branch.

Thank you very much.

Blead was broken in commit afabfeb,
but repaired by Jarkko here​:

#####
commit 0879cd6
Author​: Jarkko Hietaniemi <jhi@​iki.fi>
AuthorDate​: Fri Sep 30 17​:18​:16 2016
Commit​: Jarkko Hietaniemi <jhi@​iki.fi>
CommitDate​: Sat Oct 1 09​:00​:15 2016

  PL_inf/PL_nan need different export with C++
 
  After the 9ee3aea, the old way worked with C++ for building
  the core, but then failed building the POSIX extension.
 
  (This change is about building with C++ after the 9ee3aea,
  even though that change was about ordering perl.h into a more
  logical order for vax-netbsd, or for any non-IEEE-754 platform.)
#####

So smoke-me/jkeenan/petdance/129766-numeric-c should now PASS when using '-Dcc=g++'. (I've confirmed that locally and hopefully smokers will confirm that as well.)

Thank you very much. We now return this RT to normal discussion.

--
James E Keenan (jkeenan@​cpan.org)

@p5pRT
Copy link
Author

p5pRT commented Oct 17, 2016

From @petdance

How long do patches typically need to simmer before getting applied?

@p5pRT
Copy link
Author

p5pRT commented Oct 17, 2016

From @khwilliamson

On 10/17/2016 08​:17 AM, Andy Lester via RT wrote​:

How long do patches typically need to simmer before getting applied?

---
via perlbug​: queue​: perl5 status​: open
https://rt-archive.perl.org/perl5/Ticket/Display.html?id=129766

There's no typical number. It depends on if someone has the tuits,
knowledge, and inclination to look at the patch. I waited 6 months
(half a development cycle) one time for a patch to be applied of mine,
and which blocked all progress in that area for me.

In your case, I think it got sidetracked by the other issue, and your
reminding us about it was the right thing to do, and should get it back
on the radar.

@p5pRT
Copy link
Author

p5pRT commented Oct 19, 2016

From @khwilliamson

Thanks, applied as 7eff3d3
--
Karl Williamson

@p5pRT
Copy link
Author

p5pRT commented Oct 19, 2016

@khwilliamson - Status changed from 'open' to 'pending release'

@p5pRT
Copy link
Author

p5pRT commented May 30, 2017

From @khwilliamson

Thank you for filing this report. You have helped make Perl better.

With the release today of Perl 5.26.0, this and 210 other issues have been
resolved.

Perl 5.26.0 may be downloaded via​:
https://metacpan.org/release/XSAWYERX/perl-5.26.0

If you find that the problem persists, feel free to reopen this ticket.

@p5pRT
Copy link
Author

p5pRT commented May 30, 2017

@khwilliamson - Status changed from 'pending release' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant