Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] update outdated man links for strlcat and strlcpy #15561

Closed
p5pRT opened this issue Aug 27, 2016 · 6 comments
Closed

[patch] update outdated man links for strlcat and strlcpy #15561

p5pRT opened this issue Aug 27, 2016 · 6 comments

Comments

@p5pRT
Copy link

p5pRT commented Aug 27, 2016

Migrated from rt.perl.org#129102 (status was 'resolved')

Searchable as RT129102$

@p5pRT
Copy link
Author

p5pRT commented Aug 27, 2016

From theo@math.ethz.ch

Created by theo@math.ethz.ch

In two comments of utils.c there are outdated links to the man
pages of strlcat(3) and strlcpy(3). OpenBSD recently migrated
these man pages to http​://man.openbsd.org/strlcat.3 and
http​://man.openbsd.org/strlcat.3 respectively.

Perl Info

Flags:
    category=core
    severity=low
    Type=Patch
    PatchStatus=HasPatch

Site configuration information for perl 5.20.3:

Configured by root at Thu Jan  1  0:00:00 UTC 1970.

Summary of my perl5 (revision 5 version 20 subversion 3) configuration:
   
  Platform:
    osname=openbsd, osvers=6.0, archname=amd64-openbsd
    uname='openbsd'
    config_args='-dsE -Dopenbsd_distribution=defined -Dccflags=-DNO_LOCALE_NUMERIC -DNO_LOCALE_COLLATE -Dmksymlinks'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='cc', ccflags ='-DNO_LOCALE_NUMERIC -DNO_LOCALE_COLLATE -fno-strict-aliasing -fno-delete-null-pointer-checks -pipe -fstack-protector -I/usr/local/include',
    optimize='-O2',
    cppflags='-DNO_LOCALE_NUMERIC -DNO_LOCALE_COLLATE -fno-strict-aliasing -fno-delete-null-pointer-checks -pipe -fstack-protector -I/usr/local/include'
    ccversion='', gccversion='4.2.1 20070719 ', gccosandvers='openbsd6.0'
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='cc', ldflags ='-Wl,-E  -fstack-protector -L/usr/local/lib'
    libpth=/usr/lib /usr/lib
    libs=-lpthread -lm -lc
    perllibs=-lpthread -lm -lc
    libc=/usr/lib/libc.so.88.0, so=so, useshrplib=true, libperl=libperl.so.17.1
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-R/usr/libdata/perl5/amd64-openbsd/5.20.3/CORE'
    cccdlflags='-DPIC -fPIC ', lddlflags='-shared -fPIC  -fstack-protector -L/usr/local/lib'



@INC for perl 5.20.3:
    lib
    /usr/local/libdata/perl5/site_perl/amd64-openbsd
    /usr/libdata/perl5/site_perl/amd64-openbsd
    /usr/local/libdata/perl5/site_perl
    /usr/libdata/perl5/site_perl
    /usr/libdata/perl5/amd64-openbsd/5.20.3
    /usr/local/libdata/perl5/amd64-openbsd/5.20.3
    /usr/libdata/perl5
    /usr/local/libdata/perl5


Environment for perl 5.20.3:
    HOME=/home/theo
    LANG (unset)
    LANGUAGE (unset)
    LC_CTYPE=en_US.UTF-8
    LD_LIBRARY_PATH (unset)
    LOGDIR (unset)
    PATH=/home/theo/bin:/bin:/sbin:/usr/bin:/usr/sbin:/usr/X11R6/bin:/usr/local/bin:/usr/local/sbin:/usr/games:.
    PERL_BADLANG (unset)
    SHELL=/bin/ksh

--------------1.40.perlbug
Content-Type: text/x-patch; name="0001-Update-outdated-man-links-for-strlcpy-and-strlcat.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename="0001-Update-outdated-man-links-for-strlcpy-and-strlcat.patch"

From 5c4a8fcb100310b5a4b26c7fa79c3beceee2078a Mon Sep 17 00:00:00 2001
From: Theo Buehler <theo@math.ethz.ch>
Date: Sat, 27 Aug 2016 03:36:28 +0200
Subject: [PATCH] Update outdated man links for strlcpy and strlcat.


 util.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/util.c b/util.c
index 069aca3..8bc34cc 100644
--- a/util.c
+++ b/util.c
@@ -5710,7 +5710,7 @@ C<src>.  If C<size> is smaller than the return, the excess was not appended.
 
 =cut
 
-Description stolen from http://www.openbsd.org/cgi-bin/man.cgi?query=strlcat
+Description stolen from http://man.openbsd.org/strlcat.3
 */
 #ifndef HAS_STRLCAT
 Size_t
@@ -5744,7 +5744,7 @@ succeeded.  If it is larger than C<size>, the excess was not copied.
 
 =cut
 
-Description stolen from http://www.openbsd.org/cgi-bin/man.cgi?query=strlcpy
+Description stolen from http://man.openbsd.org/strlcpy.3
 */
 #ifndef HAS_STRLCPY
 Size_t
-- 
2.9.3


--------------1.40.perlbug--

@p5pRT
Copy link
Author

p5pRT commented Sep 1, 2016

From @khwilliamson

Thanks, applied as b2a32b2
and 0baa827
--
Karl Williamson

@p5pRT
Copy link
Author

p5pRT commented Sep 1, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Sep 1, 2016

@khwilliamson - Status changed from 'open' to 'pending release'

@p5pRT
Copy link
Author

p5pRT commented May 30, 2017

From @khwilliamson

Thank you for filing this report. You have helped make Perl better.

With the release today of Perl 5.26.0, this and 210 other issues have been
resolved.

Perl 5.26.0 may be downloaded via​:
https://metacpan.org/release/XSAWYERX/perl-5.26.0

If you find that the problem persists, feel free to reopen this ticket.

@p5pRT
Copy link
Author

p5pRT commented May 30, 2017

@khwilliamson - Status changed from 'pending release' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant