Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small improvements for Hurd's hints #15521

Closed
p5pRT opened this issue Aug 15, 2016 · 8 comments
Closed

small improvements for Hurd's hints #15521

p5pRT opened this issue Aug 15, 2016 · 8 comments

Comments

@p5pRT
Copy link

p5pRT commented Aug 15, 2016

Migrated from rt.perl.org#128954 (status was 'resolved')

Searchable as RT128954$

@p5pRT
Copy link
Author

p5pRT commented Aug 15, 2016

From @jmdh

Please find attached two patches from one of the Debian Hurd maintainers, Pino Toscano. He says​:

"I have a couple of patches to improve Perl on Hurd​:

(a) hurd-malloc.diff
This enables the malloc wrap also on Hurd, as used on Linux already;
Perl's own test suite passed with it, and I see no reason to diverge
from=20the behaviour on Linux and kFreeBSD. I'm not sure whether it
affects the ABI though, so it might be safe only for the upcoming perl
5.24 in experimental (since that breaks the ABI anyway)

(b) hurd-glibc-version.diff
This improves the reporting of the GNU libc used, so it's shown in
`perl -V` (as libc= value, instead of the currently empty string).
"

@p5pRT
Copy link
Author

p5pRT commented Aug 15, 2016

From @jmdh

hurd-glibc-version.diff
--- a/hints/gnu.sh
+++ b/hints/gnu.sh
@@ -36,6 +36,32 @@
     ;;
 esac
 
+case "$libc" in
+'')
+# If you have glibc, then report the version for ./myconfig bug reporting.
+# (Configure doesn't need to know the specific version since it just uses
+# gcc to load the library for all tests.)
+# We don't use __GLIBC__ and  __GLIBC_MINOR__ because they
+# are insufficiently precise to distinguish things like
+# libc-2.0.6 and libc-2.0.7.
+    for p in $plibpth
+    do
+        for trylib in libc.so.0.3 libc.so
+        do
+            if $test -e $p/$trylib; then
+                libc=`ls -l $p/$trylib | awk '{print $NF}'`
+                if $test "X$libc" != X; then
+                    break
+                fi
+            fi
+        done
+        if $test "X$libc" != X; then
+            break
+        fi
+    done
+    ;;
+esac
+
 # Flags needed to produce shared libraries.
 lddlflags='-shared'
 

@p5pRT
Copy link
Author

p5pRT commented Aug 15, 2016

From @jmdh

hurd-malloc.diff
--- a/hints/gnu.sh
+++ b/hints/gnu.sh
@@ -11,6 +11,18 @@
 # Debian 4.0 puts ndbm in the -lgdbm_compat library.
 libswanted="$libswanted gdbm_compat"
 
+# malloc wrap works
+case "$usemallocwrap" in
+'') usemallocwrap='define' ;;
+esac
+
+# The system malloc() is about as fast and as frugal as perl's.
+# Since the system malloc() has been the default since at least
+# 5.001, we might as well leave it that way.  --AD  10 Jan 2002
+case "$usemymalloc" in
+'') usemymalloc='n' ;;
+esac
+
 case "$optimize" in
 '') optimize='-O2' ;;
 esac

@p5pRT
Copy link
Author

p5pRT commented Aug 18, 2016

From @tonycoz

On Mon Aug 15 16​:50​:02 2016, dom wrote​:

Please find attached two patches from one of the Debian Hurd
maintainers, Pino Toscano. He says​:

"I have a couple of patches to improve Perl on Hurd​:

Thanks, applied as fb9b5c7.

I wasn't able to test it, my old Hurd VM broke (sid, no surprise)
and a new VM ran into #826043.

Tony

@p5pRT
Copy link
Author

p5pRT commented Aug 18, 2016

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Aug 18, 2016

@tonycoz - Status changed from 'open' to 'pending release'

@p5pRT
Copy link
Author

p5pRT commented May 30, 2017

From @khwilliamson

Thank you for filing this report. You have helped make Perl better.

With the release today of Perl 5.26.0, this and 210 other issues have been
resolved.

Perl 5.26.0 may be downloaded via​:
https://metacpan.org/release/XSAWYERX/perl-5.26.0

If you find that the problem persists, feel free to reopen this ticket.

@p5pRT p5pRT closed this as completed May 30, 2017
@p5pRT
Copy link
Author

p5pRT commented May 30, 2017

@khwilliamson - Status changed from 'pending release' to 'resolved'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant