commit 15899733e changes SKIP to FAIL on Win32 in op/sprintf.t #15445
Comments
From @bulk88Created by @bulk88Blead perl on WinXP 32 bits with VC 2003. Git reverting commit "VAX: ------------------------------------------------------ Test Summary Report Perl Info |
From @dcollinsnThis refers to commit 1589973, specifically to this test: ->%.0g< >-0.0< >-0< >C99 standard mandates minus sign but C89 does not skip: MSWin32 VMS hpux:10.20 openbsd netbsd:1.5 irix darwin freebsd:4.9 android< But really this change: - } elsif ( Which makes the skip-by-os only work with a :version or :archname. The patch which I will attach momentarily restores the check for plain "OS". There's another issue as well, though. The problem commit tried to add support for skip-by-archname, and now skips certain tests for 'netbsd:vax-netbsd' - but what about 'netbsd:vax-netbsd-thread-multi'? I'll attach a second patch that fixes that. -- |
From @dcollinsn0001-RT-128630-t-op-sprintf-Fix-skip-by-os.patchFrom ee000efb35d066dfc1b0dba0798f6151d3768733 Mon Sep 17 00:00:00 2001
From: Dan Collins <dcollinsn@gmail.com>
Date: Fri, 15 Jul 2016 20:29:20 -0400
Subject: [PATCH 1/2] [RT #128630] t/op/sprintf: Fix skip by os
15899733e modified the search for skip by OS. Previously it would
accept 'OS:ver' or 'OS', where 'ver' was numeric. That commit
added, for example, 'netbsd:vax-netbsd', but removed support for
plain 'OS'. This restores that.
---
t/op/sprintf.t | 2 ++
1 file changed, 2 insertions(+)
diff --git a/t/op/sprintf.t b/t/op/sprintf.t
index 4aef466..8cd32ea 100644
--- a/t/op/sprintf.t
+++ b/t/op/sprintf.t
@@ -115,6 +115,8 @@ for (@tests) {
# >comment skip: all<
if ($os =~ /\ball\b/i) {
$skip = 1;
+ } elsif ($os =~ /\b$^O\b/i) {
+ $skip = 1;
} elsif ($os =~ /\b$^O(?::(\S+))\b/i) {
my $cond = $1;
if ($cond =~ m{^/(.+)/$}) {
--
2.8.1
|
From @dcollinsn0002-t-op-sprintf.t-Further-fix-os-archname-skip.patchFrom 3e12e4fe409a784a2b3534d231430d4d8f4efb9c Mon Sep 17 00:00:00 2001
From: Dan Collins <dcollinsn@gmail.com>
Date: Fri, 15 Jul 2016 20:42:10 -0400
Subject: [PATCH 2/2] t/op/sprintf.t: Further fix os:archname skip
The tests in t/op/sprintf.t can be skipped by os, os:ver, or
os:archname. However, if it is desired to skip a test on
netbsd:vax-netbsd, then that should also be skipped on the
other perl-specific "flavors" of that archname, such as
netbsd:vax-netbsd-thread-multi, or -64all, or -ld. This commit
checks if the skip command is the prefix of the archname in
config.sh rather than comparing strict equality.
---
t/op/sprintf.t | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/op/sprintf.t b/t/op/sprintf.t
index 8cd32ea..4c77f6b 100644
--- a/t/op/sprintf.t
+++ b/t/op/sprintf.t
@@ -132,7 +132,7 @@ for (@tests) {
$skip = $vsn ? ($osv <= $vsn ? 1 : 0) : 1;
} else {
# >comment skip: netbsd:vax-netbsd<
- $skip = $cond eq $archname;
+ $skip = $archname =~ /^$cond/;
}
}
$skip and $comment =~ s/$/, failure expected on $^O $osv $archname/;
--
2.8.1
|
|
The RT System itself - Status changed from 'new' to 'open' |
From @tonycozOn Fri Jul 15 17:49:18 2016, dcollinsn@gmail.com wrote:
Should the comment above that, and before the __END__ also be updated? Tony |
From @bulk88On Sun Jul 17 17:52:43 2016, tonyc wrote:
It wasn't fixed by 6151d43 On, SHA-1: 9648eab * Add epigraphs for 5.22.3-RC2 and 5.24.1-RC2 I get C:\perl521\src\win32>cd ..\t & perl harness -v op/sprintf.t & cd ..\win32 Test Summary Report op/sprintf.t (Wstat: 0 Tests: 550 Failed: 1) -- |
From @dcollinsnOn Mon Jul 25 16:50:22 2016, bulk88 wrote:
I agree with bulk88. These lines handle the skip logic for plain win32: 140 # >comment skip: netbsd:vax-netbsd< That test has a skip condition "MSWin32", but my windows perls have archnames like "archname=MSWin32-x64-multi-thread". I suggest that any fix regex match `$archname =~ /\b$cond\b/` or `$archname =~ /^$cond/` rather than relying on string equality. Copying/assigning to Jarkko, as he committed 6151d43 -- |
From @jhiOn Mon Jul 25 17:07:03 2016, dcollinsn@gmail.com wrote:
Before tweaking any further I would like to understand how the mswin32 case matched before the 1589973. |
From @dcollinsnBefore, it used $^O instead of $archname. Come to think of it, that is also W:\buildbot\windows1\win64-mingww64-4_9_3\build>.\perl -Ilib -MConfig -wle On Mon, Jul 25, 2016 at 8:54 PM, Jarkko Hietaniemi via RT <
|
From @cpansproutDoes dbdc20d fix this? -- Father Chrysostomos |
From @bulk88On Fri Jul 29 00:27:33 2016, sprout wrote:
Probably that commit fixed it. Blead at Revision: c7202de passes in sprintf.t for me now so I think this ticket can be closed. -- |
From @khwilliamsonClosed by OP request |
|
@khwilliamson - Status changed from 'open' to 'resolved' |
Migrated from rt.perl.org#128630 (status was 'resolved')
Searchable as RT128630$
The text was updated successfully, but these errors were encountered: