'Masks earlier declaration' warning move from misc to syntax #14735
Comments
From @epaCreated by @epaPerl has a compile-time warning "my" variable $x masks earlier declaration in same scope I had hoped this to be under the 'syntax' warning category, but it is Thus: % perl -e 'use warnings FATAL => "syntax"; my $x; my $x' && echo yes Is it possible this warning could migrate from the 'misc' category to If that is not possible, could 'misc' have a subdivision in the Or conceivably, a new top-level category 'compile_time' or 'static' Perl Info |
From zefram@fysh.orgEd Avis wrote:
It's not a syntax issue. It's semantic. But your desire to distinguish -zefram |
|
The RT System itself - Status changed from 'new' to 'open' |
From @epaZefram <zefram <at> fysh.org> writes:
That would help. But further, both 'shadow' and 'syntax' could move under -- |
From @jkeenanOn Thu Jun 04 23:56:06 2015, eda@waniasset.com wrote:
There's been no further discussion in this RT in six months. That suggests to me that there's no compelling reason to revising the structure of our diagnostics. I'm taking the ticket for the purpose of closing it within 7 days unless there is a strong reason to keep it open. Thank you very much. -- |
From @epaIs it possible to implement Zefram's suggestion?
|
From @epaThe attached patch makes a new warnings category 'shadow' and moves three 'redefined' warnings from 'misc' to 'shadow'. Please could someone review it? |
From @rjbs* Ed Avis via RT <perlbug-followup@perl.org> [2015-12-10T07:10:29]
My first pass of review: looked mostly good, but... Made me wonder, though: what's the purpose of warning on "our $x; our $x;"? Is the idea "you probably meant something other than $x for one of them? and It's not really a shadowing, so I think the "shadow" category doesn't make -- |
From zefram@fysh.orgRicardo Signes wrote:
It *is* shadowing; it just happens that the two declarations have -zefram |
From @epaDo you want me to prepare a new patch that leaves 'our $x; our $x' in the If not, is there anything else you'd like to see fixed before the patch -- |
From @rjbs* Ed Avis <eda@waniasset.com> [2015-12-15T05:39:12]
I don't see a problem with this commit. Any objections before it's applied? -- |
From @epaThis bug has a patch waiting to be applied but I don't think it did get applied; could the current pumpking have another look please? |
From zefram@fysh.orgI have applied a slightly modified version of Ed's patch as commit -zefram |
|
@cpansprout - Status changed from 'open' to 'pending release' |
From @khwilliamsonThank you for filing this report. You have helped make Perl better. With the release yesterday of Perl 5.28.0, this and 185 other issues have been Perl 5.28.0 may be downloaded via: If you find that the problem persists, feel free to reopen this ticket. |
|
@khwilliamson - Status changed from 'pending release' to 'resolved' |
Migrated from rt.perl.org#125330 (status was 'resolved')
Searchable as RT125330$
The text was updated successfully, but these errors were encountered: