New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Broken test t/op/groups.t #12776
Comments
From Gryllida@gmail.comThis is a bug report for perl from Gryllida@gmail.com, Installing Perl 5.16.2 using perlbrew, t/op/groups.t fails: op/groups.t (Wstat: 0 Tests: 1 Failed: 0) Running it separately produces an output without a 'ok 1' or 'not ok 1' note for test 1: gry@localhost:~/perl5/perlbrew/build/perl-5.16.2$ ./perl t/op/groups.t Flags: Site configuration information for perl 5.16.2: Configured by gry at Fri Feb 15 16:18:00 PST 2013. Summary of my perl5 (revision 5 version 16 subversion 2) configuration: Locally applied patches: @INC for perl 5.16.2: Environment for perl 5.16.2: |
From @jkeenanOn Fri Feb 15 18:14:34 2013, Gryllida wrote:
This may be the same issue as Thank you very much. |
The RT System itself - Status changed from 'new' to 'open' |
From @demerphqJosh are you able to look into this? As far as I know the last patch Cheers, On 17 February 2013 00:17, James E Keenan via RT
-- |
From @jbenjoreOn Sat Feb 16 16:51:18 2013, demerphq wrote:
Yves, Any LDAP groups or similar must fit within the additional 3 groups for The `id` and/or `groups` commands however are not limited by the local It is possible that on Darwin perl's $( should call the libc function Further, it is just a rank stupid bug that this code can run and omit at |
From @jkeenanOn Sun Feb 17 15:42:59 2013, jbenjore wrote:
Josh, Yves: Do we have any more insight into this problem? Thank you very much. |
From @dcollinsnOn Fri Jul 12 18:24:55 2013, jkeenan wrote:
The suggestion to enhance the test in the first quoted paragraph aside, the present bug is that a failing test here looks like "tests out of sequence" and "bad plan" instead of "FAILED". The attached patch will correct that issue. -- |
From @dcollinsn0001-RT-116775-t-op-groups.t-Add-missing-nok-1.patchFrom 22b60163b28a88f5864605e8ef8c8918009b8f8c Mon Sep 17 00:00:00 2001
From: Dan Collins <dcollinsn@gmail.com>
Date: Fri, 30 Sep 2016 10:35:18 -0400
Subject: [PATCH] [RT #116775] t/op/groups.t: Add missing "nok 1"
---
t/op/groups.t | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/op/groups.t b/t/op/groups.t
index 912b2e9..06cd3f5 100644
--- a/t/op/groups.t
+++ b/t/op/groups.t
@@ -117,7 +117,7 @@ sub Test {
}
unless ( $ok1 ) {
-
+ print "nok 1 (perl's `\$(' disagrees with `${groups_command}'\n";
}
}
--
2.9.3
|
From [Unknown Contact. See original ticket]On Fri Jul 12 18:24:55 2013, jkeenan wrote:
The suggestion to enhance the test in the first quoted paragraph aside, the present bug is that a failing test here looks like "tests out of sequence" and "bad plan" instead of "FAILED". The attached patch will correct that issue. -- |
From @jkeenanOn Fri Sep 30 07:42:21 2016, dcollinsn@gmail.com wrote:
##### I generally don't like the use of the backtick character (`) to mean "single open quotation mark". But since that style is already established in the error messages in t/op/groups.t ... +1. Thank you very much. -- |
From @jkeenanOn Fri, 30 Sep 2016 14:42:21 GMT, dcollinsn@gmail.com wrote:
Since no significant objection was raised to this patch, I have pushed it to blead in commit 5107ee8. Thank you very much. |
@jkeenan - Status changed from 'open' to 'resolved' |
From @ilmari"James E Keenan via RT" <perlbug-followup@perl.org> writes:
I missed this when it went past and only noticed when I pulled blead The test is already loading test.pl, but not actually using any of its -- |
Migrated from rt.perl.org#116775 (status was 'resolved')
Searchable as RT116775$
The text was updated successfully, but these errors were encountered: