Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blead h2xs.t failure on HP-UX 11.23 IA-64 #11747

Closed
p5pRT opened this issue Nov 14, 2011 · 11 comments
Closed

blead h2xs.t failure on HP-UX 11.23 IA-64 #11747

p5pRT opened this issue Nov 14, 2011 · 11 comments

Comments

@p5pRT
Copy link

p5pRT commented Nov 14, 2011

Migrated from rt.perl.org#103566 (status was 'resolved')

Searchable as RT103566$

@p5pRT
Copy link
Author

p5pRT commented Nov 14, 2011

From @icerider70

Created by philip.monsen@pobox.com

h2xs.t failure observed during "make test". Details follow.
This is easily fixed by a small patch to h2xs (forthcoming).

$ ./perl harness -v ../lib/h2xs.t
../lib/h2xs.t ..
1..113
ok 1 - open 'h2xst.h'
ok 2 - close 'h2xst.h'
ok 3 - running ./perl "-I../lib" "-I../../lib" ../utils/h2xs -f -n h2xst
2>&1
ok 4 - running ./perl "-I../lib" "-I../../lib" ../utils/h2xs -f -n h2xst
2>&1
ok 5 - check for h2xst/ppport.h
ok 6 - check for h2xst/lib/h2xst.pm
ok 7 - check for h2xst/h2xst.xs
ok 8 - check for h2xst/fallback/const-c.inc
ok 9 - check for h2xst/fallback/const-xs.inc
ok 10 - check for h2xst/Makefile.PL
ok 11 - check for h2xst/README
ok 12 - check for h2xst/t/h2xst.t
ok 13 - check for h2xst/Changes
ok 14 - check for h2xst/MANIFEST
ok 15 - Are any extra files present?
ok 16 - No files in the MANIFEST should be missing
ok 17 - and all files present should be in the MANIFEST
ok 18 - open h2xst/lib/h2xst.pm
ok 19 - looking for /(?^​:use 5.015004;)/ in h2xst/lib/h2xst.pm
ok 20 - open h2xst/Makefile.PL
ok 21 - looking for /(?^​:use 5.015004;)/ in h2xst/Makefile.PL
ok 22 - running ./perl "-I../lib" "-I../../lib" ../utils/h2xs -f -n h2xst
-b 5.15.4 2>&1
ok 23 - running ./perl "-I../lib" "-I../../lib" ../utils/h2xs -f -n h2xst
-b 5.15.4 2>&1
ok 24 - check for h2xst/ppport.h
ok 25 - check for h2xst/lib/h2xst.pm
ok 26 - check for h2xst/h2xst.xs
ok 27 - check for h2xst/fallback/const-c.inc
ok 28 - check for h2xst/fallback/const-xs.inc
ok 29 - check for h2xst/Makefile.PL
ok 30 - check for h2xst/README
ok 31 - check for h2xst/t/h2xst.t
ok 32 - check for h2xst/Changes
ok 33 - check for h2xst/MANIFEST
ok 34 - Are any extra files present?
ok 35 - No files in the MANIFEST should be missing
ok 36 - and all files present should be in the MANIFEST
ok 37 - open h2xst/lib/h2xst.pm
ok 38 - looking for /(?^​:use 5.015004;)/ in h2xst/lib/h2xst.pm
ok 39 - open h2xst/Makefile.PL
ok 40 - looking for /(?^​:use 5.015004;)/ in h2xst/Makefile.PL
ok 41 - running ./perl "-I../lib" "-I../../lib" ../utils/h2xs -f -n h2xst
-b 5.6.1 2>&1
ok 42 - running ./perl "-I../lib" "-I../../lib" ../utils/h2xs -f -n h2xst
-b 5.6.1 2>&1
ok 43 - check for h2xst/ppport.h
ok 44 - check for h2xst/lib/h2xst.pm
ok 45 - check for h2xst/h2xst.xs
ok 46 - check for h2xst/fallback/const-c.inc
ok 47 - check for h2xst/fallback/const-xs.inc
ok 48 - check for h2xst/Makefile.PL
ok 49 - check for h2xst/README
ok 50 - check for h2xst/t/h2xst.t
ok 51 - check for h2xst/Changes
ok 52 - check for h2xst/MANIFEST
ok 53 - Are any extra files present?
ok 54 - No files in the MANIFEST should be missing
ok 55 - and all files present should be in the MANIFEST
ok 56 - open h2xst/lib/h2xst.pm
ok 57 - looking for /(?^​:use 5.006001;)/ in h2xst/lib/h2xst.pm
ok 58 - open h2xst/Makefile.PL
ok 59 - looking for /(?^​:use 5.006001;)/ in h2xst/Makefile.PL
ok 60 - running ./perl "-I../lib" "-I../../lib" ../utils/h2xs -f -n h2xst
-b 5.5.3 2>&1
ok 61 - running ./perl "-I../lib" "-I../../lib" ../utils/h2xs -f -n h2xst
-b 5.5.3 2>&1
ok 62 - check for h2xst/ppport.h
ok 63 - check for h2xst/lib/h2xst.pm
ok 64 - check for h2xst/h2xst.xs
ok 65 - check for h2xst/fallback/const-c.inc
ok 66 - check for h2xst/fallback/const-xs.inc
ok 67 - check for h2xst/Makefile.PL
ok 68 - check for h2xst/README
ok 69 - check for h2xst/t/h2xst.t
ok 70 - check for h2xst/Changes
ok 71 - check for h2xst/MANIFEST
ok 72 - Are any extra files present?
ok 73 - No files in the MANIFEST should be missing
ok 74 - and all files present should be in the MANIFEST
ok 75 - open h2xst/lib/h2xst.pm
ok 76 - looking for /(?^​:use 5.00503;)/ in h2xst/lib/h2xst.pm
ok 77 - open h2xst/Makefile.PL
ok 78 - looking for /(?^​:use 5.00503;)/ in h2xst/Makefile.PL
ok 79 - running ./perl "-I../lib" "-I../../lib" ../utils/h2xs "-X" -f -n
h2xst -b 5.15.4 2>&1
ok 80 - running ./perl "-I../lib" "-I../../lib" ../utils/h2xs "-X" -f -n
h2xst -b 5.15.4 2>&1
ok 81 - check for h2xst/lib/h2xst.pm
ok 82 - check for h2xst/Makefile.PL
ok 83 - check for h2xst/README
ok 84 - check for h2xst/t/h2xst.t
ok 85 - check for h2xst/Changes
ok 86 - check for h2xst/MANIFEST
ok 87 - Are any extra files present?
ok 88 - No files in the MANIFEST should be missing
ok 89 - and all files present should be in the MANIFEST
ok 90 - open h2xst/lib/h2xst.pm
ok 91 - looking for /(?^​:use 5.015004;)/ in h2xst/lib/h2xst.pm
ok 92 - open h2xst/Makefile.PL
ok 93 - looking for /(?^​:use 5.015004;)/ in h2xst/Makefile.PL
ok 94 - running ./perl "-I../lib" "-I../../lib" ../utils/h2xs -f -n h2xst
-b 5.15.4 h2xst.h 2>&1
not ok 95 - running ./perl "-I../lib" "-I../../lib" ../utils/h2xs -f -n
h2xst -b 5.15.4 h2xst.h 2>&1

# Failed test 'running ./perl "-I../lib" "-I../../lib" ../utils/h2xs -f
-n h2xst -b 5.15.4 h2xst.h 2>&1'
# at ../lib/h2xs.t line 187.
# got​: 'Use of uninitialized value in split at ../utils/h2xs line
758.
# Writing h2xst/ppport.h
# Writing h2xst/lib/h2xst.pm
# Writing h2xst/h2xst.xs
# Writing h2xst/fallback/const-c.inc
# Writing h2xst/fallback/const-xs.inc
# Writing h2xst/Makefile.PL
# Writing h2xst/README
# Writing h2xst/t/h2xst.t
# Writing h2xst/Changes
# Writing h2xst/MANIFEST
# '
# expected​: 'Writing h2xst/ppport.h
# Writing h2xst/lib/h2xst.pm
# Writing h2xst/h2xst.xs
# Writing h2xst/fallback/const-c.inc
# Writing h2xst/fallback/const-xs.inc
# Writing h2xst/Makefile.PL
# Writing h2xst/README
# Writing h2xst/t/h2xst.t
# Writing h2xst/Changes
# Writing h2xst/MANIFEST
# '
ok 96 - check for h2xst/ppport.h
ok 97 - check for h2xst/lib/h2xst.pm
ok 98 - check for h2xst/h2xst.xs
ok 99 - check for h2xst/fallback/const-c.inc
ok 100 - check for h2xst/fallback/const-xs.inc
ok 101 - check for h2xst/Makefile.PL
ok 102 - check for h2xst/README
ok 103 - check for h2xst/t/h2xst.t
ok 104 - check for h2xst/Changes
ok 105 - check for h2xst/MANIFEST
ok 106 - Are any extra files present?
ok 107 - No files in the MANIFEST should be missing
ok 108 - and all files present should be in the MANIFEST
ok 109 - open h2xst/lib/h2xst.pm
ok 110 - looking for /(?^​:use 5.015004;)/ in h2xst/lib/h2xst.pm
ok 111 - open h2xst/Makefile.PL
ok 112 - looking for /(?^​:use 5.015004;)/ in h2xst/Makefile.PL
ok 113 - unlink 'h2xst.h'
# Looks like you failed 1 test of 113.
Dubious, test returned 1 (wstat 256, 0x100)
Failed 1/113 subtests

Test Summary Report
-------------------
../lib/h2xs.t (Wstat​: 256 Tests​: 113 Failed​: 1)
  Failed test​: 95
  Non-zero exit status​: 1
Files=1, Tests=113, 1 wallclock secs ( 0.05 usr 0.02 sys + 1.20 cusr
0.25 csys = 1.52 CPU)
Result​: FAIL

Perl Info

Flags:
    category=core
    severity=low

Site configuration information for perl 5.15.4:

Configured by monsp at Mon Nov 14 07:06:21 CST 2011.

Summary of my perl5 (revision 5 version 15 subversion 4) configuration:
  Commit id: e6bd4dde312159cd87f0d24e96f473538c89d0d8
  Platform:
    osname=hpux, osvers=11.23, archname=IA64.ARCHREV_0-LP64
    uname='hp-ux rp5 b.11.23 u ia64 3731604725 unlimited-user license '
    config_args='-des -Uuseithreads -Uglibpth -Ulocincpth -Uloclibpth
-Dusedevel -Duse64bitall -Dcc=aCC -Dccflags=+DD64 -Ae +DSnative
-D_XOPEN_SOURCE -D_XOPEN_SOURCE_EXTENDED -D_HPUX_ALT_XOPEN_SOCKET_API
-D_HPUX_SOURCE -Wl,+vnocompatwarnings -Doptimize=+O2 +Onolimit
-Dld=/usr/bin/ld -Dldflags=+DD64 -L/usr/lib/hpux64 -Dlibpth=/lib/hpux64
/usr/lib/hpux64 /usr/ccs/lib -Dlibs=-lnsl -lnm -ldl -ldld -lm -lsec -lc
-DDEBUGGING'
    hint=recommended, useposix=true, d_sigaction=define
    useithreads=undef, usemultiplicity=undef
    useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef
    use64bitint=define, use64bitall=define, uselongdouble=undef
    usemymalloc=n, bincompat5005=undef
  Compiler:
    cc='aCC', ccflags =' -Ae +DD64 +DSnative -D_XOPEN_SOURCE
-D_XOPEN_SOURCE_EXTENDED -D_HPUX_ALT_XOPEN_SOCKET_API
-Wl,+vnocompatwarnings -D_HPUX_SOURCE -Wl,+vnocompatwarnings +DD64
-DDEBUGGING -D_LARGEFILE_SOURCE -D_FILE_OFFSET_BITS=64 ',
    optimize='+O2 +Onolimit -g',
    cppflags='-Aa -D__STDC_EXT__ +DD64 +DSnative -D_XOPEN_SOURCE
-D_XOPEN_SOURCE_EXTENDED -D_HPUX_ALT_XOPEN_SOCKET_API
-Wl,+vnocompatwarnings -D_HPUX_SOURCE -Ae +DD64 +DSnative -D_XOPEN_SOURCE
-D_XOPEN_SOURCE_EXTENDED -D_HPUX_ALT_XOPEN_SOCKET_API
-Wl,+vnocompatwarnings -D_HPUX_SOURCE -Wl,+vnocompatwarnings +DD64
-DDEBUGGING'
    ccversion='B3910B', gccversion='', gccosandvers=''
    intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=87654321
    d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16
    ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t',
lseeksize=8
    alignbytes=8, prototype=define
  Linker and Libraries:
    ld='/usr/bin/ld', ldflags ='+DD64 -L/usr/lib/hpux64 +DD64'
    libpth=/lib/hpux64 /usr/lib/hpux64 /usr/ccs/lib
    libs=-lnsl -lnm -ldl -ldld -lm -lsec -lc
    perllibs=-lnsl -lnm -ldl -ldld -lm -lsec -lc
    libc=/usr/lib/hpux64/libc.so, so=so, useshrplib=false, libperl=libperl.a
    gnulibc_version=''
  Dynamic Linking:
    dlsrc=dl_hpux.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E
-Wl,-B,deferred '
    cccdlflags='+Z', lddlflags='-b +vnocompatwarnings -L/usr/lib/hpux64'

Locally applied patches:



@INC for perl 5.15.4:
    lib
    /apps/util/tools/xxxx/opt/perl/lib
    /apps/util/tools/xxxx/opt/perl/lib/site_perl
    /sysapps/perl/lib
    /sysapps/perl/lib/site_perl
    /apps/util/tools/xxxx/perllib

/work/monsp/open-source/perl-install/blead/lib/site_perl/5.15.4/IA64.ARCHREV_0-LP64
    /work/monsp/open-source/perl-install/blead/lib/site_perl/5.15.4

/work/monsp/open-source/perl-install/blead/lib/5.15.4/IA64.ARCHREV_0-LP64
    /work/monsp/open-source/perl-install/blead/lib/5.15.4
    .


Environment for perl 5.15.4:
    HOME=/home/monsp
    LANG (unset)
    LANGUAGE (unset)
    LD_LIBRARY_PATH=/work/monsp/open-source/perl-alt
    LOGDIR (unset)

PATH=/apps/util/tools/xxxx/opt/subversion/bin:/apps/util/tools/xxxx/opt/git/bin:/apps/util/tools/xxxx/usr/bin:/sysapps/bin:/sysapps/bin2:/opt/ssh/bin:/usr/bin:/usr/ccs/bin:/usr/contrib/bin:/usr/bin/X11:/opt/perf/bin:/usr/contrib/bin/X11:/opt/aCC/bin:/opt/langtools/bin
    PERL5LIB (unset)
    PERL_BADLANG (unset)
    SHELL=/usr/bin/ksh

@p5pRT
Copy link
Author

p5pRT commented Nov 14, 2011

From @icerider70

The attached patch to utils/h2xs.PL moves the failing h2xs.t test to
passing.

--Phil

@p5pRT
Copy link
Author

p5pRT commented Nov 14, 2011

From @icerider70

0001-Fixed-uninit-val-warning-to-cure-h2xs.t-test-failure.patch
From 193d369f46c0649d62f4fb88de854959d336815d Mon Sep 17 00:00:00 2001
From: Philip Monsen <philip.monsen@pobox.com>
Date: Mon, 14 Nov 2011 09:14:46 -0600
Subject: [PATCH] Fixed uninit val warning to cure h2xs.t test failure
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="------------1.7.7.3"

This is a multi-part message in MIME format.
--------------1.7.7.3
Content-Type: text/plain; charset=UTF-8; format=fixed
Content-Transfer-Encoding: 8bit

---
 utils/h2xs.PL |    3 ++-
 1 files changed, 2 insertions(+), 1 deletions(-)


--------------1.7.7.3
Content-Type: text/x-patch; name="0001-Fixed-uninit-val-warning-to-cure-h2xs.t-test-failure.patch"
Content-Transfer-Encoding: 8bit
Content-Disposition: attachment; filename="0001-Fixed-uninit-val-warning-to-cure-h2xs.t-test-failure.patch"

diff --git a/utils/h2xs.PL b/utils/h2xs.PL
index 634e891..cb38a4b 100644
--- a/utils/h2xs.PL
+++ b/utils/h2xs.PL
@@ -789,7 +789,8 @@ if( @path_h ){
     }
     else {
       @paths = (File::Spec->curdir(), $Config{usrinc},
-		(split ' ', $Config{locincpth}), '/usr/include');
+		(split ' ', defined($Config{locincpth}) ? $Config{locincpth} : ''),
+		'/usr/include');
     }
     foreach my $path_h (@path_h) {
         $name ||= $path_h;

--------------1.7.7.3--


@p5pRT
Copy link
Author

p5pRT commented Nov 14, 2011

From @Tux

On Mon, 14 Nov 2011 09​:22​:04 -0600, Philip Monsen
<philip.monsen@​pobox.com> wrote​:

The attached patch to utils/h2xs.PL moves the failing h2xs.t test to
passing.

--Phil

Why does it not fail on my HP-UX 11.23 IA-64?

We're rather modern perl by now ...

And I'm somewhat icky about split ' '. Shouldn't that be split / / ?

--- a/utils/h2xs.PL
+++ b/utils/h2xs.PL
@​@​ -789,7 +789,8 @​@​ if( @​path_h ){
  }
  else {
  @​paths = (File​::Spec->curdir(), $Config{usrinc},
- (split ' ', $Config{locincpth}), '/usr/include');
+ (split ' ', $Config{locincpth} // ""), '/usr/include');
  }
  foreach my $path_h (@​path_h) {
  $name ||= $path_h;

--
H.Merijn Brand http​://tux.nl Perl Monger http​://amsterdam.pm.org/
using 5.00307 through 5.14 and porting perl5.15.x on HP-UX 10.20, 11.00,
11.11, 11.23 and 11.31, OpenSuSE 10.1, 11.0 .. 11.4 and AIX 5.2 and 5.3.
http​://mirrors.develooper.com/hpux/ http​://www.test-smoke.org/
http​://qa.perl.org http​://www.goldmark.org/jeff/stupid-disclaimers/

@p5pRT
Copy link
Author

p5pRT commented Nov 14, 2011

The RT System itself - Status changed from 'new' to 'open'

@p5pRT
Copy link
Author

p5pRT commented Nov 14, 2011

From @icerider70

On Mon, Nov 14, 2011 at 10​:32 AM, H.Merijn Brand <h.m.brand@​xs4all.nl>wrote​:

Why does it not fail on my HP-UX 11.23 IA-64?

Probably because your $Config{locincpth} is set to something and mine
isn't, based on our different build environments and args to Configure.

We're rather modern perl by now ...

And I'm somewhat icky about split ' '. Shouldn't that be split / / ?

--- a/utils/h2xs.PL
+++ b/utils/h2xs.PL
@​@​ -789,7 +789,8 @​@​ if( @​path_h ){
}
else {
@​paths = (File​::Spec->curdir(), $Config{usrinc},
- (split ' ', $Config{locincpth}), '/usr/include');
+ (split ' ', $Config{locincpth} // ""), '/usr/include');
}
foreach my $path_h (@​path_h) {
$name ||= $path_h;

I don't have strong feelings about the exact syntax used for the patch.
The main thing is to assure that split gets something defined to operate on.

--Phil

@p5pRT
Copy link
Author

p5pRT commented Nov 15, 2011

From @icerider70

On Mon, Nov 14, 2011 at 11​:09 AM, Philip Monsen <philip.monsen@​gmail.com>wrote​:

On Mon, Nov 14, 2011 at 10​:32 AM, H.Merijn Brand <h.m.brand@​xs4all.nl>wrote​:

Why does it not fail on my HP-UX 11.23 IA-64?

Probably because your $Config{locincpth} is set to something and mine
isn't, based on our different build environments and args to Configure.

Thusly, I think the name of the bug should be changed more generally to
"h2xs.t fails when $Config{locincpth} is undefined.

--Phil

@p5pRT
Copy link
Author

p5pRT commented Nov 17, 2011

From @icerider70

Looks like this was resolved with commit
3ac704c.

This ticket can be closed.

@p5pRT
Copy link
Author

p5pRT commented Aug 18, 2016

@dcollinsn - Status changed from 'open' to 'resolved'

@p5pRT p5pRT closed this as completed Aug 18, 2016
@p5pRT
Copy link
Author

p5pRT commented Aug 18, 2016

From @dcollinsn

On Thu Nov 17 10​:16​:11 2011, icerider wrote​:

Looks like this was resolved with commit
3ac704c.

This ticket can be closed.

Resolving per Phil.

--
Respectfully,
Dan Collins

@p5pRT
Copy link
Author

p5pRT commented Aug 18, 2016

From [Unknown Contact. See original ticket]

On Thu Nov 17 10​:16​:11 2011, icerider wrote​:

Looks like this was resolved with commit
3ac704c.

This ticket can be closed.

Resolving per Phil.

--
Respectfully,
Dan Collins

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant